Razvan Lupusoru a88274f008
[mlir][acc] Support lazy remark message construction (#180665)
The OpenACC remark emission utilities previously only accepted Twine for
message construction. However, complex remarks often require additional
logic to build messages, such as resolving variable names. This results
in unnecessary work when remarks are disabled.

Add an overload that accepts a lambda for message generation, which is
only invoked when remark emission is enabled. Update ACCLoopTiling to
use this lazy API for tile size reporting.

Additionally, getVariableName now returns numeric strings for constant
integer values. This is also being used by ACCLoopTiling along with the
lazy remark update.
2026-02-10 10:13:19 -08:00

68 lines
2.3 KiB
C++

//===- OpenACCSupport.cpp - OpenACCSupport Implementation -----------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
//
// This file implements the OpenACCSupport analysis interface.
//
//===----------------------------------------------------------------------===//
#include "mlir/Dialect/OpenACC/Analysis/OpenACCSupport.h"
#include "mlir/Dialect/OpenACC/OpenACCUtils.h"
namespace mlir {
namespace acc {
std::string OpenACCSupport::getVariableName(Value v) {
if (impl)
return impl->getVariableName(v);
return acc::getVariableName(v);
}
std::string OpenACCSupport::getRecipeName(RecipeKind kind, Type type,
Value var) {
if (impl)
return impl->getRecipeName(kind, type, var);
// The default implementation assumes that only type matters
// and the actual instance of variable is not relevant.
auto recipeName = acc::getRecipeName(kind, type);
if (recipeName.empty())
emitNYI(var ? var.getLoc() : UnknownLoc::get(type.getContext()),
"variable privatization (incomplete recipe name handling)");
return recipeName;
}
InFlightDiagnostic OpenACCSupport::emitNYI(Location loc, const Twine &message) {
if (impl)
return impl->emitNYI(loc, message);
return mlir::emitError(loc, "not yet implemented: " + message);
}
remark::detail::InFlightRemark
OpenACCSupport::emitRemark(Operation *op,
std::function<std::string()> messageFn,
llvm::StringRef category) {
if (impl)
return impl->emitRemark(op, std::move(messageFn), category);
return acc::emitRemark(op, messageFn(), category);
}
bool OpenACCSupport::isValidSymbolUse(Operation *user, SymbolRefAttr symbol,
Operation **definingOpPtr) {
if (impl)
return impl->isValidSymbolUse(user, symbol, definingOpPtr);
return acc::isValidSymbolUse(user, symbol, definingOpPtr);
}
bool OpenACCSupport::isValidValueUse(Value v, Region &region) {
if (impl)
return impl->isValidValueUse(v, region);
return acc::isValidValueUse(v, region);
}
} // namespace acc
} // namespace mlir