8a820f133a
This commit introduces the `#llvm.address_space` attribute. This
attribute implements the `ptr::MemorySpaceAttrInterface`, establishing
the semantics of the LLVM address space.
This allows making `!ptr.ptr` translatable to LLVM IR as long it uses
the `#llvm.address_space` attribute.
Concretely, `!ptr.ptr<#llvm.address_space<N>>` now translates to `ptr
addrspace(N)`.
Additionally, this patch makes `PtrLikeTypes` with no metadata, no
element type, and with `#llvm.address_space` memory space, compatible
with the LLVM dialect.
**Infrastructure Updates:**
- Refactor `ptr::MemorySpaceAttrInterface` to include DataLayout
parameter for better validation
- Add new utility functions `LLVM::isLoadableType()` and
`LLVM::isTypeCompatibleWithAtomicOp()`
- Update type compatibility checks to support ptr-like types with LLVM
address spaces
- Splice the `MemorySpaceAttrInterface` to its own library, so the
LLVMDialect won't depend on the PtrDialect yet
**Translation Support:**
- New `PtrToLLVMIRTranslation` module for converting ptr dialect to LLVM
IR
- Type translation support for ptr types with LLVM address spaces
- Proper address space preservation during IR lowering
Example:
```mlir
llvm.func @llvm_ops_with_ptr_values(%arg0: !llvm.ptr) {
%1 = llvm.load %arg0 : !llvm.ptr -> !ptr.ptr<#llvm.address_space<1>>
llvm.store %1, %arg0 : !ptr.ptr<#llvm.address_space<1>>, !llvm.ptr
llvm.return
}
```
Translates to:
```llvmir
; ModuleID = 'LLVMDialectModule'
source_filename = "LLVMDialectModule"
define void @llvm_ops_with_ptr_values(ptr %0) {
%2 = load ptr addrspace(1), ptr %0, align 8
store ptr addrspace(1) %2, ptr %0, align 8
ret void
}
!llvm.module.flags = !{!0}
!0 = !{i32 2, !"Debug Info Version", i32 3}
```
89 lines
3.3 KiB
C++
89 lines
3.3 KiB
C++
//===- PtrAttrs.cpp - Pointer dialect attributes ----------------*- C++ -*-===//
|
|
//
|
|
// This file is licensed under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file defines the Ptr dialect attributes.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "mlir/Dialect/Ptr/IR/PtrAttrs.h"
|
|
|
|
using namespace mlir;
|
|
using namespace mlir::ptr;
|
|
|
|
constexpr const static unsigned kBitsInByte = 8;
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
// GenericSpaceAttr
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
bool GenericSpaceAttr::isValidLoad(
|
|
Type type, ptr::AtomicOrdering ordering, std::optional<int64_t> alignment,
|
|
const ::mlir::DataLayout *dataLayout,
|
|
function_ref<InFlightDiagnostic()> emitError) const {
|
|
return true;
|
|
}
|
|
|
|
bool GenericSpaceAttr::isValidStore(
|
|
Type type, ptr::AtomicOrdering ordering, std::optional<int64_t> alignment,
|
|
const ::mlir::DataLayout *dataLayout,
|
|
function_ref<InFlightDiagnostic()> emitError) const {
|
|
return true;
|
|
}
|
|
|
|
bool GenericSpaceAttr::isValidAtomicOp(
|
|
ptr::AtomicBinOp op, Type type, ptr::AtomicOrdering ordering,
|
|
std::optional<int64_t> alignment, const ::mlir::DataLayout *dataLayout,
|
|
function_ref<InFlightDiagnostic()> emitError) const {
|
|
return true;
|
|
}
|
|
|
|
bool GenericSpaceAttr::isValidAtomicXchg(
|
|
Type type, ptr::AtomicOrdering successOrdering,
|
|
ptr::AtomicOrdering failureOrdering, std::optional<int64_t> alignment,
|
|
const ::mlir::DataLayout *dataLayout,
|
|
function_ref<InFlightDiagnostic()> emitError) const {
|
|
return true;
|
|
}
|
|
|
|
bool GenericSpaceAttr::isValidAddrSpaceCast(
|
|
Type tgt, Type src, function_ref<InFlightDiagnostic()> emitError) const {
|
|
// TODO: update this method once the `addrspace_cast` op is added to the
|
|
// dialect.
|
|
assert(false && "unimplemented, see TODO in the source.");
|
|
return false;
|
|
}
|
|
|
|
bool GenericSpaceAttr::isValidPtrIntCast(
|
|
Type intLikeTy, Type ptrLikeTy,
|
|
function_ref<InFlightDiagnostic()> emitError) const {
|
|
// TODO: update this method once the int-cast ops are added to the dialect.
|
|
assert(false && "unimplemented, see TODO in the source.");
|
|
return false;
|
|
}
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
// SpecAttr
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
LogicalResult SpecAttr::verify(function_ref<InFlightDiagnostic()> emitError,
|
|
uint32_t size, uint32_t abi, uint32_t preferred,
|
|
uint32_t index) {
|
|
if (size % kBitsInByte != 0)
|
|
return emitError() << "size entry must be divisible by 8";
|
|
if (abi % kBitsInByte != 0)
|
|
return emitError() << "abi entry must be divisible by 8";
|
|
if (preferred % kBitsInByte != 0)
|
|
return emitError() << "preferred entry must be divisible by 8";
|
|
if (index != kOptionalSpecValue && index % kBitsInByte != 0)
|
|
return emitError() << "index entry must be divisible by 8";
|
|
if (abi > preferred)
|
|
return emitError() << "preferred alignment is expected to be at least "
|
|
"as large as ABI alignment";
|
|
return success();
|
|
}
|