efc6d33be9
When `FileAction` opens file with write access, it doesn't clear the file nor append to the end of the file if it already exists. Instead, it writes from cursor index 0. For example, by using the settings `target.output-path` and `target.error-path`, lldb will redirect process stdout/stderr to files. It then calls this function to write to the files which the above symptoms appear. ## Test - Added unit test checking the file flags - Added 2 api tests checking - File content overwritten if the file path already exists - Stdout and stderr redirection to the same file doesn't change its behavior
90 lines
2.2 KiB
C++
90 lines
2.2 KiB
C++
//===-- FileAction.cpp ----------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include <fcntl.h>
|
|
|
|
#include "lldb/Host/FileAction.h"
|
|
#include "lldb/Host/PosixApi.h"
|
|
#include "lldb/Utility/Stream.h"
|
|
|
|
using namespace lldb_private;
|
|
|
|
// FileAction member functions
|
|
|
|
FileAction::FileAction() : m_file_spec() {}
|
|
|
|
void FileAction::Clear() {
|
|
m_action = eFileActionNone;
|
|
m_fd = -1;
|
|
m_arg = -1;
|
|
m_file_spec.Clear();
|
|
}
|
|
|
|
llvm::StringRef FileAction::GetPath() const {
|
|
return m_file_spec.GetPathAsConstString().AsCString();
|
|
}
|
|
|
|
const FileSpec &FileAction::GetFileSpec() const { return m_file_spec; }
|
|
|
|
bool FileAction::Open(int fd, const FileSpec &file_spec, bool read,
|
|
bool write) {
|
|
if ((read || write) && fd >= 0 && file_spec) {
|
|
m_action = eFileActionOpen;
|
|
m_fd = fd;
|
|
if (read && write)
|
|
m_arg = O_NOCTTY | O_CREAT | O_RDWR;
|
|
else if (read)
|
|
m_arg = O_NOCTTY | O_RDONLY;
|
|
else
|
|
m_arg = O_NOCTTY | O_CREAT | O_WRONLY | O_TRUNC;
|
|
m_file_spec = file_spec;
|
|
return true;
|
|
} else {
|
|
Clear();
|
|
}
|
|
return false;
|
|
}
|
|
|
|
bool FileAction::Close(int fd) {
|
|
Clear();
|
|
if (fd >= 0) {
|
|
m_action = eFileActionClose;
|
|
m_fd = fd;
|
|
}
|
|
return m_fd >= 0;
|
|
}
|
|
|
|
bool FileAction::Duplicate(int fd, int dup_fd) {
|
|
Clear();
|
|
if (fd >= 0 && dup_fd >= 0) {
|
|
m_action = eFileActionDuplicate;
|
|
m_fd = fd;
|
|
m_arg = dup_fd;
|
|
}
|
|
return m_fd >= 0;
|
|
}
|
|
|
|
void FileAction::Dump(Stream &stream) const {
|
|
stream.PutCString("file action: ");
|
|
switch (m_action) {
|
|
case eFileActionClose:
|
|
stream.Printf("close fd %d", m_fd);
|
|
break;
|
|
case eFileActionDuplicate:
|
|
stream.Printf("duplicate fd %d to %d", m_fd, m_arg);
|
|
break;
|
|
case eFileActionNone:
|
|
stream.PutCString("no action");
|
|
break;
|
|
case eFileActionOpen:
|
|
stream.Printf("open fd %d with '%s', OFLAGS = 0x%x", m_fd,
|
|
m_file_spec.GetPath().c_str(), m_arg);
|
|
break;
|
|
}
|
|
}
|