67cbfb9d8c
Resolves #99114. Tasks completed: - Implement `faceforward` in `hlsl_intrinsics.h`/`hlsl_intrinsic_helpers.h` - Implement `faceforward` SPIR-V target builtin in `clang/include/clang/Basic/BuiltinsSPIRV.td` - Add a SPIR-V fast path in `hlsl_intrinsic_helpers.h` - Add sema checks for `faceforward` to `CheckSPIRVBuiltinFunctionCall` in `clang/lib/Sema/SemaSPIRV.cpp` - Add codegen for SPIR-V `faceforward` builtin to `EmitSPIRVBuiltinExpr` in `SPIR.cpp` - Add HLSL codegen tests to `clang/test/CodeGenHLSL/builtins/faceforward.hlsl` - Add SPIRV builtin codegen tests to `clang/test/CodeGenSPIRV/Builtins/faceforward.c` - Add sema tests to `clang/test/SemaHLSL/BuiltIns/faceforward-errors.hlsl` - Add spirv sema tests to `clang/test/SemaSPIRV/BuiltIns/faceforward-errors.c` - Create the `int_spv_faceforward` intrinsic in `IntrinsicsSPIRV.td` - In `SPIRVInstructionSelector.cpp` create the `faceforward` lowering and map it to `int_spv_faceforward` in `SPIRVInstructionSelector::selectIntrinsic` - Create SPIR-V backend test case in `llvm/test/CodeGen/SPIRV/hlsl-intrinsics/faceforward.ll` Incomplete tasks: - Create SPIR-V backend test case in `llvm/test/CodeGen/SPIRV/opencl/faceforward.ll` - Not applicable because the OpenCL SPIR-V extended instruction set does not include a `faceforward` function Follow-up tasks: - Implement pattern matching for `faceforward` in `SPIRVCombine.td` and `SPIRVPreLegalizerCombiner.cpp` - In `faceforward.ll`, change `--target-env spv1.4` to `vulkan1.3` and update the test accordingly once [#136344](https://github.com/llvm/llvm-project/issues/136344) has been resolved
89 lines
3.9 KiB
C++
89 lines
3.9 KiB
C++
//===--------- SPIR.cpp - Emit LLVM Code for builtins ---------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This contains code to emit Builtin calls as LLVM code.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "CGHLSLRuntime.h"
|
|
#include "CodeGenFunction.h"
|
|
#include "clang/Basic/TargetBuiltins.h"
|
|
#include "llvm/IR/Intrinsics.h"
|
|
|
|
using namespace clang;
|
|
using namespace CodeGen;
|
|
using namespace llvm;
|
|
|
|
Value *CodeGenFunction::EmitSPIRVBuiltinExpr(unsigned BuiltinID,
|
|
const CallExpr *E) {
|
|
switch (BuiltinID) {
|
|
case SPIRV::BI__builtin_spirv_distance: {
|
|
Value *X = EmitScalarExpr(E->getArg(0));
|
|
Value *Y = EmitScalarExpr(E->getArg(1));
|
|
assert(E->getArg(0)->getType()->hasFloatingRepresentation() &&
|
|
E->getArg(1)->getType()->hasFloatingRepresentation() &&
|
|
"Distance operands must have a float representation");
|
|
assert(E->getArg(0)->getType()->isVectorType() &&
|
|
E->getArg(1)->getType()->isVectorType() &&
|
|
"Distance operands must be a vector");
|
|
return Builder.CreateIntrinsic(
|
|
/*ReturnType=*/X->getType()->getScalarType(), Intrinsic::spv_distance,
|
|
ArrayRef<Value *>{X, Y}, nullptr, "spv.distance");
|
|
}
|
|
case SPIRV::BI__builtin_spirv_length: {
|
|
Value *X = EmitScalarExpr(E->getArg(0));
|
|
assert(E->getArg(0)->getType()->hasFloatingRepresentation() &&
|
|
"length operand must have a float representation");
|
|
assert(E->getArg(0)->getType()->isVectorType() &&
|
|
"length operand must be a vector");
|
|
return Builder.CreateIntrinsic(
|
|
/*ReturnType=*/X->getType()->getScalarType(), Intrinsic::spv_length,
|
|
ArrayRef<Value *>{X}, nullptr, "spv.length");
|
|
}
|
|
case SPIRV::BI__builtin_spirv_reflect: {
|
|
Value *I = EmitScalarExpr(E->getArg(0));
|
|
Value *N = EmitScalarExpr(E->getArg(1));
|
|
assert(E->getArg(0)->getType()->hasFloatingRepresentation() &&
|
|
E->getArg(1)->getType()->hasFloatingRepresentation() &&
|
|
"Reflect operands must have a float representation");
|
|
assert(E->getArg(0)->getType()->isVectorType() &&
|
|
E->getArg(1)->getType()->isVectorType() &&
|
|
"Reflect operands must be a vector");
|
|
return Builder.CreateIntrinsic(
|
|
/*ReturnType=*/I->getType(), Intrinsic::spv_reflect,
|
|
ArrayRef<Value *>{I, N}, nullptr, "spv.reflect");
|
|
}
|
|
case SPIRV::BI__builtin_spirv_smoothstep: {
|
|
Value *Min = EmitScalarExpr(E->getArg(0));
|
|
Value *Max = EmitScalarExpr(E->getArg(1));
|
|
Value *X = EmitScalarExpr(E->getArg(2));
|
|
assert(E->getArg(0)->getType()->hasFloatingRepresentation() &&
|
|
E->getArg(1)->getType()->hasFloatingRepresentation() &&
|
|
E->getArg(2)->getType()->hasFloatingRepresentation() &&
|
|
"SmoothStep operands must have a float representation");
|
|
return Builder.CreateIntrinsic(
|
|
/*ReturnType=*/Min->getType(), Intrinsic::spv_smoothstep,
|
|
ArrayRef<Value *>{Min, Max, X}, /*FMFSource=*/nullptr,
|
|
"spv.smoothstep");
|
|
}
|
|
case SPIRV::BI__builtin_spirv_faceforward: {
|
|
Value *N = EmitScalarExpr(E->getArg(0));
|
|
Value *I = EmitScalarExpr(E->getArg(1));
|
|
Value *Ng = EmitScalarExpr(E->getArg(2));
|
|
assert(E->getArg(0)->getType()->hasFloatingRepresentation() &&
|
|
E->getArg(1)->getType()->hasFloatingRepresentation() &&
|
|
E->getArg(2)->getType()->hasFloatingRepresentation() &&
|
|
"FaceForward operands must have a float representation");
|
|
return Builder.CreateIntrinsic(
|
|
/*ReturnType=*/N->getType(), Intrinsic::spv_faceforward,
|
|
ArrayRef<Value *>{N, I, Ng}, /*FMFSource=*/nullptr, "spv.faceforward");
|
|
}
|
|
}
|
|
return nullptr;
|
|
}
|