43c26bbc42
When building overlay mode with GCC in release mode, glibc's stdlib.h
contains
an extern inline declaration of bsearch. This breaks our use of the
gnu::alias
function attribute in LLVM_LIBC_FUNCTION with GCC because GCC checks
that the
aliasee is defined in the same TU (clang does not).
We're looking at also potentially updating our definition of
LLVM_LIBC_FUNCTION
from libc/src/__support/common.h. Upon testing, I was able to get
-Wnonnull-compare diagnostics from GCC in our definition of bsearch
because
glibc declares bsearch with the fugly nonnull function attribute.
There's more we can do here though to improve our implementation of
bsearch.
7.24.5.1 says:
Pointer arguments on such a call shall still have valid values, as
described in 7.1.4.
We could also use either function attributes or parameter attributes to
denote
these should not be null (for users/callers) and perhaps still check for
non-null explicitly under some yet to be discussed hardening
configurations in
the future.
Link: #60481
Link:
https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-nonnull-function-attribute
22 lines
726 B
C++
22 lines
726 B
C++
//===-- Implementation header for bsearch -----------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLVM_LIBC_SRC_STDLIB_BSEARCH_H
|
|
#define LLVM_LIBC_SRC_STDLIB_BSEARCH_H
|
|
|
|
#include <stddef.h> // size_t
|
|
|
|
namespace LIBC_NAMESPACE {
|
|
|
|
void *bsearch(const void *key, const void *array, size_t array_size,
|
|
size_t elem_size, int (*compare)(const void *, const void *));
|
|
|
|
} // namespace LIBC_NAMESPACE
|
|
|
|
#endif //LLVM_LIBC_SRC_STDLIB_BSEARCH_H
|