6c16aa4f67
In general all the basic functionality seems to work and removes some redundancy
and more complicated features in favor of borrowing infrastructure from LLVM
build configurations. Here's a quick summary of details and remaining issues:
* Testing has spanned Ubuntu 18.04 & 19.10, CentOS 7, RHEL 8, and
MacOS/darwin. Architectures include x86_64 and Arm. Without
access to Window nothing has been tested there yet.
* As we change file and directory naming schemes (i.e.,
capitalization) some odd things can occur on MacOS systems with
case preserving but not case senstive file system configurations.
Can be painful and certainly something to watch out for as any
any such changes continue.
* Testing infrastructure still needs to be tuned up and worked on.
Note that there do appear to be cases of some tests hanging (on
MacOS in particular). They appear unrelated to the build
process.
* Shared library configurations need testing (and probably fixing).
* Tested both standalone and 'in-mono repo' builds. Changes for
supporting the mono repo builds will require LLVM-level changes that
are straightforward when the time comes.
* The configuration contains a work-around for LLVM's C++ standard mode
passing down into Flang/F18 builds (i.e., LLVM CMake configuration would
force a -std=c++11 flag to show up in command line arguments. The
current configuration removes that automatically and is more strict in
following new CMake guidelines for enforcing C++17 mode across all the
CMake files.
* Cleaned up a lot of repetition in the command line arguments. It
is likely that more work is still needed to both allow for
customization and working around CMake defailts (or those
inherited from LLVM's configuration files). On some platforms agressive
optimization flags (e.g. -O3) can actually break builds due to the inlining
of templates in .cpp source files that then no longer are available for use
cases outside those source files (shows up as link errors). Sticking at -O2
appears to fix this. Currently this CMake configuration forces this in
release mode but at the cost of stomping on any CMake, or user customized,
settings for the release flags.
* Made the lit tests non-source directory dependent where appropriate. This is
done by configuring certain test shell files to refer to the correct paths
whether an in or out of tree build is being performed. These configured
files are output in the build directory. A %B substitution is introduced in
lit to refer to the build directory, mirroring the %S substitution for the
source directory, so that the tests can refer to the configured shell scripts.
Co-authored-by: David Truby <david.truby@arm.com>
Original-commit: flang-compiler/f18@d1c7184159
Reviewed-on: https://github.com/flang-compiler/f18/pull/1045
329 lines
7.6 KiB
Fortran
329 lines
7.6 KiB
Fortran
! RUN: %B/test/Semantics/test_errors.sh %s %flang %t
|
|
! C1135 A cycle-stmt shall not appear within a CHANGE TEAM, CRITICAL, or DO
|
|
! CONCURRENT construct if it belongs to an outer construct.
|
|
!
|
|
! C1167 -- An exit-stmt shall not appear within a DO CONCURRENT construct if
|
|
! it belongs to that construct or an outer construct.
|
|
!
|
|
! C1168 -- An exit-stmt shall not appear within a CHANGE TEAM or CRITICAL
|
|
! construct if it belongs to an outer construct.
|
|
|
|
subroutine s1()
|
|
!ERROR: No matching DO construct for CYCLE statement
|
|
cycle
|
|
end subroutine s1
|
|
|
|
subroutine s2()
|
|
!ERROR: No matching construct for EXIT statement
|
|
exit
|
|
end subroutine s2
|
|
|
|
subroutine s3()
|
|
level0: block
|
|
!ERROR: No matching DO construct for CYCLE statement
|
|
cycle level0
|
|
end block level0
|
|
end subroutine s3
|
|
|
|
subroutine s4()
|
|
level0: do i = 1, 10
|
|
level1: do concurrent (j = 1:20)
|
|
!ERROR: CYCLE must not leave a DO CONCURRENT statement
|
|
cycle level0
|
|
end do level1
|
|
end do level0
|
|
end subroutine s4
|
|
|
|
subroutine s5()
|
|
level0: do i = 1, 10
|
|
level1: do concurrent (j = 1:20)
|
|
!ERROR: EXIT must not leave a DO CONCURRENT statement
|
|
exit level0
|
|
end do level1
|
|
end do level0
|
|
end subroutine s5
|
|
|
|
subroutine s6()
|
|
level0: do i = 1, 10
|
|
level1: critical
|
|
!ERROR: CYCLE must not leave a CRITICAL statement
|
|
cycle level0
|
|
end critical level1
|
|
end do level0
|
|
end subroutine s6
|
|
|
|
subroutine s7()
|
|
level0: do i = 1, 10
|
|
level1: critical
|
|
!ERROR: EXIT must not leave a CRITICAL statement
|
|
exit level0
|
|
end critical level1
|
|
end do level0
|
|
end subroutine s7
|
|
|
|
subroutine s8()
|
|
use :: iso_fortran_env
|
|
type(team_type) team_var
|
|
|
|
level0: do i = 1, 10
|
|
level1: change team(team_var)
|
|
!ERROR: CYCLE must not leave a CHANGE TEAM statement
|
|
cycle level0
|
|
end team level1
|
|
end do level0
|
|
end subroutine s8
|
|
|
|
subroutine s9()
|
|
use :: iso_fortran_env
|
|
type(team_type) team_var
|
|
|
|
level0: do i = 1, 10
|
|
level1: change team(team_var)
|
|
!ERROR: EXIT must not leave a CHANGE TEAM statement
|
|
exit level0
|
|
end team level1
|
|
end do level0
|
|
end subroutine s9
|
|
|
|
subroutine s10(table)
|
|
! A complex, but all legal example
|
|
|
|
integer :: table(..)
|
|
|
|
type point
|
|
real :: x, y
|
|
end type point
|
|
|
|
type, extends(point) :: color_point
|
|
integer :: color
|
|
end type color_point
|
|
|
|
type(point), target :: target_var
|
|
class(point), pointer :: p_or_c
|
|
|
|
p_or_c => target_var
|
|
level0: do i = 1, 10
|
|
level1: associate (avar => ivar)
|
|
level2: block
|
|
level3: select case (l)
|
|
case default
|
|
print*, "default"
|
|
case (1)
|
|
level4: if (.true.) then
|
|
level5: select rank(table)
|
|
rank default
|
|
level6: select type ( a => p_or_c )
|
|
type is ( point )
|
|
cycle level0
|
|
end select level6
|
|
end select level5
|
|
end if level4
|
|
end select level3
|
|
end block level2
|
|
end associate level1
|
|
end do level0
|
|
end subroutine s10
|
|
|
|
subroutine s11(table)
|
|
! A complex, but all legal example with a CYCLE statement
|
|
|
|
integer :: table(..)
|
|
|
|
type point
|
|
real :: x, y
|
|
end type point
|
|
|
|
type, extends(point) :: color_point
|
|
integer :: color
|
|
end type color_point
|
|
|
|
type(point), target :: target_var
|
|
class(point), pointer :: p_or_c
|
|
|
|
p_or_c => target_var
|
|
level0: do i = 1, 10
|
|
level1: associate (avar => ivar)
|
|
level2: block
|
|
level3: select case (l)
|
|
case default
|
|
print*, "default"
|
|
case (1)
|
|
level4: if (.true.) then
|
|
level5: select rank(table)
|
|
rank default
|
|
level6: select type ( a => p_or_c )
|
|
type is ( point )
|
|
cycle level0
|
|
end select level6
|
|
end select level5
|
|
end if level4
|
|
end select level3
|
|
end block level2
|
|
end associate level1
|
|
end do level0
|
|
end subroutine s11
|
|
|
|
subroutine s12(table)
|
|
! A complex, but all legal example with an EXIT statement
|
|
|
|
integer :: table(..)
|
|
|
|
type point
|
|
real :: x, y
|
|
end type point
|
|
|
|
type, extends(point) :: color_point
|
|
integer :: color
|
|
end type color_point
|
|
|
|
type(point), target :: target_var
|
|
class(point), pointer :: p_or_c
|
|
|
|
p_or_c => target_var
|
|
level0: do i = 1, 10
|
|
level1: associate (avar => ivar)
|
|
level2: block
|
|
level3: select case (l)
|
|
case default
|
|
print*, "default"
|
|
case (1)
|
|
level4: if (.true.) then
|
|
level5: select rank(table)
|
|
rank default
|
|
level6: select type ( a => p_or_c )
|
|
type is ( point )
|
|
exit level0
|
|
end select level6
|
|
end select level5
|
|
end if level4
|
|
end select level3
|
|
end block level2
|
|
end associate level1
|
|
end do level0
|
|
end subroutine s12
|
|
|
|
subroutine s13(table)
|
|
! Similar example without construct names
|
|
|
|
integer :: table(..)
|
|
|
|
type point
|
|
real :: x, y
|
|
end type point
|
|
|
|
type, extends(point) :: color_point
|
|
integer :: color
|
|
end type color_point
|
|
|
|
type(point), target :: target_var
|
|
class(point), pointer :: p_or_c
|
|
|
|
p_or_c => target_var
|
|
do i = 1, 10
|
|
associate (avar => ivar)
|
|
block
|
|
select case (l)
|
|
case default
|
|
print*, "default"
|
|
case (1)
|
|
if (.true.) then
|
|
select rank(table)
|
|
rank default
|
|
select type ( a => p_or_c )
|
|
type is ( point )
|
|
cycle
|
|
end select
|
|
end select
|
|
end if
|
|
end select
|
|
end block
|
|
end associate
|
|
end do
|
|
end subroutine s13
|
|
|
|
subroutine s14(table)
|
|
|
|
integer :: table(..)
|
|
|
|
type point
|
|
real :: x, y
|
|
end type point
|
|
|
|
type, extends(point) :: color_point
|
|
integer :: color
|
|
end type color_point
|
|
|
|
type(point), target :: target_var
|
|
class(point), pointer :: p_or_c
|
|
|
|
p_or_c => target_var
|
|
do i = 1, 10
|
|
associate (avar => ivar)
|
|
block
|
|
critical
|
|
select case (l)
|
|
case default
|
|
print*, "default"
|
|
case (1)
|
|
if (.true.) then
|
|
select rank(table)
|
|
rank default
|
|
select type ( a => p_or_c )
|
|
type is ( point )
|
|
!ERROR: CYCLE must not leave a CRITICAL statement
|
|
cycle
|
|
!ERROR: EXIT must not leave a CRITICAL statement
|
|
exit
|
|
end select
|
|
end select
|
|
end if
|
|
end select
|
|
end critical
|
|
end block
|
|
end associate
|
|
end do
|
|
end subroutine s14
|
|
|
|
subroutine s15(table)
|
|
! Illegal EXIT to an intermediated construct
|
|
|
|
integer :: table(..)
|
|
|
|
type point
|
|
real :: x, y
|
|
end type point
|
|
|
|
type, extends(point) :: color_point
|
|
integer :: color
|
|
end type color_point
|
|
|
|
type(point), target :: target_var
|
|
class(point), pointer :: p_or_c
|
|
|
|
p_or_c => target_var
|
|
level0: do i = 1, 10
|
|
level1: associate (avar => ivar)
|
|
level2: block
|
|
level3: select case (l)
|
|
case default
|
|
print*, "default"
|
|
case (1)
|
|
level4: if (.true.) then
|
|
level5: critical
|
|
level6: select rank(table)
|
|
rank default
|
|
level7: select type ( a => p_or_c )
|
|
type is ( point )
|
|
exit level6
|
|
!ERROR: EXIT must not leave a CRITICAL statement
|
|
exit level4
|
|
end select level7
|
|
end select level6
|
|
end critical level5
|
|
end if level4
|
|
end select level3
|
|
end block level2
|
|
end associate level1
|
|
end do level0
|
|
end subroutine s15
|