
Due to a mis-reading of the OpenACC spec, we weren't accepting arrays as a valid value to a reduction variable. This patch corrects that.
173 lines
5.6 KiB
C++
173 lines
5.6 KiB
C++
// RUN: %clang_cc1 %s -fopenacc -verify
|
|
|
|
struct CompositeOfScalars {
|
|
int I;
|
|
float F;
|
|
short J;
|
|
char C;
|
|
double D;
|
|
_Complex float CF;
|
|
_Complex double CD;
|
|
};
|
|
|
|
struct CompositeHasComposite {
|
|
int I;
|
|
float F;
|
|
short J;
|
|
char C;
|
|
double D;
|
|
_Complex float CF;
|
|
_Complex double CD;
|
|
struct CompositeOfScalars COS; // #COS_FIELD
|
|
};
|
|
|
|
void uses(unsigned Parm) {
|
|
float Var;
|
|
int IVar;
|
|
|
|
#pragma acc parallel reduction(+:Parm)
|
|
while (1);
|
|
#pragma acc serial reduction(+:Parm)
|
|
while (1);
|
|
// expected-error@+1{{OpenACC 'reduction' clause is not valid on 'kernels' directive}}
|
|
#pragma acc kernels reduction(+:Parm)
|
|
while (1);
|
|
|
|
// On a 'parallel', 'num_gangs' cannot have >1 args. num_gangs not valid on
|
|
// 'serial', but 'reduction' not valid on 'kernels', other combos cannot be
|
|
// tested.
|
|
#pragma acc parallel reduction(+:Parm) num_gangs(IVar)
|
|
while (1);
|
|
#pragma acc parallel num_gangs(IVar) reduction(+:Var)
|
|
while (1);
|
|
|
|
// expected-error@+2{{OpenACC 'num_gangs' clause with more than 1 argument may not appear on a 'parallel' construct with a 'reduction' clause}}
|
|
// expected-note@+1{{previous 'reduction' clause is here}}
|
|
#pragma acc parallel reduction(+:Parm) num_gangs(Parm, IVar)
|
|
while (1);
|
|
|
|
// expected-error@+2{{OpenACC 'reduction' clause may not appear on a 'parallel' construct with a 'num_gangs' clause with more than 1 argument}}
|
|
// expected-note@+1{{previous 'num_gangs' clause is here}}
|
|
#pragma acc parallel num_gangs(Parm, IVar) reduction(+:Var)
|
|
while (1);
|
|
|
|
#pragma acc parallel reduction(+:Parm) reduction(+:Parm)
|
|
while (1);
|
|
|
|
struct CompositeOfScalars CoS;
|
|
struct CompositeOfScalars *CoSPtr;
|
|
struct CompositeHasComposite ChC;
|
|
struct CompositeHasComposite *ChCPtr;
|
|
|
|
int I;
|
|
float F;
|
|
int Array[5];
|
|
|
|
// Vars in a reduction must be a scalar or a composite of scalars.
|
|
#pragma acc parallel reduction(&: CoS, I, F)
|
|
while (1);
|
|
// expected-error@+2{{OpenACC 'reduction' composite variable must not have non-scalar field}}
|
|
// expected-note@#COS_FIELD{{invalid field is here}}
|
|
#pragma acc parallel reduction(&: ChC)
|
|
while (1);
|
|
#pragma acc parallel reduction(&: Array)
|
|
while (1);
|
|
|
|
#pragma acc parallel reduction(&: CoS, Array[I], Array[0:I])
|
|
while (1);
|
|
|
|
// expected-error@+1{{OpenACC variable is not a valid variable name, sub-array, array element, or composite variable member}}
|
|
#pragma acc parallel reduction(&: CoS.I)
|
|
while (1);
|
|
|
|
// expected-error@+1{{OpenACC variable is not a valid variable name, sub-array, array element, or composite variable member}}
|
|
#pragma acc parallel reduction(&: CoSPtr->I)
|
|
|
|
while (1);
|
|
// expected-error@+1{{OpenACC variable is not a valid variable name, sub-array, array element, or composite variable member}}
|
|
#pragma acc parallel reduction(&: ChC.COS)
|
|
while (1);
|
|
|
|
// expected-error@+1{{OpenACC variable is not a valid variable name, sub-array, array element, or composite variable member}}
|
|
#pragma acc parallel reduction(&: ChCPtr->COS)
|
|
while (1);
|
|
}
|
|
|
|
template<typename T, typename U, typename V>
|
|
void TemplUses(T Parm, U CoS, V ChC) {
|
|
T Var;
|
|
U *CoSPtr;
|
|
V *ChCPtr;
|
|
|
|
#pragma acc parallel reduction(+:Parm)
|
|
while (1);
|
|
#pragma acc serial reduction(+:Parm)
|
|
while (1);
|
|
// expected-error@+1{{OpenACC 'reduction' clause is not valid on 'kernels' directive}}
|
|
#pragma acc kernels reduction(+:Parm)
|
|
while (1);
|
|
|
|
// On a 'parallel', 'num_gangs' cannot have >1 args. num_gangs not valid on
|
|
// 'serial', but 'reduction' not valid on 'kernels', other combos cannot be
|
|
// tested.
|
|
#pragma acc parallel reduction(+:Parm) num_gangs(Var)
|
|
while (1);
|
|
#pragma acc parallel num_gangs(Var) reduction(+:Var)
|
|
while (1);
|
|
|
|
// expected-error@+2{{OpenACC 'num_gangs' clause with more than 1 argument may not appear on a 'parallel' construct with a 'reduction' clause}}
|
|
// expected-note@+1{{previous 'reduction' clause is here}}
|
|
#pragma acc parallel reduction(+:Parm) num_gangs(Parm, Var)
|
|
while (1);
|
|
|
|
// expected-error@+2{{OpenACC 'reduction' clause may not appear on a 'parallel' construct with a 'num_gangs' clause with more than 1 argument}}
|
|
// expected-note@+1{{previous 'num_gangs' clause is here}}
|
|
#pragma acc parallel num_gangs(Parm, Var) reduction(+:Var)
|
|
while (1);
|
|
|
|
#pragma acc parallel reduction(+:Parm) reduction(+:Parm)
|
|
while (1);
|
|
|
|
int NonDep;
|
|
int NonDepArray[5];
|
|
T Array[5];
|
|
|
|
// Vars in a reduction must be a scalar or a composite of scalars.
|
|
#pragma acc parallel reduction(&: CoS, Var, Parm)
|
|
while (1);
|
|
// expected-error@+2{{OpenACC 'reduction' composite variable must not have non-scalar field}}
|
|
// expected-note@#COS_FIELD{{invalid field is here}}
|
|
#pragma acc parallel reduction(&: ChC)
|
|
while (1);
|
|
#pragma acc parallel reduction(&: Array)
|
|
while (1);
|
|
#pragma acc parallel reduction(&: NonDepArray)
|
|
while (1);
|
|
|
|
#pragma acc parallel reduction(&: CoS, Array[Var], Array[0:Var])
|
|
while (1);
|
|
|
|
// expected-error@+1{{OpenACC variable is not a valid variable name, sub-array, array element, or composite variable member}}
|
|
#pragma acc parallel reduction(&: CoS.I)
|
|
while (1);
|
|
|
|
// expected-error@+1{{OpenACC variable is not a valid variable name, sub-array, array element, or composite variable member}}
|
|
#pragma acc parallel reduction(&: CoSPtr->I)
|
|
|
|
while (1);
|
|
// expected-error@+1{{OpenACC variable is not a valid variable name, sub-array, array element, or composite variable member}}
|
|
#pragma acc parallel reduction(&: ChC.COS)
|
|
while (1);
|
|
|
|
// expected-error@+1{{OpenACC variable is not a valid variable name, sub-array, array element, or composite variable member}}
|
|
#pragma acc parallel reduction(&: ChCPtr->COS)
|
|
while (1);
|
|
}
|
|
|
|
void inst() {
|
|
CompositeOfScalars CoS;
|
|
CompositeHasComposite ChC;
|
|
// expected-note@+1{{in instantiation of function template specialization}}
|
|
TemplUses(5, CoS, ChC);
|
|
}
|