Louis Dionne f73050e722
[libc++] Fix several double-moves in the code base (#104616)
This patch hardens the "test iterators" we use to test algorithms by
ensuring that they don't get double-moved. As a result of this
hardening, the tests started reporting multiple failures where we would
double-move iterators, which are being fixed in this patch.

In particular:
- Fixed a double-move in pstl.partition
- Add coverage for begin()/end() in subrange tests
- Fix tests for ranges::ends_with and ranges::contains, which were
  incorrectly calling begin() twice on the same subrange containing
  non-copyable input iterators.

Fixes #100709
2024-08-20 14:36:11 -04:00

115 lines
3.4 KiB
C++

//===----------------------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
// <algorithm>
// template<BidirectionalIterator Iter, Predicate<auto, Iter::value_type> Pred>
// requires ShuffleIterator<Iter>
// && CopyConstructible<Pred>
// constexpr Iter // constexpr in C++20
// partition(Iter first, Iter last, Pred pred);
#include <algorithm>
#include <cassert>
#include "test_macros.h"
#include "test_iterators.h"
struct is_odd
{
TEST_CONSTEXPR bool operator()(const int& i) const {return i & 1;}
};
template <class Iter>
TEST_CONSTEXPR_CXX20 bool
test()
{
// check mixed
int ia[] = {1, 2, 3, 4, 5, 6, 7, 8 ,9};
const unsigned sa = sizeof(ia)/sizeof(ia[0]);
Iter r = std::partition(Iter(ia), Iter(ia + sa), is_odd());
assert(base(r) == ia + 5);
for (int* i = ia; i < base(r); ++i)
assert(is_odd()(*i));
for (int* i = base(r); i < ia+sa; ++i)
assert(!is_odd()(*i));
// check empty
r = std::partition(Iter(ia), Iter(ia), is_odd());
assert(base(r) == ia);
// check all false
for (unsigned i = 0; i < sa; ++i)
ia[i] = 2*i;
r = std::partition(Iter(ia), Iter(ia+sa), is_odd());
assert(base(r) == ia);
// check all true
for (unsigned i = 0; i < sa; ++i)
ia[i] = 2*i+1;
r = std::partition(Iter(ia), Iter(ia+sa), is_odd());
assert(base(r) == ia+sa);
// check all true but last
for (unsigned i = 0; i < sa; ++i)
ia[i] = 2*i+1;
ia[sa-1] = 10;
r = std::partition(Iter(ia), Iter(ia+sa), is_odd());
assert(base(r) == ia+sa-1);
for (int* i = ia; i < base(r); ++i)
assert(is_odd()(*i));
for (int* i = base(r); i < ia+sa; ++i)
assert(!is_odd()(*i));
// check all true but first
for (unsigned i = 0; i < sa; ++i)
ia[i] = 2*i+1;
ia[0] = 10;
r = std::partition(Iter(ia), Iter(ia+sa), is_odd());
assert(base(r) == ia+sa-1);
for (int* i = ia; i < base(r); ++i)
assert(is_odd()(*i));
for (int* i = base(r); i < ia+sa; ++i)
assert(!is_odd()(*i));
// check all false but last
for (unsigned i = 0; i < sa; ++i)
ia[i] = 2*i;
ia[sa-1] = 11;
r = std::partition(Iter(ia), Iter(ia+sa), is_odd());
assert(base(r) == ia+1);
for (int* i = ia; i < base(r); ++i)
assert(is_odd()(*i));
for (int* i = base(r); i < ia+sa; ++i)
assert(!is_odd()(*i));
// check all false but first
for (unsigned i = 0; i < sa; ++i)
ia[i] = 2*i;
ia[0] = 11;
r = std::partition(Iter(ia), Iter(ia+sa), is_odd());
assert(base(r) == ia+1);
for (int* i = ia; i < base(r); ++i)
assert(is_odd()(*i));
for (int* i = base(r); i < ia+sa; ++i)
assert(!is_odd()(*i));
return true;
}
int main(int, char**)
{
test<forward_iterator<int*> >();
test<bidirectional_iterator<int*> >();
test<random_access_iterator<int*> >();
test<int*>();
#if TEST_STD_VER >= 20
static_assert(test<forward_iterator<int*>>());
static_assert(test<bidirectional_iterator<int*>>());
static_assert(test<random_access_iterator<int*>>());
static_assert(test<int*>());
#endif
return 0;
}