
This is exactly as originally landed in #95129, but now the minimal Z3 version was increased to meet this change in #96682. https://discourse.llvm.org/t/bump-minimal-z3-requirements-from-4-7-1-to-4-8-9/79664/4 --- This patch is a functional change. https://discourse.llvm.org/t/analyzer-rfc-taming-z3-query-times/79520 As a result of this patch, individual Z3 queries in refutation will be bound by 300ms. Every report equivalence class will be processed in at most 1 second. The heuristic should have only really marginal observable impact - except for the cases when we had big report eqclasses with long-running (15s) Z3 queries, where previously CSA effectively halted. After this patch, CSA will tackle such extreme cases as well. (cherry picked from commit eacc3b3504be061f7334410dd0eb599688ba103a)
161 lines
6.0 KiB
C++
161 lines
6.0 KiB
C++
//===- Z3CrosscheckVisitor.cpp - Crosscheck reports with Z3 -----*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file declares the visitor and utilities around it for Z3 report
|
|
// refutation.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "clang/StaticAnalyzer/Core/BugReporter/Z3CrosscheckVisitor.h"
|
|
#include "clang/StaticAnalyzer/Core/AnalyzerOptions.h"
|
|
#include "clang/StaticAnalyzer/Core/BugReporter/BugReporter.h"
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/SMTConv.h"
|
|
#include "llvm/ADT/Statistic.h"
|
|
#include "llvm/Support/SMTAPI.h"
|
|
#include "llvm/Support/Timer.h"
|
|
|
|
#define DEBUG_TYPE "Z3CrosscheckOracle"
|
|
|
|
STATISTIC(NumZ3QueriesDone, "Number of Z3 queries done");
|
|
STATISTIC(NumTimesZ3TimedOut, "Number of times Z3 query timed out");
|
|
STATISTIC(NumTimesZ3ExhaustedRLimit,
|
|
"Number of times Z3 query exhausted the rlimit");
|
|
STATISTIC(NumTimesZ3SpendsTooMuchTimeOnASingleEQClass,
|
|
"Number of times report equivalenece class was cut because it spent "
|
|
"too much time in Z3");
|
|
|
|
STATISTIC(NumTimesZ3QueryAcceptsReport,
|
|
"Number of Z3 queries accepting a report");
|
|
STATISTIC(NumTimesZ3QueryRejectReport,
|
|
"Number of Z3 queries rejecting a report");
|
|
STATISTIC(NumTimesZ3QueryRejectEQClass,
|
|
"Number of times rejecting an report equivalenece class");
|
|
|
|
using namespace clang;
|
|
using namespace ento;
|
|
|
|
Z3CrosscheckVisitor::Z3CrosscheckVisitor(Z3CrosscheckVisitor::Z3Result &Result,
|
|
const AnalyzerOptions &Opts)
|
|
: Constraints(ConstraintMap::Factory().getEmptyMap()), Result(Result),
|
|
Opts(Opts) {}
|
|
|
|
void Z3CrosscheckVisitor::finalizeVisitor(BugReporterContext &BRC,
|
|
const ExplodedNode *EndPathNode,
|
|
PathSensitiveBugReport &BR) {
|
|
// Collect new constraints
|
|
addConstraints(EndPathNode, /*OverwriteConstraintsOnExistingSyms=*/true);
|
|
|
|
// Create a refutation manager
|
|
llvm::SMTSolverRef RefutationSolver = llvm::CreateZ3Solver();
|
|
if (Opts.Z3CrosscheckRLimitThreshold)
|
|
RefutationSolver->setUnsignedParam("rlimit",
|
|
Opts.Z3CrosscheckRLimitThreshold);
|
|
if (Opts.Z3CrosscheckTimeoutThreshold)
|
|
RefutationSolver->setUnsignedParam("timeout",
|
|
Opts.Z3CrosscheckTimeoutThreshold); // ms
|
|
|
|
ASTContext &Ctx = BRC.getASTContext();
|
|
|
|
// Add constraints to the solver
|
|
for (const auto &[Sym, Range] : Constraints) {
|
|
auto RangeIt = Range.begin();
|
|
|
|
llvm::SMTExprRef SMTConstraints = SMTConv::getRangeExpr(
|
|
RefutationSolver, Ctx, Sym, RangeIt->From(), RangeIt->To(),
|
|
/*InRange=*/true);
|
|
while ((++RangeIt) != Range.end()) {
|
|
SMTConstraints = RefutationSolver->mkOr(
|
|
SMTConstraints, SMTConv::getRangeExpr(RefutationSolver, Ctx, Sym,
|
|
RangeIt->From(), RangeIt->To(),
|
|
/*InRange=*/true));
|
|
}
|
|
RefutationSolver->addConstraint(SMTConstraints);
|
|
}
|
|
|
|
// And check for satisfiability
|
|
llvm::TimeRecord Start = llvm::TimeRecord::getCurrentTime(/*Start=*/true);
|
|
std::optional<bool> IsSAT = RefutationSolver->check();
|
|
llvm::TimeRecord Diff = llvm::TimeRecord::getCurrentTime(/*Start=*/false);
|
|
Diff -= Start;
|
|
Result = Z3Result{
|
|
IsSAT,
|
|
static_cast<unsigned>(Diff.getWallTime() * 1000),
|
|
RefutationSolver->getStatistics()->getUnsigned("rlimit count"),
|
|
};
|
|
}
|
|
|
|
void Z3CrosscheckVisitor::addConstraints(
|
|
const ExplodedNode *N, bool OverwriteConstraintsOnExistingSyms) {
|
|
// Collect new constraints
|
|
ConstraintMap NewCs = getConstraintMap(N->getState());
|
|
ConstraintMap::Factory &CF = N->getState()->get_context<ConstraintMap>();
|
|
|
|
// Add constraints if we don't have them yet
|
|
for (auto const &[Sym, Range] : NewCs) {
|
|
if (!Constraints.contains(Sym)) {
|
|
// This symbol is new, just add the constraint.
|
|
Constraints = CF.add(Constraints, Sym, Range);
|
|
} else if (OverwriteConstraintsOnExistingSyms) {
|
|
// Overwrite the associated constraint of the Symbol.
|
|
Constraints = CF.remove(Constraints, Sym);
|
|
Constraints = CF.add(Constraints, Sym, Range);
|
|
}
|
|
}
|
|
}
|
|
|
|
PathDiagnosticPieceRef
|
|
Z3CrosscheckVisitor::VisitNode(const ExplodedNode *N, BugReporterContext &,
|
|
PathSensitiveBugReport &) {
|
|
addConstraints(N, /*OverwriteConstraintsOnExistingSyms=*/false);
|
|
return nullptr;
|
|
}
|
|
|
|
void Z3CrosscheckVisitor::Profile(llvm::FoldingSetNodeID &ID) const {
|
|
static int Tag = 0;
|
|
ID.AddPointer(&Tag);
|
|
}
|
|
|
|
Z3CrosscheckOracle::Z3Decision Z3CrosscheckOracle::interpretQueryResult(
|
|
const Z3CrosscheckVisitor::Z3Result &Query) {
|
|
++NumZ3QueriesDone;
|
|
AccumulatedZ3QueryTimeInEqClass += Query.Z3QueryTimeMilliseconds;
|
|
|
|
if (Query.IsSAT && Query.IsSAT.value()) {
|
|
++NumTimesZ3QueryAcceptsReport;
|
|
return AcceptReport;
|
|
}
|
|
|
|
// Suggest cutting the EQClass if certain heuristics trigger.
|
|
if (Opts.Z3CrosscheckTimeoutThreshold &&
|
|
Query.Z3QueryTimeMilliseconds >= Opts.Z3CrosscheckTimeoutThreshold) {
|
|
++NumTimesZ3TimedOut;
|
|
++NumTimesZ3QueryRejectEQClass;
|
|
return RejectEQClass;
|
|
}
|
|
|
|
if (Opts.Z3CrosscheckRLimitThreshold &&
|
|
Query.UsedRLimit >= Opts.Z3CrosscheckRLimitThreshold) {
|
|
++NumTimesZ3ExhaustedRLimit;
|
|
++NumTimesZ3QueryRejectEQClass;
|
|
return RejectEQClass;
|
|
}
|
|
|
|
if (Opts.Z3CrosscheckEQClassTimeoutThreshold &&
|
|
AccumulatedZ3QueryTimeInEqClass >
|
|
Opts.Z3CrosscheckEQClassTimeoutThreshold) {
|
|
++NumTimesZ3SpendsTooMuchTimeOnASingleEQClass;
|
|
++NumTimesZ3QueryRejectEQClass;
|
|
return RejectEQClass;
|
|
}
|
|
|
|
// If no cutoff heuristics trigger, and the report is "unsat" or "undef",
|
|
// then reject the report.
|
|
++NumTimesZ3QueryRejectReport;
|
|
return RejectReport;
|
|
}
|