
1. The generated file contained a lot of duplicate switch cases, e.g.: ``` switch (Syntax) { case AttributeCommonInfo::Syntax::AS_GNU: return llvm::StringSwitch<int>(Name) ... .Case("error", 1) .Case("warning", 1) .Case("error", 1) .Case("warning", 1) ``` 2. Some attributes were listed in wrong places, e.g.: ``` case AttributeCommonInfo::Syntax::AS_CXX11: { if (ScopeName == "") { return llvm::StringSwitch<int>(Name) ... .Case("warn_unused_result", LangOpts.CPlusPlus11 ? 201907 : 0) ``` `warn_unused_result` is a non-standard attribute and should not be available as [[warn_unused_result]]. 3. Some attributes had the wrong version, e.g.: ``` case AttributeCommonInfo::Syntax::AS_CXX11: { } else if (ScopeName == "gnu") { return llvm::StringSwitch<int>(Name) ... .Case("fallthrough", LangOpts.CPlusPlus11 ? 201603 : 0) ``` [[gnu::fallthrough]] is a non-standard spelling and should not have the standard version. Instead, __has_cpp_attribute should return 1 for it. There is another issue with attributes that share spellings, e.g.: ``` .Case("interrupt", true && (T.getArch() == llvm::Triple::arm || ...) ? 1 : 0) .Case("interrupt", true && (T.getArch() == llvm::Triple::avr) ? 1 : 0) ... .Case("interrupt", true && (T.getArch() == llvm::Triple::riscv32 || ...) ? 1 : 0) ``` As can be seen, __has_attribute(interrupt) would only return true for ARM targets. This patch does not address this issue. Differential Revision: https://reviews.llvm.org/D159393
71 lines
1.5 KiB
C
71 lines
1.5 KiB
C
// RUN: %clang_cc1 -triple arm-unknown-linux -verify -E %s -o - | FileCheck %s
|
|
|
|
// CHECK: always_inline
|
|
#if __has_attribute(always_inline)
|
|
int always_inline();
|
|
#endif
|
|
|
|
// CHECK: __always_inline__
|
|
#if __has_attribute(__always_inline__)
|
|
int __always_inline__();
|
|
#endif
|
|
|
|
// CHECK: warn_unused_result
|
|
#if __has_attribute(warn_unused_result)
|
|
int warn_unused_result();
|
|
#endif
|
|
|
|
// CHECK: no_dummy_attribute
|
|
#if !__has_attribute(dummy_attribute)
|
|
int no_dummy_attribute();
|
|
#endif
|
|
|
|
// CHECK: has_has_attribute
|
|
#ifdef __has_attribute
|
|
int has_has_attribute();
|
|
#endif
|
|
|
|
// CHECK: has_something_we_dont_have
|
|
#if !__has_attribute(something_we_dont_have)
|
|
int has_something_we_dont_have();
|
|
#endif
|
|
|
|
#if __has_attribute(__const)
|
|
int fn3() __attribute__ ((__const));
|
|
#endif
|
|
|
|
#if __has_attribute(const)
|
|
static int constFunction() __attribute__((const));
|
|
#endif
|
|
|
|
// CHECK: has_no_volatile_attribute
|
|
#if !__has_attribute(volatile)
|
|
int has_no_volatile_attribute();
|
|
#endif
|
|
|
|
// CHECK: has_arm_interrupt
|
|
#if __has_attribute(interrupt)
|
|
int has_arm_interrupt();
|
|
#endif
|
|
|
|
// CHECK: does_not_have_dllexport
|
|
#if !__has_attribute(dllexport)
|
|
int does_not_have_dllexport();
|
|
#endif
|
|
|
|
// CHECK: does_not_have_uuid
|
|
#if !__has_attribute(uuid)
|
|
int does_not_have_uuid
|
|
#endif
|
|
|
|
#if __has_cpp_attribute(selectany) // expected-error {{function-like macro '__has_cpp_attribute' is not defined}}
|
|
#endif
|
|
|
|
// Test that macro expansion of the builtin argument works.
|
|
#define F fallthrough
|
|
|
|
#if __has_attribute(F)
|
|
int has_fallthrough;
|
|
#endif
|
|
// CHECK: int has_fallthrough;
|