9f5efd5d03
Resolves #174350 - Several issues were found in the current implementation of `optional<T&>` - `value()`, `operator*()`, `and_then()`, `transform()`, `operator->()` still provided their ref-qualified versions for rvalues and `const&`. - Using the listed methods on an rvalue `optional<T&>` would cause a compile failure due to a mismatch in return types. - On the latter, `operator*`, `operator->` would return `const` for a `optional<T&>`, which is an incorrect deep const. - A few constructors were missing (`optional<U>&`), and most constructors relevant to `optional<T&>` were missing `noexcept` - Constructors and `emplace` were not correctly constructing a `T&` as specified in _`convert-ref-init-val`_ - Also corrects the behavior of `value_or` which should return `remove_cv_t<T>` (in our case `decay_t<_Tp>`) - Add several test cases to verify behavior, update `value_or` tests
69 lines
1.5 KiB
C++
69 lines
1.5 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// UNSUPPORTED: c++03, c++11, c++14
|
|
// <optional>
|
|
|
|
// constexpr explicit optional<T>::operator bool() const noexcept;
|
|
// constexpr explicit optional<T&>::operator bool() const noexcept;
|
|
|
|
#include <cassert>
|
|
#include <optional>
|
|
#include <type_traits>
|
|
|
|
#include "test_macros.h"
|
|
|
|
#if TEST_STD_VER >= 26
|
|
|
|
constexpr bool test_ref() {
|
|
{
|
|
std::optional<int&> opt;
|
|
ASSERT_NOEXCEPT(bool(opt));
|
|
assert(!opt);
|
|
static_assert(!std::is_convertible<std::optional<int&>, bool>::value, "");
|
|
}
|
|
{
|
|
int i = 1;
|
|
std::optional<int&> opt(i);
|
|
ASSERT_NOEXCEPT(bool(opt));
|
|
assert(opt);
|
|
static_assert(!std::is_convertible<std::optional<int&>, bool>::value, "");
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
#endif
|
|
|
|
int main(int, char**)
|
|
{
|
|
using std::optional;
|
|
{
|
|
const optional<int> opt; ((void)opt);
|
|
ASSERT_NOEXCEPT(bool(opt));
|
|
static_assert(!std::is_convertible<optional<int>, bool>::value, "");
|
|
}
|
|
{
|
|
constexpr optional<int> opt;
|
|
static_assert(!opt, "");
|
|
}
|
|
{
|
|
constexpr optional<int> opt(0);
|
|
static_assert(opt, "");
|
|
}
|
|
|
|
#if TEST_STD_VER >= 26
|
|
{
|
|
assert(test_ref());
|
|
static_assert(test_ref());
|
|
}
|
|
#endif
|
|
|
|
return 0;
|
|
}
|