0e0b501bf5
This is more straight forward refactor of the startup sequence that reverts parts of ba29e60f9a2222bd5e883579bb78db13fc5a7588. Unlike my previous attempt, I ended up removing the pending request queue and not including an `AsyncReqeustHandler` because I don't think we actually need that at the moment. The key is that during the startup flow there are 2 parallel operations happening in the DAP that have different triggers. * The `initialize` request is sent and once the response is received the `launch` or `attach` is sent. * When the `initialized` event is recieved the `setBreakpionts` and other config requests are made followed by the `configurationDone` event. I moved the `initialized` event back to happen in the `PostRun` of the `launch` or `attach` request handlers. This ensures that we have a valid target by the time the configuration calls are made. I added also added a few extra validations that to the `configurationeDone` handler to ensure we're in an expected state. I've also fixed up the tests to match the new flow. With the other additional test fixes in 087a5d2ec7897cd99d3787820711fec76a8e1792 I think we've narrowed down the main source of test instability that motivated the startup sequence change.
27 lines
987 B
Python
27 lines
987 B
Python
"""
|
|
Test stop hooks
|
|
"""
|
|
|
|
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.lldbtest import *
|
|
import lldbdap_testcase
|
|
|
|
|
|
class TestDAP_stop_hooks(lldbdap_testcase.DAPTestCaseBase):
|
|
def test_stop_hooks_before_run(self):
|
|
"""
|
|
Test that there is no race condition between lldb-dap and
|
|
stop hooks executor
|
|
"""
|
|
program = self.getBuildArtifact("a.out")
|
|
preRunCommands = ["target stop-hook add -o help"]
|
|
self.build_and_launch(program, preRunCommands=preRunCommands)
|
|
breakpoint_ids = self.set_function_breakpoints(["main"])
|
|
# This request hangs if the race happens, because, in that case, the
|
|
# command interpreter is in synchronous mode while lldb-dap expects
|
|
# it to be in asynchronous mode, so, the process doesn't send the stop
|
|
# event to "lldb.Debugger" listener (which is monitored by lldb-dap).
|
|
self.continue_to_breakpoints(breakpoint_ids)
|
|
|
|
self.continue_to_exit()
|