Florian Hahn daf0182277

[ConstraintElim] Apply add with neg constant first during decomp. (#164791) ...

We have dedicated decomposition logic for (add %x, -C), but if we have
(add nsw %x, -C) we will first apply the generic logic for NSWAdd, which
gives worse results for negative constants in practice.

Update the code to first apply the pattern with negative constants.

Helps to remove a number of runtime checks in practice:
https://github.com/dtcxzyw/llvm-opt-benchmark/pull/2968

Alive2 proofs for the test changes: https://alive2.llvm.org/ce/z/JfR2Ma

PR: https://github.com/llvm/llvm-project/pull/164791

2025-10-23 12:50:12 +01:00

..

abs.ll

[ConstraintElim] Fix poison check before adding intrinsic facts (#136291)

2025-04-30 21:46:07 +08:00

add-nsw.ll

[ConstraintElim] Apply add with neg constant first during decomp. (#164791)

2025-10-23 12:50:12 +01:00

add-nuw.ll

[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)

2023-12-23 15:53:48 +01:00

add.ll

…

analysis-invalidation.ll

[ConstraintElim] Preserve analyses when IR is unchanged. (#128588)

2025-02-25 14:22:55 +01:00

and-implied-by-operands.ll

[ConstraintElim] Simplify and/or instead of replacing its operand (#139874)

2025-05-14 23:37:41 +08:00

and.ll

…

assumes.ll

…

cond-used-in-phi.ll

…

constants-signed-predicates.ll

…

constants-unsigned-predicates.ll

…

constraint-overflow.ll

[ConstraintElim] Do not allow overflows in Decomposition (#140541)

2025-05-22 11:31:04 +08:00

debug.ll

…

decompose-with-temporary-indices.ll

…

dom.ll

…

empty-constraint.ll

…

eq.ll

[ConstraintElim] Simplify and/or instead of replacing its operand (#139874)

2025-05-14 23:37:41 +08:00

gep-add-multiple-indices-signed-predicates.ll

…

gep-add-multiple-indices.ll

…

gep-arithmetic-add-signed-predicates.ll

…

gep-arithmetic-add.ll

[ConstraintElim] Apply add with neg constant first during decomp. (#164791)

2025-10-23 12:50:12 +01:00

gep-arithmetic-different-types.ll

…

gep-arithmetic-signed-predicates.ll

[ConstraintElim] Simplify and/or instead of replacing its operand (#139874)

2025-05-14 23:37:41 +08:00

gep-arithmetic.ll

[ConstraintElim] Add support for decomposing gep nuw (#118639)

2024-12-04 16:27:31 +01:00

gep-chains.ll

…

gep-constexpr.ll

…

gep-sub-signed-predicates.ll

…

gep-sub.ll

…

geps-128-bit-pointers.ll

…

geps-i32-pointer-indexes.ll

…

geps-inbounds-precondition-ub-in-use-blocks.ll

…

geps-inbounds-precondition.ll

…

geps-pointers-to-arrays.ll

…

geps-pointers-to-structs.ll

[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)

2023-12-23 15:53:48 +01:00

geps-precondition-overflow-check.ll

[ConstraintElim] Simplify and/or instead of replacing its operand (#139874)

2025-05-14 23:37:41 +08:00

geps-ptrvector.ll

[LLVM][IR] Use splat syntax when printing ConstantExpr based splats. (#116856)

2024-11-21 11:21:12 +00:00

geps-signed-predicates.ll

…

geps-unsigned-predicates.ll

…

implied-by-bounded-memory-access.ll

[ConstraintElim] Bail out on non-canonical GEPs (#156688)

2025-09-03 15:42:52 +00:00

induction-condition-in-loop-exit.ll

[ConstraintElim] Bail out on non-dedicated exits when adding exiting conditions (#116627)

2024-11-18 23:41:04 +08:00

invoke.ll

…

large-constant-ints.ll

[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)

2023-12-23 15:53:48 +01:00

large-system-growth.ll

…

loops-bottom-tested-base.ll

…

loops-bottom-tested-pointer-cmps.ll

[ConstraintElim] Simplify and/or instead of replacing its operand (#139874)

2025-05-14 23:37:41 +08:00

loops-header-tested-base.ll

[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)

2023-12-23 15:53:48 +01:00

loops-header-tested-pointer-cmps.ll

[ConstraintElim] Simplify and/or instead of replacing its operand (#139874)

2025-05-14 23:37:41 +08:00

loops-header-tested-pointer-iv.ll

…

loops.ll

…

max-row-limit.ll

[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)

2023-12-23 15:53:48 +01:00

minmax.ll

[ConstraintElim] Decompose sext-like insts for signed predicates (#82344)

2024-02-23 01:16:39 +08:00

mixed-signed-unsigned-predicates.ll

…

mixed.ll

…

monotonic-int-phis-cfg.ll

…

monotonic-int-phis-decrement.ll

…

monotonic-int-phis-multiples.ll

[ConstraintElim] Use SCEV to check for multiples (#76925)

2024-01-04 14:04:15 +01:00

monotonic-int-phis-nested-loops.ll

…

monotonic-int-phis-signed.ll

[ConstraintElim] Support signed induction variables (#77103)

2024-01-08 10:00:23 +01:00

monotonic-int-phis-wrapping.ll

…

monotonic-int-phis.ll

…

monotonic-phis-adjacent-loops.ll

…

monotonic-pointer-phis-chain-of-exits.ll

[ConstraintElim] Add tests with exiting latch.

2024-09-10 14:45:49 +01:00

monotonic-pointer-phis-constant-upper-offset.ll

…

monotonic-pointer-phis-crashes.ll

…

monotonic-pointer-phis-custom-datalayout.ll

…

monotonic-pointer-phis-early-exits.ll

…

monotonic-pointer-phis-struct-types.ll

…

monotonic-pointer-phis.ll

…

mul-nsw.ll

…

mul.ll

[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)

2023-12-23 15:53:48 +01:00

ne.ll

[ConstraintElimination] Add eq/ne facts to signed constraint system (#121423)

2025-01-23 11:00:31 +01:00

or-implied-by-operands.ll

[ConstraintElim] Simplify and/or instead of replacing its operand (#139874)

2025-05-14 23:37:41 +08:00

or.ll

[ConstraintElim] Simplify and/or instead of replacing its operand (#139874)

2025-05-14 23:37:41 +08:00

overflows.ll

…

pointercast.ll

…

pr54228-variable-name-order.ll

…

pr70510.ll

…

pr105785.ll

[ConstraintElimination] Add eq/ne facts to signed constraint system (#121423)

2025-01-23 11:00:31 +01:00

range_checks.ll

…

reason-about-add-operands.ll

[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)

2023-12-23 15:53:48 +01:00

reproducer-remarks-debug.ll

[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)

2023-12-23 15:53:48 +01:00

reproducer-remarks.ll

[Transforms] Convert tests to opaque pointers (NFC)

2024-02-05 11:57:34 +01:00

salvage-dbg-values-replaced-by-constant-2.ll

[DebugInfo][ConstraintElimination] Fix debug value loss in replacing comparisons with the speculated constants (#136839)

2025-05-05 21:08:58 +08:00

salvage-dbg-values-replaced-by-constant.ll

[DebugInfo][ConstraintElimination] Fix debug value loss in replacing comparisons with the speculated constants (#136839)

2025-05-05 21:08:58 +08:00

sext-signed-predicates.ll

[ConstraintElim] Add additional sext tests with unsigned predicates.

2024-02-27 09:25:23 +00:00

sext-unsigned-predicates.ll

[ConstraintElim] Look through SExt with precond Op sge 0.

2024-05-22 13:11:04 +01:00

sge.ll

…

shl.ll

[ConstraintElim] Decompose shl nsw for signed predicates (#76961)

2024-01-05 09:53:05 +01:00

signed-query-unsigned-system.ll

…

ssub-with-overflow.ll

…

sub-nsw.ll

[ConstraintElim] Decompose sub nsw (#118219)

2024-12-16 16:41:04 +08:00

sub-nuw.ll

[ConstraintElim] Replace NUWSub decomp with recursive decomp of ops.

2024-01-02 22:05:57 +00:00

sub.ll

…

switch.ll

…

transfer-samesign-facts.ll

[ConstraintElim] Teach checkAndReplaceCondition about samesign (#128168)

2025-02-24 13:07:47 +00:00

transfer-signed-facts-to-unsigned-is-known-non-negative.ll

…

transfer-signed-facts-to-unsigned.ll

[ConstraintElim] Look through SExt with precond Op sge 0.

2024-05-22 13:11:04 +01:00

transfer-unsigned-facts-to-signed-is-known-non-negative.ll

…

transfer-unsigned-facts-to-signed.ll

…

trunc.ll

[ConstraintElim] Add support for trunc nsw/nuw (#118745)

2024-12-06 23:15:31 +08:00

uadd-usub-sat.ll

Recommit "[ConstraintElim] Simplify cmp after uadd.sat/usub.sat (#135603)" (#136467)

2025-04-30 21:49:18 +08:00

uge.ll

…

ugt-ule.ll

…

ule.ll

…

umin-result-may-be-poison.ll

[ConstraintElim] Make sure min/max intrinsic results are not poison.

2024-01-24 14:25:55 +00:00

uscmp.ll

[ConstraintElimination] Add support for UCMP/SCMP intrinsics (#97974)

2024-07-10 21:59:59 +02:00

uses-in-different-blocks.ll

…

usub-with-overflow.ll

…

vector-compares.ll

[LLVM][IR] Use splat syntax when printing Constant[Data]Vector. (#112548)

2024-11-06 11:53:33 +00:00

wrapping-math.ll

…

zext-for-per-formula-reasoning.ll

[ConstraintElim] Use default depth for most calls of isNonNegative.

2024-02-28 13:14:40 +00:00

zext.ll

…