Nikita Popov 9ca2c309ab [InstSimplify] Fix poison safety in insertvalue fold
We can only fold insertvalue undef, (extractvalue x, n) to x
if x is not poison, otherwise we might be replacing undef with
poison (https://alive2.llvm.org/ce/z/fnw3c8). The insertvalue
poison case is always fine.

I didn't go to particularly large effort to preserve cases where
folding with undef is still legal (mainly when there is a chain of
multiple inserts that end up covering the whole aggregate),
because this shouldn't really occur in practice: We should always
be generating the insertvalue poison form when constructing
aggregates nowadays.

Differential Revision: https://reviews.llvm.org/D144106
2023-02-16 09:39:44 +01:00

57 lines
1.7 KiB
LLVM

; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -passes=instsimplify -S | FileCheck %s
define {i32, i32} @insert_poison({i32, i32} %x) {
; CHECK-LABEL: @insert_poison(
; CHECK-NEXT: ret { i32, i32 } [[X:%.*]]
;
%v = insertvalue {i32, i32} %x, i32 poison, 0
ret {i32, i32} %v
}
define {i32, i32} @insert_undef({i32, i32} %x) {
; CHECK-LABEL: @insert_undef(
; CHECK-NEXT: [[V:%.*]] = insertvalue { i32, i32 } [[X:%.*]], i32 undef, 0
; CHECK-NEXT: ret { i32, i32 } [[V]]
;
%v = insertvalue {i32, i32} %x, i32 undef, 0
ret {i32, i32} %v
}
define {i32, i32} @insert_undef_into_non_poison({i32, i32} noundef %x) {
; CHECK-LABEL: @insert_undef_into_non_poison(
; CHECK-NEXT: ret { i32, i32 } [[X:%.*]]
;
%v = insertvalue {i32, i32} %x, i32 undef, 0
ret {i32, i32} %v
}
define {i32, i32} @insert_into_poison({i32, i32} %x) {
; CHECK-LABEL: @insert_into_poison(
; CHECK-NEXT: ret { i32, i32 } [[X:%.*]]
;
%elem = extractvalue {i32, i32} %x, 0
%v = insertvalue {i32, i32} poison, i32 %elem, 0
ret {i32, i32} %v
}
define {i32, i32} @insert_into_undef({i32, i32} %x) {
; CHECK-LABEL: @insert_into_undef(
; CHECK-NEXT: [[ELEM:%.*]] = extractvalue { i32, i32 } [[X:%.*]], 0
; CHECK-NEXT: [[V:%.*]] = insertvalue { i32, i32 } undef, i32 [[ELEM]], 0
; CHECK-NEXT: ret { i32, i32 } [[V]]
;
%elem = extractvalue {i32, i32} %x, 0
%v = insertvalue {i32, i32} undef, i32 %elem, 0
ret {i32, i32} %v
}
define {i32, i32} @insert_non_poison_into_undef({i32, i32} noundef %x) {
; CHECK-LABEL: @insert_non_poison_into_undef(
; CHECK-NEXT: ret { i32, i32 } [[X:%.*]]
;
%elem = extractvalue {i32, i32} %x, 0
%v = insertvalue {i32, i32} undef, i32 %elem, 0
ret {i32, i32} %v
}