54c2687292
At the moment nearly every test calls something similar to
`self.dbg.CreateTarget(self.getBuildArtifact("a.out"))` and them sometimes
checks if the created target is actually valid with something like
`self.assertTrue(target.IsValid(), "some useless text")`.
Beside being really verbose the error messages generated by this pattern are
always just indicating that the target failed to be created but now why.
This patch introduces a helper function `createTestTarget` to our Test class
that creates the target with the much more verbose `CreateTarget` overload that
gives us back an SBError (with a fancy error). If the target couldn't be created
the function prints out the SBError that LLDB returned and asserts for us. It
also defaults to the "a.out" build artifact path that nearly all tests are using
to avoid to hardcode "a.out" in every test.
I converted a bunch of tests to the new function but I'll do the rest of the
test suite as follow ups.
Reviewed By: JDevlieghere
Differential Revision: https://reviews.llvm.org/D102771
117 lines
4.8 KiB
Python
117 lines
4.8 KiB
Python
"""Test stepping over watchpoints."""
|
|
|
|
|
|
|
|
import lldb
|
|
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test import lldbutil
|
|
|
|
|
|
class TestStepOverWatchpoint(TestBase):
|
|
|
|
mydir = TestBase.compute_mydir(__file__)
|
|
NO_DEBUG_INFO_TESTCASE = True
|
|
|
|
@expectedFailureAll(
|
|
oslist=["freebsd", "linux"],
|
|
archs=[
|
|
'aarch64',
|
|
'arm'],
|
|
bugnumber="llvm.org/pr26031")
|
|
# Read-write watchpoints not supported on SystemZ
|
|
@expectedFailureAll(archs=['s390x'])
|
|
@expectedFailureAll(oslist=["ios", "watchos", "tvos", "bridgeos"], bugnumber="<rdar://problem/34027183>") # watchpoint tests aren't working on arm64
|
|
@add_test_categories(["basic_process"])
|
|
def test(self):
|
|
"""Test stepping over watchpoints."""
|
|
self.build()
|
|
target = self.createTestTarget()
|
|
|
|
lldbutil.run_break_set_by_symbol(self, 'main')
|
|
|
|
process = target.LaunchSimple(None, None,
|
|
self.get_process_working_directory())
|
|
self.assertTrue(process.IsValid(), PROCESS_IS_VALID)
|
|
self.assertEquals(process.GetState(), lldb.eStateStopped,
|
|
PROCESS_STOPPED)
|
|
|
|
thread = lldbutil.get_stopped_thread(process,
|
|
lldb.eStopReasonBreakpoint)
|
|
self.assertTrue(thread.IsValid(), "Failed to get thread.")
|
|
|
|
frame = thread.GetFrameAtIndex(0)
|
|
self.assertTrue(frame.IsValid(), "Failed to get frame.")
|
|
|
|
read_value = frame.FindValue('g_watch_me_read',
|
|
lldb.eValueTypeVariableGlobal)
|
|
self.assertTrue(read_value.IsValid(), "Failed to find read value.")
|
|
|
|
error = lldb.SBError()
|
|
|
|
# resolve_location=True, read=True, write=False
|
|
read_watchpoint = read_value.Watch(True, True, False, error)
|
|
self.assertTrue(error.Success(),
|
|
"Error while setting watchpoint: %s" %
|
|
error.GetCString())
|
|
self.assertTrue(read_watchpoint, "Failed to set read watchpoint.")
|
|
|
|
thread.StepOver()
|
|
self.assertEquals(thread.GetStopReason(), lldb.eStopReasonWatchpoint,
|
|
STOPPED_DUE_TO_WATCHPOINT)
|
|
self.assertEquals(thread.GetStopDescription(20), 'watchpoint 1')
|
|
|
|
process.Continue()
|
|
self.assertEquals(process.GetState(), lldb.eStateStopped,
|
|
PROCESS_STOPPED)
|
|
self.assertEquals(thread.GetStopDescription(20), 'step over')
|
|
|
|
self.step_inst_for_watchpoint(1)
|
|
|
|
write_value = frame.FindValue('g_watch_me_write',
|
|
lldb.eValueTypeVariableGlobal)
|
|
self.assertTrue(write_value, "Failed to find write value.")
|
|
|
|
# Most of the MIPS boards provide only one H/W watchpoints, and S/W
|
|
# watchpoints are not supported yet
|
|
arch = self.getArchitecture()
|
|
if re.match("^mips", arch) or re.match("powerpc64le", arch):
|
|
self.runCmd("watchpoint delete 1")
|
|
|
|
# resolve_location=True, read=False, write=True
|
|
write_watchpoint = write_value.Watch(True, False, True, error)
|
|
self.assertTrue(write_watchpoint, "Failed to set write watchpoint.")
|
|
self.assertTrue(error.Success(),
|
|
"Error while setting watchpoint: %s" %
|
|
error.GetCString())
|
|
|
|
thread.StepOver()
|
|
self.assertEquals(thread.GetStopReason(), lldb.eStopReasonWatchpoint,
|
|
STOPPED_DUE_TO_WATCHPOINT)
|
|
self.assertEquals(thread.GetStopDescription(20), 'watchpoint 2')
|
|
|
|
process.Continue()
|
|
self.assertEquals(process.GetState(), lldb.eStateStopped,
|
|
PROCESS_STOPPED)
|
|
self.assertEquals(thread.GetStopDescription(20), 'step over')
|
|
|
|
self.step_inst_for_watchpoint(2)
|
|
|
|
def step_inst_for_watchpoint(self, wp_id):
|
|
watchpoint_hit = False
|
|
current_line = self.frame().GetLineEntry().GetLine()
|
|
while self.frame().GetLineEntry().GetLine() == current_line:
|
|
self.thread().StepInstruction(False) # step_over=False
|
|
stop_reason = self.thread().GetStopReason()
|
|
if stop_reason == lldb.eStopReasonWatchpoint:
|
|
self.assertFalse(watchpoint_hit, "Watchpoint already hit.")
|
|
expected_stop_desc = "watchpoint %d" % wp_id
|
|
actual_stop_desc = self.thread().GetStopDescription(20)
|
|
self.assertEquals(actual_stop_desc, expected_stop_desc,
|
|
"Watchpoint ID didn't match.")
|
|
watchpoint_hit = True
|
|
else:
|
|
self.assertEquals(stop_reason, lldb.eStopReasonPlanComplete,
|
|
STOPPED_DUE_TO_STEP_IN)
|
|
self.assertTrue(watchpoint_hit, "Watchpoint never hit.")
|