74e8f29f31
`weightCalcHelper` is responsible for adding hints to MRI. Prior to this PR, we fell back on register ID as the last tie breaker for sorting hints. However, there is an opportunity to add an additional sorting characteristic: whether or not a register is a callee-saved-register. I thought of this idea because I saw that `AllocationOrder::create` calls `RegisterClassInfo::getOrder`, which returns a list of registers such that the registers which alias callee-saved-registers come last. From this, I conclude that the register allocator prefers an order such that callee-saved-registers are allocated after non-callee-saved-registers to avoid having to spill the CSR. This sorting characteristic occurs only as a tie breaker to the Weight calculation. This is a good idea since the weight calculation is pretty complex and I'm sure it is a pretty stable metric. I think its pretty reasonable to agree that whether a register is callee-saved or not is a better tie breaker than register ID. I think this is evident by the test diff, since the changes all seem to have no impact or improve the register allocation.
54 lines
1.6 KiB
LLVM
54 lines
1.6 KiB
LLVM
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
|
|
; RUN: llc < %s -mtriple=x86_64-linux -mattr=+mwaitx | FileCheck %s
|
|
; RUN: llc < %s -mtriple=x86_64-win32 -mattr=+mwaitx | FileCheck %s -check-prefix=WIN64
|
|
; RUN: llc < %s -mtriple=x86_64-linux -mcpu=bdver4 | FileCheck %s
|
|
; RUN: llc < %s -mtriple=x86_64-win32 -mcpu=bdver4 | FileCheck %s -check-prefix=WIN64
|
|
|
|
define void @foo(ptr %P, i32 %E, i32 %H) nounwind {
|
|
; CHECK-LABEL: foo:
|
|
; CHECK: # %bb.0: # %entry
|
|
; CHECK-NEXT: movl %esi, %ecx
|
|
; CHECK-NEXT: movq %rdi, %rax
|
|
; CHECK-NEXT: monitorx
|
|
; CHECK-NEXT: retq
|
|
;
|
|
; WIN64-LABEL: foo:
|
|
; WIN64: # %bb.0: # %entry
|
|
; WIN64-NEXT: movq %rcx, %rax
|
|
; WIN64-NEXT: movl %edx, %ecx
|
|
; WIN64-NEXT: movl %r8d, %edx
|
|
; WIN64-NEXT: monitorx
|
|
; WIN64-NEXT: retq
|
|
entry:
|
|
tail call void @llvm.x86.monitorx(ptr %P, i32 %E, i32 %H)
|
|
ret void
|
|
}
|
|
|
|
declare void @llvm.x86.monitorx(ptr, i32, i32) nounwind
|
|
|
|
define void @bar(i32 %E, i32 %H, i32 %C) nounwind {
|
|
; CHECK-LABEL: bar:
|
|
; CHECK: # %bb.0: # %entry
|
|
; CHECK-NEXT: pushq %rbx
|
|
; CHECK-NEXT: movl %esi, %eax
|
|
; CHECK-NEXT: movl %edi, %ecx
|
|
; CHECK-NEXT: movl %edx, %ebx
|
|
; CHECK-NEXT: mwaitx
|
|
; CHECK-NEXT: popq %rbx
|
|
; CHECK-NEXT: retq
|
|
;
|
|
; WIN64-LABEL: bar:
|
|
; WIN64: # %bb.0: # %entry
|
|
; WIN64-NEXT: pushq %rbx
|
|
; WIN64-NEXT: movl %edx, %eax
|
|
; WIN64-NEXT: movl %r8d, %ebx
|
|
; WIN64-NEXT: mwaitx
|
|
; WIN64-NEXT: popq %rbx
|
|
; WIN64-NEXT: retq
|
|
entry:
|
|
tail call void @llvm.x86.mwaitx(i32 %E, i32 %H, i32 %C)
|
|
ret void
|
|
}
|
|
|
|
declare void @llvm.x86.mwaitx(i32, i32, i32) nounwind
|