Summary: Fixes PR41828. Before this, LLD always emitted SafeSEH chunks and defined __safe_se_handler_table & size. Now, /safeseh:no leaves those undefined. Additionally, we were checking for the safeseh @feat.00 flag in two places: once to emit errors, and once during safeseh table construction. The error was set up to be off by default, but safeseh is supposed to be on by default. I combined the two checks, so now LLD emits an error if an input object lacks @feat.00 and safeseh is enabled. This caused the majority of 32-bit LLD tests to fail, since many test input object files lack @feat.00 symbols. I explicitly added -safeseh:no to those tests to preserve behavior. Finally, LLD no longer sets IMAGE_DLL_CHARACTERISTICS_NO_SEH if any input file wasn't compiled for safeseh. Reviewers: mstorsjo, ruiu, thakis Reviewed By: ruiu, thakis Subscribers: llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D63570 llvm-svn: 366238
25 lines
1.0 KiB
Plaintext
25 lines
1.0 KiB
Plaintext
# REQUIRES: x86
|
|
# RUN: yaml2obj < %p/Inputs/hello32.yaml > %t.obj
|
|
#
|
|
# RUN: lld-link -safeseh:no %t.obj /fixed %p/Inputs/std32.lib /subsystem:console \
|
|
# RUN: /entry:main@0 /debug /out:%t.fixed.exe
|
|
# RUN: llvm-readobj --file-headers %t.fixed.exe | \
|
|
# RUN: FileCheck -check-prefix=EXEFIXED %s
|
|
#
|
|
# RUN: lld-link -safeseh:no %t.obj %p/Inputs/std32.lib /subsystem:console \
|
|
# RUN: /entry:main@0 /debug /out:%t.exe
|
|
# RUN: llvm-readobj --file-headers %t.exe | FileCheck -check-prefix=EXEREL %s
|
|
#
|
|
# RUN: yaml2obj < %p/Inputs/export.yaml > %t.obj
|
|
#
|
|
# RUN: lld-link -safeseh:no %t.obj /dll /fixed /debug /out:%t.fixed.dll
|
|
# RUN: llvm-readobj --file-headers %t.fixed.dll | FileCheck -check-prefix=DLLFIXED %s
|
|
#
|
|
# RUN: lld-link -safeseh:no %t.obj /dll /debug /out:%t.dll
|
|
# RUN: llvm-readobj --file-headers %t.dll | FileCheck -check-prefix=DLLREL %s
|
|
|
|
EXEFIXED-NOT: IMAGE_DLL_CHARACTERISTICS_DYNAMIC_BASE
|
|
DLLFIXED-NOT: IMAGE_DLL_CHARACTERISTICS_DYNAMIC_BASE
|
|
EXEREL: IMAGE_DLL_CHARACTERISTICS_DYNAMIC_BASE
|
|
DLLREL: IMAGE_DLL_CHARACTERISTICS_DYNAMIC_BASE
|