Summary: It does not currently make sense to use WebAssembly features in some functions but not others, so this CL adds an IR pass that takes the union of all used feature sets and applies it to each function in the module. This allows us to prevent atomics from being lowered away if some function has opted in to using them. When atomics is not enabled anywhere, we detect whether there exists any atomic operations or thread local storage that would be stripped and disallow linking with objects that contain atomics if and only if atomics or tls are stripped. When atomics is enabled, mark it as used but do not require it of other objects in the link. These changes allow libraries that do not use atomics to be built once and linked into both single-threaded and multithreaded binaries. Reviewers: aheejin, sbc100, dschuff Subscribers: jgravelle-google, hiraditya, sunfish, jfb, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D59625 llvm-svn: 357226
34 lines
1.1 KiB
LLVM
34 lines
1.1 KiB
LLVM
; RUN: llc -filetype=obj %s -o - | obj2yaml | FileCheck %s
|
|
|
|
target triple = "wasm32-unknown-unknown"
|
|
|
|
; Weak external data reference
|
|
@weak_external_data = extern_weak global i32, align 4
|
|
|
|
; Weak function definition
|
|
define weak hidden i32 @weak_function() local_unnamed_addr #0 {
|
|
entry:
|
|
%0 = load i32, i32* @weak_external_data, align 4
|
|
ret i32 %0
|
|
}
|
|
|
|
; CHECK: - Type: IMPORT
|
|
; CHECK-NEXT: Imports:
|
|
; CHECK: - Module: env
|
|
; CHECK-NEXT: Field: __linear_memory
|
|
; CHECK: - Module: env
|
|
; CHECK-NEXT: Field: __indirect_function_table
|
|
|
|
|
|
; CHECK: SymbolTable:
|
|
; CHECK-NEXT: - Index: 0
|
|
; CHECK-NEXT: Kind: FUNCTION
|
|
; CHECK-NEXT: Name: weak_function
|
|
; CHECK-NEXT: Flags: [ BINDING_WEAK, VISIBILITY_HIDDEN ]
|
|
; CHECK-NEXT: Function: 0
|
|
; CHECK-NEXT: - Index: 1
|
|
; CHECK-NEXT: Kind: DATA
|
|
; CHECK-NEXT: Name: weak_external_data
|
|
; CHECK-NEXT: Flags: [ BINDING_WEAK, UNDEFINED ]
|
|
; CHECK-NEXT: ...
|