8c97ddff53
This patch adds a default memory space attribute to the DL and adds methods to query the attribute. This is required as MLIR has no well defined default memory space unlike LLVM which has 0. While `nullptr` is a candidate for default memory space, the `ptr` dialect will remove the possibility for `nullptr` memory spaces to avoid undefined semantics. This patch also modifies the `DataLayoutTypeInterface::areCompatible` to include the new DL spec and merged entries, as it is needed to query the default memory space. --------- Co-authored-by: Christian Ulmann <christianulmann@gmail.com>
346 lines
9.9 KiB
MLIR
346 lines
9.9 KiB
MLIR
// RUN: mlir-opt --test-data-layout-query --split-input-file --verify-diagnostics %s | FileCheck %s
|
|
|
|
module {
|
|
// CHECK: @no_spec
|
|
func.func @no_spec() {
|
|
// CHECK: alignment = 8
|
|
// CHECK: alloca_memory_space = 0
|
|
// CHECK: bitsize = 64
|
|
// CHECK: default_memory_space = 0
|
|
// CHECK: endianness = ""
|
|
// CHECK: global_memory_space = 0
|
|
// CHECK: index = 64
|
|
// CHECK: mangling_mode = ""
|
|
// CHECK: preferred = 8
|
|
// CHECK: program_memory_space = 0
|
|
// CHECK: size = 8
|
|
// CHECK: stack_alignment = 0
|
|
"test.data_layout_query"() : () -> !llvm.ptr
|
|
// CHECK: alignment = 8
|
|
// CHECK: alloca_memory_space = 0
|
|
// CHECK: bitsize = 64
|
|
// CHECK: default_memory_space = 0
|
|
// CHECK: endianness = ""
|
|
// CHECK: global_memory_space = 0
|
|
// CHECK: index = 64
|
|
// CHECK: mangling_mode = ""
|
|
// CHECK: preferred = 8
|
|
// CHECK: program_memory_space = 0
|
|
// CHECK: size = 8
|
|
// CHECK: stack_alignment = 0
|
|
"test.data_layout_query"() : () -> !llvm.ptr<3>
|
|
// CHECK: alignment = 8
|
|
// CHECK: alloca_memory_space = 0
|
|
// CHECK: bitsize = 64
|
|
// CHECK: default_memory_space = 0
|
|
// CHECK: endianness = ""
|
|
// CHECK: global_memory_space = 0
|
|
// CHECK: index = 64
|
|
// CHECK: mangling_mode = ""
|
|
// CHECK: preferred = 8
|
|
// CHECK: program_memory_space = 0
|
|
// CHECK: size = 8
|
|
// CHECK: stack_alignment = 0
|
|
"test.data_layout_query"() : () -> !llvm.ptr<5>
|
|
return
|
|
}
|
|
}
|
|
|
|
// -----
|
|
|
|
module attributes { dlti.dl_spec = #dlti.dl_spec<
|
|
#dlti.dl_entry<!llvm.ptr, dense<[32, 32, 64]> : vector<3xi64>>,
|
|
#dlti.dl_entry<!llvm.ptr<5>, dense<[64, 64, 64]> : vector<3xi64>>,
|
|
#dlti.dl_entry<!llvm.ptr<4>, dense<[32, 64, 64, 24]> : vector<4xi64>>,
|
|
#dlti.dl_entry<"dlti.endianness", "little">,
|
|
#dlti.dl_entry<"dlti.default_memory_space", 7 : ui64>,
|
|
#dlti.dl_entry<"dlti.alloca_memory_space", 5 : ui64>,
|
|
#dlti.dl_entry<"dlti.global_memory_space", 2 : ui64>,
|
|
#dlti.dl_entry<"dlti.program_memory_space", 3 : ui64>,
|
|
#dlti.dl_entry<"dlti.stack_alignment", 128 : i64>,
|
|
#dlti.dl_entry<"dlti.mangling_mode", "e">
|
|
>} {
|
|
// CHECK: @spec
|
|
func.func @spec() {
|
|
// CHECK: alignment = 4
|
|
// CHECK: alloca_memory_space = 5
|
|
// CHECK: bitsize = 32
|
|
// CHECK: default_memory_space = 7
|
|
// CHECK: endianness = "little"
|
|
// CHECK: global_memory_space = 2
|
|
// CHECK: index = 32
|
|
// CHECK: mangling_mode = "e"
|
|
// CHECK: preferred = 8
|
|
// CHECK: program_memory_space = 3
|
|
// CHECK: size = 4
|
|
// CHECK: stack_alignment = 128
|
|
"test.data_layout_query"() : () -> !llvm.ptr
|
|
// CHECK: alignment = 4
|
|
// CHECK: alloca_memory_space = 5
|
|
// CHECK: bitsize = 32
|
|
// CHECK: default_memory_space = 7
|
|
// CHECK: endianness = "little"
|
|
// CHECK: global_memory_space = 2
|
|
// CHECK: index = 32
|
|
// CHECK: preferred = 8
|
|
// CHECK: program_memory_space = 3
|
|
// CHECK: size = 4
|
|
// CHECK: stack_alignment = 128
|
|
"test.data_layout_query"() : () -> !llvm.ptr<3>
|
|
// CHECK: alignment = 8
|
|
// CHECK: alloca_memory_space = 5
|
|
// CHECK: bitsize = 64
|
|
// CHECK: default_memory_space = 7
|
|
// CHECK: endianness = "little"
|
|
// CHECK: global_memory_space = 2
|
|
// CHECK: index = 64
|
|
// CHECK: mangling_mode = "e"
|
|
// CHECK: preferred = 8
|
|
// CHECK: program_memory_space = 3
|
|
// CHECK: size = 8
|
|
// CHECK: stack_alignment = 128
|
|
"test.data_layout_query"() : () -> !llvm.ptr<5>
|
|
// CHECK: alignment = 8
|
|
// CHECK: alloca_memory_space = 5
|
|
// CHECK: bitsize = 32
|
|
// CHECK: default_memory_space = 7
|
|
// CHECK: endianness = "little"
|
|
// CHECK: global_memory_space = 2
|
|
// CHECK: index = 24
|
|
// CHECK: mangling_mode = "e"
|
|
// CHECK: preferred = 8
|
|
// CHECK: program_memory_space = 3
|
|
// CHECK: size = 4
|
|
// CHECK: stack_alignment = 128
|
|
"test.data_layout_query"() : () -> !llvm.ptr<4>
|
|
return
|
|
}
|
|
}
|
|
|
|
// -----
|
|
|
|
// expected-error@below {{expected layout attribute for '!llvm.ptr' to be a dense integer elements attribute with 3 or 4 elements}}
|
|
module attributes { dlti.dl_spec = #dlti.dl_spec<
|
|
#dlti.dl_entry<!llvm.ptr, dense<[64.0, 64.0, 64.0]> : vector<3xf32>>
|
|
>} {
|
|
func.func @pointer() {
|
|
return
|
|
}
|
|
}
|
|
|
|
// -----
|
|
|
|
// expected-error@below {{preferred alignment is expected to be at least as large as ABI alignment}}
|
|
module attributes { dlti.dl_spec = #dlti.dl_spec<
|
|
#dlti.dl_entry<!llvm.ptr, dense<[64, 64, 32]> : vector<3xi64>>
|
|
>} {
|
|
func.func @pointer() {
|
|
return
|
|
}
|
|
}
|
|
|
|
// -----
|
|
|
|
// expected-error @below {{expected i64 parameters for '!llvm.ptr'}}
|
|
module attributes { dlti.dl_spec = #dlti.dl_spec<
|
|
#dlti.dl_entry<!llvm.ptr, dense<[32, 32, 64]> : vector<3xi32>>
|
|
>} {
|
|
}
|
|
|
|
// -----
|
|
|
|
module {
|
|
// CHECK: @no_spec
|
|
func.func @no_spec() {
|
|
// simple case
|
|
// CHECK: alignment = 4
|
|
// CHECK: bitsize = 32
|
|
// CHECK: index = 0
|
|
// CHECK: preferred = 4
|
|
// CHECK: size = 4
|
|
"test.data_layout_query"() : () -> !llvm.struct<(i32)>
|
|
|
|
// padding inbetween
|
|
// CHECK: alignment = 8
|
|
// CHECK: bitsize = 128
|
|
// CHECK: index = 0
|
|
// CHECK: preferred = 8
|
|
// CHECK: size = 16
|
|
"test.data_layout_query"() : () -> !llvm.struct<(i32, f64)>
|
|
|
|
// padding at end of struct
|
|
// CHECK: alignment = 8
|
|
// CHECK: bitsize = 128
|
|
// CHECK: index = 0
|
|
// CHECK: preferred = 8
|
|
// CHECK: size = 16
|
|
"test.data_layout_query"() : () -> !llvm.struct<(f64, i32)>
|
|
|
|
// packed
|
|
// CHECK: alignment = 1
|
|
// CHECK: bitsize = 96
|
|
// CHECK: index = 0
|
|
// CHECK: preferred = 8
|
|
// CHECK: size = 12
|
|
"test.data_layout_query"() : () -> !llvm.struct<packed (f64, i32)>
|
|
|
|
// empty
|
|
// CHECK: alignment = 1
|
|
// CHECK: bitsize = 0
|
|
// CHECK: index = 0
|
|
// CHECK: preferred = 1
|
|
// CHECK: size = 0
|
|
"test.data_layout_query"() : () -> !llvm.struct<()>
|
|
return
|
|
}
|
|
}
|
|
|
|
// -----
|
|
|
|
module attributes { dlti.dl_spec = #dlti.dl_spec<
|
|
#dlti.dl_entry<!llvm.struct<()>, dense<[32, 32]> : vector<2xi64>>
|
|
>} {
|
|
// CHECK: @spec
|
|
func.func @spec() {
|
|
// Strict alignment is applied
|
|
// CHECK: alignment = 4
|
|
// CHECK: bitsize = 16
|
|
// CHECK: index = 0
|
|
// CHECK: preferred = 4
|
|
// CHECK: size = 2
|
|
"test.data_layout_query"() : () -> !llvm.struct<(i16)>
|
|
|
|
// No impact on structs that have stricter requirements
|
|
// CHECK: alignment = 8
|
|
// CHECK: bitsize = 128
|
|
// CHECK: index = 0
|
|
// CHECK: preferred = 8
|
|
// CHECK: size = 16
|
|
"test.data_layout_query"() : () -> !llvm.struct<(i32, f64)>
|
|
|
|
// Only the preferred alignment of structs is affected
|
|
// CHECK: alignment = 1
|
|
// CHECK: bitsize = 32
|
|
// CHECK: index = 0
|
|
// CHECK: preferred = 4
|
|
// CHECK: size = 4
|
|
"test.data_layout_query"() : () -> !llvm.struct<packed (i16, i16)>
|
|
|
|
// empty
|
|
// CHECK: alignment = 4
|
|
// CHECK: bitsize = 0
|
|
// CHECK: index = 0
|
|
// CHECK: preferred = 4
|
|
// CHECK: size = 0
|
|
"test.data_layout_query"() : () -> !llvm.struct<()>
|
|
return
|
|
}
|
|
}
|
|
|
|
// -----
|
|
|
|
module attributes { dlti.dl_spec = #dlti.dl_spec<
|
|
#dlti.dl_entry<!llvm.struct<()>, dense<[32]> : vector<1xi64>>
|
|
>} {
|
|
// CHECK: @spec_without_preferred
|
|
func.func @spec_without_preferred() {
|
|
// abi alignment is applied to both preferred and abi
|
|
// CHECK: alignment = 4
|
|
// CHECK: bitsize = 16
|
|
// CHECK: preferred = 4
|
|
// CHECK: size = 2
|
|
"test.data_layout_query"() : () -> !llvm.struct<(i16)>
|
|
return
|
|
}
|
|
}
|
|
|
|
// -----
|
|
|
|
// expected-error@below {{unexpected layout attribute for struct '!llvm.struct<(i8)>'}}
|
|
module attributes { dlti.dl_spec = #dlti.dl_spec<
|
|
#dlti.dl_entry<!llvm.struct<(i8)>, dense<[64, 64]> : vector<2xi64>>
|
|
>} {
|
|
func.func @struct() {
|
|
return
|
|
}
|
|
}
|
|
|
|
// -----
|
|
|
|
// expected-error@below {{expected layout attribute for '!llvm.struct<()>' to be a dense integer elements attribute of 1 or 2 elements}}
|
|
module attributes { dlti.dl_spec = #dlti.dl_spec<
|
|
#dlti.dl_entry<!llvm.struct<()>, dense<[64, 64, 64]> : vector<3xi64>>
|
|
>} {
|
|
func.func @struct() {
|
|
return
|
|
}
|
|
}
|
|
|
|
// -----
|
|
|
|
// expected-error@below {{preferred alignment is expected to be at least as large as ABI alignment}}
|
|
module attributes { dlti.dl_spec = #dlti.dl_spec<
|
|
#dlti.dl_entry<!llvm.struct<()>, dense<[64, 32]> : vector<2xi64>>
|
|
>} {
|
|
func.func @struct() {
|
|
return
|
|
}
|
|
}
|
|
|
|
// -----
|
|
|
|
module {
|
|
// CHECK: @arrays
|
|
func.func @arrays() {
|
|
// simple case
|
|
// CHECK: alignment = 4
|
|
// CHECK: bitsize = 64
|
|
// CHECK: index = 0
|
|
// CHECK: preferred = 4
|
|
// CHECK: size = 8
|
|
"test.data_layout_query"() : () -> !llvm.array<2 x i32>
|
|
|
|
// size 0
|
|
// CHECK: alignment = 8
|
|
// CHECK: bitsize = 0
|
|
// CHECK: index = 0
|
|
// CHECK: preferred = 8
|
|
// CHECK: size = 0
|
|
"test.data_layout_query"() : () -> !llvm.array<0 x f64>
|
|
|
|
// alignment info matches element type
|
|
// CHECK: alignment = 4
|
|
// CHECK: bitsize = 64
|
|
// CHECK: index = 0
|
|
// CHECK: preferred = 8
|
|
// CHECK: size = 8
|
|
"test.data_layout_query"() : () -> !llvm.array<1 x i64>
|
|
return
|
|
}
|
|
}
|
|
|
|
// -----
|
|
|
|
module attributes { dlti.dl_spec = #dlti.dl_spec<
|
|
#dlti.dl_entry<!llvm.struct<()>, dense<[64]> : vector<1xi64>>
|
|
>} {
|
|
// CHECK: @overaligned
|
|
func.func @overaligned() {
|
|
// Over aligned element types are respected
|
|
// CHECK: alignment = 8
|
|
// CHECK: bitsize = 128
|
|
// CHECK: preferred = 8
|
|
// CHECK: size = 16
|
|
"test.data_layout_query"() : () -> !llvm.array<2 x struct<(i8)>>
|
|
return
|
|
}
|
|
}
|
|
|
|
// -----
|
|
|
|
// expected-error @below {{expected i64 entries for '!llvm.struct<()>'}}
|
|
module attributes { dlti.dl_spec = #dlti.dl_spec<
|
|
#dlti.dl_entry<!llvm.struct<()>, dense<[64]> : vector<1xi32>>
|
|
>} {
|
|
}
|