987d331fab
Summary: The motivating use case is eliminating duplicate profile data registered for the same inline function in two object files. Before this change, users would observe multiple symbol definition errors with VC link, but links with LLD would succeed. Users (Mozilla) have reported that PGO works well with clang-cl and LLD, but when using LLD without this static registration, we would get into a "relocation against a discarded section" situation. I'm not sure what happens in that situation, but I suspect that duplicate, unused profile information was retained. If so, this change will reduce the size of such binaries with LLD. Now, Windows uses static registration and is in line with all the other platforms. Reviewers: davidxl, wmi, inglorion, void, calixte Subscribers: mgorny, krytarowski, eraman, fedor.sergeev, hiraditya, #sanitizers, dmajor, llvm-commits Tags: #sanitizers, #llvm Differential Revision: https://reviews.llvm.org/D57929 llvm-svn: 353547
41 lines
1007 B
C++
41 lines
1007 B
C++
// RUN: %clang_profgen -g -fcoverage-mapping -c -o %t1.o %s -DOBJECT_1
|
|
// RUN: %clang_profgen -g -fcoverage-mapping -c -o %t2.o %s
|
|
// RUN: %clang_profgen -g -fcoverage-mapping %t1.o %t2.o -o %t.exe
|
|
// RUN: env LLVM_PROFILE_FILE=%t.profraw %run %t.exe
|
|
// RUN: llvm-profdata show %t.profraw -all-functions | FileCheck %s
|
|
|
|
// Test that the instrumentation puts the right linkage on the profile data for
|
|
// inline functions.
|
|
|
|
// CHECK: {{.*}}foo{{.*}}:
|
|
// CHECK-NEXT: Hash:
|
|
// CHECK-NEXT: Counters: 1
|
|
// CHECK-NEXT: Function count: 1
|
|
// CHECK: {{.*}}inline_wrapper{{.*}}:
|
|
// CHECK-NEXT: Hash:
|
|
// CHECK-NEXT: Counters: 1
|
|
// CHECK-NEXT: Function count: 2
|
|
// CHECK: main:
|
|
// CHECK-NEXT: Hash:
|
|
// CHECK-NEXT: Counters: 1
|
|
// CHECK-NEXT: Function count: 1
|
|
|
|
extern "C" int puts(const char *);
|
|
|
|
inline void inline_wrapper(const char *msg) {
|
|
puts(msg);
|
|
}
|
|
|
|
void foo();
|
|
|
|
#ifdef OBJECT_1
|
|
void foo() {
|
|
inline_wrapper("foo");
|
|
}
|
|
#else
|
|
int main() {
|
|
inline_wrapper("main");
|
|
foo();
|
|
}
|
|
#endif
|