aee4925507
Based on post-commit review discussion on 2bd84938470bf2e337801faafb8a67710f46429d with Richard Smith. Other uses of forcing HasEmptyPlaceHolder to false seem OK to me - they're all around pointer/reference types where the pointer/reference token will appear at the rightmost side of the left side of the type name, so they make nested types (eg: the "int" in "int *") behave as though there is a non-empty placeholder (because the "*" is essentially the placeholder as far as the "int" is concerned). This was originally committed in 277623f4d5a672d707390e2c3eaf30a9eb4b075c Reverted in f9ad1d1c775a8e264bebc15d75e0c6e5c20eefc7 due to breakages outside of clang - lldb seems to have some strange/strong dependence on "char [N]" versus "char[N]" when printing strings (not due to that name appearing in DWARF, but probably due to using clang to stringify type names) that'll need to be addressed, plus a few other odds and ends in other subprojects (clang-tools-extra, compiler-rt, etc).
54 lines
1.6 KiB
C
54 lines
1.6 KiB
C
// RUN: %clang_cc1 -fno-rtti -emit-llvm-only -triple x86_64-pc-win32 -fms-extensions -fdump-record-layouts -fsyntax-only %s 2>/dev/null \
|
|
// RUN: | FileCheck %s -check-prefix CHECK
|
|
|
|
// Before PR45420, we would only find the alignment on this record. Afterwards,
|
|
// we can see the alignment on the typedef through the array type.
|
|
// FIXME: What about other type sugar, like _Atomic? This would only matter in a
|
|
// packed struct context.
|
|
struct __declspec(align(16)) AlignedStruct { int x; };
|
|
typedef int __declspec(align(16)) AlignedInt;
|
|
|
|
#define CHECK_SIZE(X, Align) \
|
|
_Static_assert(__alignof(struct X) == Align, "should be aligned");
|
|
|
|
#pragma pack(push, 2)
|
|
|
|
struct A {
|
|
struct AlignedStruct a[1];
|
|
};
|
|
CHECK_SIZE(A, 16);
|
|
|
|
struct B {
|
|
char b;
|
|
AlignedInt a[1];
|
|
};
|
|
CHECK_SIZE(B, 16);
|
|
|
|
struct C {
|
|
char b;
|
|
AlignedInt a[];
|
|
};
|
|
CHECK_SIZE(C, 16);
|
|
|
|
// CHECK: *** Dumping AST Record Layout
|
|
// CHECK-NEXT: 0 | struct AlignedStruct
|
|
// CHECK-NEXT: 0 | int x
|
|
// CHECK-NEXT: | [sizeof=16, align=16]
|
|
// CHECK: *** Dumping AST Record Layout
|
|
// CHECK-NEXT: 0 | struct A
|
|
// CHECK-NEXT: 0 | struct AlignedStruct[1] a
|
|
// CHECK-NEXT: | [sizeof=16, align=16]
|
|
// CHECK: *** Dumping AST Record Layout
|
|
// CHECK-NEXT: 0 | struct B
|
|
// CHECK-NEXT: 0 | char b
|
|
// CHECK-NEXT: 16 | AlignedInt[1] a
|
|
// CHECK-NEXT: | [sizeof=32, align=16]
|
|
// CHECK: *** Dumping AST Record Layout
|
|
// CHECK-NEXT: 0 | struct C
|
|
// CHECK-NEXT: 0 | char b
|
|
// CHECK-NEXT: 16 | AlignedInt[] a
|
|
// CHECK-NEXT: | [sizeof=16, align=16]
|
|
|
|
#pragma pack(pop)
|
|
|