
Reland of https://github.com/llvm/llvm-project/pull/147381 Added changes to fix observed BuildBot failures: * CMake version (reduced minimum to `3.20`, was: `3.22`) * GoogleTest linking (missing `./build/lib/libllvm_gtest.a`) * Related header issue (missing `#include "llvm/Support/raw_os_ostream.h"`) Original message Description =========== OpenMP Tooling Interface Testing Library (ompTest) ompTest is a unit testing framework for testing OpenMP implementations. It offers a simple-to-use framework that allows a tester to check for OMPT events in addition to regular unit testing code, supported by linking against GoogleTest by default. It also facilitates writing concise tests while bridging the semantic gap between the unit under test and the OMPT-event testing. Background ========== This library has been developed to provide the means of testing OMPT implementations with reasonable effort. Especially, asynchronous or unordered events are supported and can be verified with ease, which may prove to be challenging with LIT-based tests. Additionally, since the assertions are part of the code being tested, ompTest can reference all corresponding variables during assertion. Basic Usage =========== OMPT event assertions are placed before the code, which shall be tested. These assertion can either be provided as one block or interleaved with the test code. There are two types of asserters: (1) sequenced "order-sensitive" and (2) set "unordered" assserters. Once the test is being run, the corresponding events are triggered by the OpenMP runtime and can be observed. Each of these observed events notifies asserters, which then determine if the test should pass or fail. Example (partial, interleaved) ============================== ```c++ int N = 100000; int a[N]; int b[N]; OMPT_ASSERT_SEQUENCE(Target, TARGET, BEGIN, 0); OMPT_ASSERT_SEQUENCE(TargetDataOp, ALLOC, N * sizeof(int)); // a ? OMPT_ASSERT_SEQUENCE(TargetDataOp, H2D, N * sizeof(int), &a); OMPT_ASSERT_SEQUENCE(TargetDataOp, ALLOC, N * sizeof(int)); // b ? OMPT_ASSERT_SEQUENCE(TargetDataOp, H2D, N * sizeof(int), &b); OMPT_ASSERT_SEQUENCE(TargetSubmit, 1); OMPT_ASSERT_SEQUENCE(TargetDataOp, D2H, N * sizeof(int), nullptr, &b); OMPT_ASSERT_SEQUENCE(TargetDataOp, D2H, N * sizeof(int), nullptr, &a); OMPT_ASSERT_SEQUENCE(TargetDataOp, DELETE); OMPT_ASSERT_SEQUENCE(TargetDataOp, DELETE); OMPT_ASSERT_SEQUENCE(Target, TARGET, END, 0); #pragma omp target parallel for { for (int j = 0; j < N; j++) a[j] = b[j]; } ``` References ========== This work has been presented at SC'24 workshops, see: https://ieeexplore.ieee.org/document/10820689 Current State and Future Work ============================= ompTest's development was mostly device-centric and aimed at OMPT device callbacks and device-side tracing. Consequentially, a substantial part of host-related events or features may not be supported in its current state. However, we are confident that the related functionality can be added and ompTest provides a general foundation for future OpenMP and especially OMPT testing. This PR will allow us to upstream the corresponding features, like OMPT device-side tracing in the future with significantly reduced risk of introducing regressions in the process. Build ===== ompTest is linked against LLVM's GoogleTest by default, but can also be built 'standalone'. Additionally, it comes with a set of unit tests, which in turn require GoogleTest (overriding a standalone build). The unit tests are added to the `check-openmp` target. Use the following parameters to perform the corresponding build: `LIBOMPTEST_BUILD_STANDALONE` (Default: ${OPENMP_STANDALONE_BUILD}) `LIBOMPTEST_BUILD_UNITTESTS` (Default: OFF) --------- Co-authored-by: Jan-Patrick Lehr <JanPatrick.Lehr@amd.com> Co-authored-by: Joachim <protze@rz.rwth-aachen.de> Co-authored-by: Joachim Jenke <jenke@itc.rwth-aachen.de>
155 lines
5.0 KiB
CMake
155 lines
5.0 KiB
CMake
##===----------------------------------------------------------------------===##
|
|
#
|
|
# Build OMPT unit testing library: ompTest
|
|
#
|
|
##===----------------------------------------------------------------------===##
|
|
|
|
cmake_minimum_required(VERSION 3.20)
|
|
project(omptest LANGUAGES CXX)
|
|
|
|
option(LIBOMPTEST_BUILD_STANDALONE
|
|
"Build ompTest 'standalone', i.e. w/o GoogleTest."
|
|
${OPENMP_STANDALONE_BUILD})
|
|
option(LIBOMPTEST_BUILD_UNITTESTS
|
|
"Build ompTest's unit tests, requires GoogleTest." OFF)
|
|
|
|
# In absence of corresponding OMPT support: exit early
|
|
if(NOT ${LIBOMP_OMPT_SUPPORT})
|
|
return()
|
|
endif()
|
|
|
|
include(CMakePackageConfigHelpers)
|
|
|
|
set(OMPTEST_HEADERS
|
|
./include/AssertMacros.h
|
|
./include/InternalEvent.h
|
|
./include/InternalEventCommon.h
|
|
./include/Logging.h
|
|
./include/OmptAliases.h
|
|
./include/OmptAsserter.h
|
|
./include/OmptAssertEvent.h
|
|
./include/OmptCallbackHandler.h
|
|
./include/OmptTester.h
|
|
./include/OmptTesterGlobals.h
|
|
)
|
|
|
|
add_library(omptest
|
|
SHARED
|
|
|
|
${OMPTEST_HEADERS}
|
|
./src/InternalEvent.cpp
|
|
./src/InternalEventOperators.cpp
|
|
./src/Logging.cpp
|
|
./src/OmptAsserter.cpp
|
|
./src/OmptAssertEvent.cpp
|
|
./src/OmptCallbackHandler.cpp
|
|
./src/OmptTester.cpp
|
|
)
|
|
|
|
# Target: ompTest library
|
|
# On (implicit) request of GoogleTest, link against the one provided with LLVM.
|
|
if ((NOT LIBOMPTEST_BUILD_STANDALONE) OR LIBOMPTEST_BUILD_UNITTESTS)
|
|
# Check if standalone build was requested together with unittests
|
|
if (LIBOMPTEST_BUILD_STANDALONE)
|
|
# Emit warning: this build actually depends on LLVM's GoogleTest
|
|
message(WARNING "LIBOMPTEST_BUILD_STANDALONE and LIBOMPTEST_BUILD_UNITTESTS"
|
|
" requested simultaneously.\n"
|
|
"Linking against LLVM's GoogleTest library archives.\n"
|
|
"Disable LIBOMPTEST_BUILD_UNITTESTS to perform an actual"
|
|
" standalone build.")
|
|
# Explicitly disable LIBOMPTEST_BUILD_STANDALONE
|
|
set(LIBOMPTEST_BUILD_STANDALONE OFF)
|
|
endif()
|
|
|
|
# Make sure target llvm_gtest is available
|
|
if (NOT TARGET llvm_gtest)
|
|
message(FATAL_ERROR "Required target not found: llvm_gtest")
|
|
endif()
|
|
|
|
# Add llvm_gtest as dependency
|
|
add_dependencies(omptest llvm_gtest)
|
|
|
|
# Link llvm_gtest as whole-archive to expose required symbols
|
|
set(GTEST_LINK_CMD "-Wl,--whole-archive" llvm_gtest
|
|
"-Wl,--no-whole-archive" LLVMSupport)
|
|
|
|
# Add GoogleTest-based header
|
|
target_sources(omptest PRIVATE ./include/OmptTesterGoogleTest.h)
|
|
|
|
# Add LLVM-provided GoogleTest include directories.
|
|
target_include_directories(omptest PRIVATE
|
|
${LLVM_THIRD_PARTY_DIR}/unittest/googletest/include)
|
|
|
|
# TODO: Re-visit ABI breaking checks, disable for now.
|
|
target_compile_definitions(omptest PUBLIC
|
|
-DLLVM_DISABLE_ABI_BREAKING_CHECKS_ENFORCING)
|
|
|
|
# Link against gtest and gtest_main
|
|
target_link_libraries(omptest PRIVATE ${GTEST_LINK_CMD})
|
|
else()
|
|
# Add 'standalone' compile definitions
|
|
target_compile_definitions(omptest PRIVATE
|
|
-DOPENMP_LIBOMPTEST_BUILD_STANDALONE)
|
|
|
|
# Add 'standalone' source files
|
|
target_sources(omptest PRIVATE
|
|
./include/OmptTesterStandalone.h
|
|
./src/OmptTesterStandalone.cpp)
|
|
endif()
|
|
|
|
if(TARGET cxx-headers)
|
|
add_dependencies(omptest cxx-headers)
|
|
endif()
|
|
|
|
if(TARGET cxx_shared)
|
|
add_dependencies(omptest cxx_shared)
|
|
endif()
|
|
|
|
if(TARGET cxxabi_shared)
|
|
add_dependencies(omptest cxxabi_shared)
|
|
endif()
|
|
|
|
# Add common include directories.
|
|
target_include_directories(omptest PUBLIC
|
|
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
|
|
$<INSTALL_INTERFACE:$<INSTALL_PREFIX>/${LIBOMP_HEADERS_INSTALL_PATH}/omptest>
|
|
)
|
|
|
|
target_compile_features(omptest PRIVATE cxx_std_17)
|
|
|
|
# Create and install package configuration files.
|
|
configure_package_config_file(
|
|
${CMAKE_CURRENT_SOURCE_DIR}/cmake/omptest-config.cmake.in
|
|
${CMAKE_CURRENT_BINARY_DIR}/cmake/omptest-config.cmake
|
|
INSTALL_DESTINATION "${OPENMP_INSTALL_LIBDIR}/cmake/openmp/omptest"
|
|
)
|
|
|
|
install(FILES ${omptest_BINARY_DIR}/cmake/omptest-config.cmake
|
|
DESTINATION "${OPENMP_INSTALL_LIBDIR}/cmake/openmp/omptest")
|
|
|
|
# Install libomptest header files: Copy header-files from include dir
|
|
install(DIRECTORY ./include/
|
|
DESTINATION "${LIBOMP_HEADERS_INSTALL_PATH}/omptest"
|
|
FILES_MATCHING PATTERN "*.h")
|
|
|
|
# Install library and export targets.
|
|
# Note: find_package(omptest) may require setting of PATH_SUFFIXES
|
|
# Example: "lib/cmake/openmp/omptest", this is due to the install location
|
|
install(TARGETS omptest
|
|
EXPORT OPENMPomptest
|
|
LIBRARY COMPONENT omptest
|
|
DESTINATION "${OPENMP_INSTALL_LIBDIR}"
|
|
INCLUDES DESTINATION "${LIBOMP_HEADERS_INSTALL_PATH}/omptest")
|
|
|
|
# Allow to link omptest by using: target_link_libraries( ... omptest::omptest)
|
|
# Additionally, it automatically propagates the include directory.
|
|
install(EXPORT OPENMPomptest
|
|
DESTINATION "${OPENMP_INSTALL_LIBDIR}/cmake/openmp/omptest"
|
|
NAMESPACE omptest::
|
|
FILE omptest-targets.cmake)
|
|
|
|
# Discover unit tests (added to check-openmp)
|
|
if(LIBOMPTEST_BUILD_UNITTESTS)
|
|
add_subdirectory(test)
|
|
endif()
|