783fbdc54e
I noticed that LLDB takes longer to stop than it should. Running a tiny
program like `int main() { return 0; }` in LLDB with `lldb test.exe -o r
-o q` takes about five seconds.
This is caused by the `WaitForMultipleObjects` in
[`ConnectionGenericFile::Read`](25976e8360/lldb/source/Host/windows/ConnectionGenericFileWindows.cpp (L191-L192))
timing out (it has a timeout of 5s).
It times out, because we never close the PTY created in
[`ProcessLaunchInfo::SetUpPtyRedirection`](25976e8360/lldb/source/Host/common/ProcessLaunchInfo.cpp (L213)).
When we call `target->GetProcessLaunchInfo().GetPTY().Close()` in
`ProcessWindows::OnExitProcess`, we don't access the PTY we created when
setting up the redirection - we're closing a default constructed one.
This is because the target's `m_launch_info` isn't necessarily the
`launch_info` we get in
[`Target::FinalizeFileActions`](4a8a0593bd/lldb/source/Target/Target.cpp (L3850))
when calling `SetUpPtyRedirection`.
With this PR, we store the PTY that a process was launched with inside
`ProcessWindows`, so we can later close it.
The wait of five seconds and a timed out `WaitForMultipleObjects` sounds
similar to https://github.com/llvm/llvm-project/pull/159308, but it's a
different call to `WaitForMultipleObjects` here. Still, I wonder if we
could do something to detect this earlier. Maybe some warning message or
debug-only assert if these waits time out?
125 lines
4.5 KiB
C++
125 lines
4.5 KiB
C++
//===-- ProcessWindows.h ----------------------------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef liblldb_Plugins_Process_Windows_Common_ProcessWindows_H_
|
|
#define liblldb_Plugins_Process_Windows_Common_ProcessWindows_H_
|
|
|
|
#include "lldb/Host/windows/PseudoConsole.h"
|
|
#include "lldb/Target/Process.h"
|
|
#include "lldb/Utility/Status.h"
|
|
#include "lldb/lldb-forward.h"
|
|
|
|
#include "Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.h"
|
|
#include "ProcessDebugger.h"
|
|
|
|
namespace lldb_private {
|
|
|
|
class HostProcess;
|
|
|
|
class ProcessWindows : public Process, public ProcessDebugger {
|
|
public:
|
|
// Static functions.
|
|
static lldb::ProcessSP CreateInstance(lldb::TargetSP target_sp,
|
|
lldb::ListenerSP listener_sp,
|
|
const FileSpec *,
|
|
bool can_connect);
|
|
|
|
static void Initialize();
|
|
|
|
static void Terminate();
|
|
|
|
static llvm::StringRef GetPluginNameStatic() { return "windows"; }
|
|
|
|
static llvm::StringRef GetPluginDescriptionStatic();
|
|
|
|
~ProcessWindows();
|
|
|
|
llvm::StringRef GetPluginName() override { return GetPluginNameStatic(); }
|
|
|
|
Status EnableBreakpointSite(BreakpointSite *bp_site) override;
|
|
Status DisableBreakpointSite(BreakpointSite *bp_site) override;
|
|
|
|
Status DoDetach(bool keep_stopped) override;
|
|
Status DoLaunch(Module *exe_module, ProcessLaunchInfo &launch_info) override;
|
|
Status DoAttachToProcessWithID(
|
|
lldb::pid_t pid,
|
|
const lldb_private::ProcessAttachInfo &attach_info) override;
|
|
Status DoResume(lldb::RunDirection direction) override;
|
|
Status DoDestroy() override;
|
|
Status DoHalt(bool &caused_stop) override;
|
|
|
|
void DidLaunch() override;
|
|
void DidAttach(lldb_private::ArchSpec &arch_spec) override;
|
|
|
|
void RefreshStateAfterStop() override;
|
|
|
|
bool CanDebug(lldb::TargetSP target_sp,
|
|
bool plugin_specified_by_name) override;
|
|
bool DestroyRequiresHalt() override { return false; }
|
|
bool DoUpdateThreadList(ThreadList &old_thread_list,
|
|
ThreadList &new_thread_list) override;
|
|
bool IsAlive() override;
|
|
|
|
ArchSpec GetSystemArchitecture() override;
|
|
|
|
size_t DoReadMemory(lldb::addr_t vm_addr, void *buf, size_t size,
|
|
Status &error) override;
|
|
size_t DoWriteMemory(lldb::addr_t vm_addr, const void *buf, size_t size,
|
|
Status &error) override;
|
|
lldb::addr_t DoAllocateMemory(size_t size, uint32_t permissions,
|
|
Status &error) override;
|
|
Status DoDeallocateMemory(lldb::addr_t ptr) override;
|
|
|
|
lldb::addr_t GetImageInfoAddress() override;
|
|
|
|
DynamicLoaderWindowsDYLD *GetDynamicLoader() override;
|
|
|
|
// IDebugDelegate overrides.
|
|
void OnExitProcess(uint32_t exit_code) override;
|
|
void OnDebuggerConnected(lldb::addr_t image_base) override;
|
|
ExceptionResult OnDebugException(bool first_chance,
|
|
const ExceptionRecord &record) override;
|
|
void OnCreateThread(const HostThread &thread) override;
|
|
void OnExitThread(lldb::tid_t thread_id, uint32_t exit_code) override;
|
|
void OnLoadDll(const ModuleSpec &module_spec,
|
|
lldb::addr_t module_addr) override;
|
|
void OnUnloadDll(lldb::addr_t module_addr) override;
|
|
void OnDebugString(const std::string &string) override;
|
|
void OnDebuggerError(const Status &error, uint32_t type) override;
|
|
|
|
std::optional<uint32_t> GetWatchpointSlotCount() override;
|
|
Status EnableWatchpoint(lldb::WatchpointSP wp_sp,
|
|
bool notify = true) override;
|
|
Status DisableWatchpoint(lldb::WatchpointSP wp_sp,
|
|
bool notify = true) override;
|
|
|
|
void
|
|
SetPseudoConsoleHandle(const std::shared_ptr<PseudoConsole> &pty) override;
|
|
|
|
protected:
|
|
ProcessWindows(lldb::TargetSP target_sp, lldb::ListenerSP listener_sp);
|
|
|
|
Status DoGetMemoryRegionInfo(lldb::addr_t vm_addr,
|
|
MemoryRegionInfo &info) override;
|
|
|
|
private:
|
|
struct WatchpointInfo {
|
|
uint32_t slot_id;
|
|
lldb::addr_t address;
|
|
uint32_t size;
|
|
bool read;
|
|
bool write;
|
|
};
|
|
std::map<lldb::break_id_t, WatchpointInfo> m_watchpoints;
|
|
std::vector<lldb::break_id_t> m_watchpoint_ids;
|
|
std::shared_ptr<PTY> m_pty;
|
|
};
|
|
} // namespace lldb_private
|
|
|
|
#endif // liblldb_Plugins_Process_Windows_Common_ProcessWindows_H_
|