46585a3082
Investigating some of the biggest slow downs during tests, the biggest offender is 'wait_for_stopped' requiring a negative assertion around the 'stopped' event. It currently waits for a negative predicate to fail before continuing. This means it must wait for the full DEFAULT_TIMEOUT (50s) before the test is allowed to continue. To mitigate this, I added a new `collect_events` helper that will wait for the given event to occur with the DEFAULT_TIMEOUT, then wait for a quiet period (0.25s) before returning. This greatly reduces the amount of idle waiting during tests. Additionally, looking a the performance of individual test files, `TestDAP_launch` is the slowest overall test. No individual test is that slow, but the fact it has so many tests in the same file results in the test harness waiting for that one file to finish. To mitigate that, I split `TestDAP_launch` into individual test files that run in parallel, reducing the runtime locally from over 2mins to ~5s.
84 lines
3.3 KiB
Python
84 lines
3.3 KiB
Python
"""
|
|
Test lldb-dap command hooks
|
|
"""
|
|
|
|
import lldbdap_testcase
|
|
from lldbsuite.test.decorators import *
|
|
|
|
|
|
class TestDAP_commands(lldbdap_testcase.DAPTestCaseBase):
|
|
def test_command_directive_quiet_on_success(self):
|
|
program = self.getBuildArtifact("a.out")
|
|
command_quiet = (
|
|
"settings set target.show-hex-variable-values-with-leading-zeroes false"
|
|
)
|
|
command_not_quiet = (
|
|
"settings set target.show-hex-variable-values-with-leading-zeroes true"
|
|
)
|
|
self.build_and_launch(
|
|
program,
|
|
initCommands=["?" + command_quiet, command_not_quiet],
|
|
terminateCommands=["?" + command_quiet, command_not_quiet],
|
|
stopCommands=["?" + command_quiet, command_not_quiet],
|
|
exitCommands=["?" + command_quiet, command_not_quiet],
|
|
)
|
|
full_output = self.collect_console(
|
|
pattern=command_not_quiet,
|
|
)
|
|
self.assertNotIn(command_quiet, full_output)
|
|
self.assertIn(command_not_quiet, full_output)
|
|
|
|
def do_test_abort_on_error(
|
|
self,
|
|
use_init_commands=False,
|
|
use_launch_commands=False,
|
|
use_pre_run_commands=False,
|
|
use_post_run_commands=False,
|
|
):
|
|
program = self.getBuildArtifact("a.out")
|
|
command_quiet = (
|
|
"settings set target.show-hex-variable-values-with-leading-zeroes false"
|
|
)
|
|
command_abort_on_error = "settings set foo bar"
|
|
commands = ["?!" + command_quiet, "!" + command_abort_on_error]
|
|
self.build_and_launch(
|
|
program,
|
|
initCommands=commands if use_init_commands else None,
|
|
launchCommands=commands if use_launch_commands else None,
|
|
preRunCommands=commands if use_pre_run_commands else None,
|
|
postRunCommands=commands if use_post_run_commands else None,
|
|
)
|
|
self.verify_configuration_done(use_post_run_commands)
|
|
full_output = self.collect_console(
|
|
pattern=command_abort_on_error,
|
|
)
|
|
self.assertNotIn(command_quiet, full_output)
|
|
self.assertIn(command_abort_on_error, full_output)
|
|
|
|
def test_command_directive_abort_on_error_init_commands(self):
|
|
self.do_test_abort_on_error(use_init_commands=True)
|
|
|
|
def test_command_directive_abort_on_error_launch_commands(self):
|
|
self.do_test_abort_on_error(use_launch_commands=True)
|
|
|
|
def test_command_directive_abort_on_error_pre_run_commands(self):
|
|
self.do_test_abort_on_error(use_pre_run_commands=True)
|
|
|
|
def test_command_directive_abort_on_error_post_run_commands(self):
|
|
self.do_test_abort_on_error(use_post_run_commands=True)
|
|
|
|
def test_command_directive_abort_on_error_attach_commands(self):
|
|
command_quiet = (
|
|
"settings set target.show-hex-variable-values-with-leading-zeroes false"
|
|
)
|
|
command_abort_on_error = "settings set foo bar"
|
|
program = self.build_and_create_debug_adapter_for_attach()
|
|
resp = self.attach_and_configurationDone(
|
|
program=program,
|
|
attachCommands=["?!" + command_quiet, "!" + command_abort_on_error],
|
|
)
|
|
self.assertFalse(resp["success"], "expected 'attach' failure")
|
|
full_output = self.collect_console(pattern=command_abort_on_error)
|
|
self.assertNotIn(command_quiet, full_output)
|
|
self.assertIn(command_abort_on_error, full_output)
|