
StructuredDataImpl ownership semantics is unclear at best. Various structures were holding a non-owning pointer to it, with a comment that the object is owned somewhere else. From what I was able to gather that "somewhere else" was the SBStructuredData object, but I am not sure that all created object eventually made its way there. (It wouldn't matter even if they did, as we are leaking most of our SBStructuredData objects.) Since StructuredDataImpl is just a collection of two (shared) pointers, there's really no point in elaborate lifetime management, so this patch replaces all StructuredDataImpl pointers with actual objects or unique_ptrs to it. This makes it much easier to resolve SBStructuredData leaks in a follow-up patch. Differential Revision: https://reviews.llvm.org/D114791
42 lines
1.3 KiB
C++
42 lines
1.3 KiB
C++
//===-- LuaTests.cpp ------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "Plugins/ScriptInterpreter/Lua/Lua.h"
|
|
#include "Plugins/ScriptInterpreter/Lua/SWIGLuaBridge.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
using namespace lldb_private;
|
|
|
|
extern "C" int luaopen_lldb(lua_State *L) { return 0; }
|
|
|
|
llvm::Expected<bool> lldb_private::LLDBSwigLuaBreakpointCallbackFunction(
|
|
lua_State *L, lldb::StackFrameSP stop_frame_sp,
|
|
lldb::BreakpointLocationSP bp_loc_sp,
|
|
const StructuredDataImpl &extra_args_impl) {
|
|
return false;
|
|
}
|
|
|
|
llvm::Expected<bool> lldb_private::LLDBSwigLuaWatchpointCallbackFunction(
|
|
lua_State *L, lldb::StackFrameSP stop_frame_sp, lldb::WatchpointSP wp_sp) {
|
|
return false;
|
|
}
|
|
|
|
TEST(LuaTest, RunValid) {
|
|
Lua lua;
|
|
llvm::Error error = lua.Run("foo = 1");
|
|
EXPECT_FALSE(static_cast<bool>(error));
|
|
}
|
|
|
|
TEST(LuaTest, RunInvalid) {
|
|
Lua lua;
|
|
llvm::Error error = lua.Run("nil = foo");
|
|
EXPECT_TRUE(static_cast<bool>(error));
|
|
EXPECT_EQ(llvm::toString(std::move(error)),
|
|
"[string \"buffer\"]:1: unexpected symbol near 'nil'\n");
|
|
}
|