shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity
llvm-project/openmp/runtime/src
History
Samuel Antao 11e4c539f4 Initialize two variables in kmp_tasking. 
Summary:
Two initialized local variables are causing clang to produce warnings:

```
./src/projects/openmp/runtime/src/kmp_tasking.c:3019:5: error: variable 'num_tasks' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized]
    default:
    ^~~~~~~
./src/projects/openmp/runtime/src/kmp_tasking.c:3027:21: note: uninitialized use occurs here
    for( i = 0; i < num_tasks; ++i ) {
                    ^~~~~~~~~
./src/projects/openmp/runtime/src/kmp_tasking.c:2968:28: note: initialize the variable 'num_tasks' to silence this warning
    kmp_uint64 i, num_tasks, extras;
                           ^
                            = 0
./src/projects/openmp/runtime/src/kmp_tasking.c:3019:5: error: variable 'extras' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized]
    default:
    ^~~~~~~
./src/projects/openmp/runtime/src/kmp_tasking.c:3022:52: note: uninitialized use occurs here
    KMP_DEBUG_ASSERT(tc == num_tasks * grainsize + extras);
                                                   ^~~~~~
./src/projects/openmp/runtime/src/kmp_debug.h:62:60: note: expanded from macro 'KMP_DEBUG_ASSERT'
        #define KMP_DEBUG_ASSERT( cond )       KMP_ASSERT( cond )
                                                           ^
./src/projects/openmp/runtime/src/kmp_debug.h:60:51: note: expanded from macro 'KMP_ASSERT'
        #define KMP_ASSERT( cond )             ( (cond) ? 0 : __kmp_debug_assert( #cond, __FILE__, __LINE__ ) )
                                                  ^
./src/projects/openmp/runtime/src/kmp_tasking.c:2968:36: note: initialize the variable 'extras' to silence this warning
    kmp_uint64 i, num_tasks, extras;
                                   ^
                                    = 0
2 errors generated.
```

This patch initializes these two variables.

Reviewers: tlwilmar, jlpeyton

Subscribers: tlwilmar, openmp-commits

Differential Revision: http://reviews.llvm.org/D17909

llvm-svn: 263316
2016-03-12 00:55:17 +00:00
..
i18n
Adding Hwloc library option for affinity mechanism
2015-11-30 20:02:59 +00:00
include
Add new OpenMP 4.5 affinity API
2016-02-25 18:49:52 +00:00
thirdparty/ittnotify
D12403: Fix GCC warning 'always_inline function might not be inlinable'
2015-08-31 12:32:55 +00:00
CMakeLists.txt
Add LIBOMP_ENABLE_SHARED option for CMake
2016-02-04 19:29:35 +00:00
dllexports
Add new OpenMP 4.5 taskloop construct feature
2016-03-02 22:47:51 +00:00
exports_so.txt
Removed unused __kmp_*_i8 functions.
2016-01-04 23:20:26 +00:00
extractExternal.cpp
Replace some unsafe API calls with safe alternatives on Windows, prepare code for similar actions on other platforms - wrap unsafe API calls into macros.
2015-04-02 13:27:08 +00:00
kmp_affinity.cpp
New API for restoring current thread's affinity to init affinity of application
2016-01-12 17:21:55 +00:00
kmp_affinity.h
Adding Hwloc library option for affinity mechanism
2015-11-30 20:02:59 +00:00
kmp_alloc.c
Fix memory corruption in Windows debug library
2015-09-25 17:23:17 +00:00
kmp_atomic.c
Remove unused variable anonym from kmp_atomic.c
2015-06-03 16:23:36 +00:00
kmp_atomic.h
[OMPT] Simplify control variable logic for OMPT
2015-09-21 18:11:22 +00:00
kmp_barrier.cpp
Fixing comments.
2016-01-27 20:57:32 +00:00
kmp_cancel.cpp
Tidy statistics collection
2015-08-11 21:36:41 +00:00
kmp_config.h.cmake
Removed unused __kmp_*_i8 functions.
2016-01-04 23:20:26 +00:00
kmp_csupport.c
[STATS] fix master and single timers
2016-03-03 21:21:05 +00:00
kmp_debug.c
Comments only: removing the Revision and Date svn variables from the top of all the source files.
2015-01-27 17:13:53 +00:00
kmp_debug.h
Remove unused variables '__kmp_build_check_*' for non assert builds.
2015-06-11 17:36:16 +00:00
kmp_debugger.c
Fix the OpenMP 3.0 build
2015-09-21 17:24:46 +00:00
kmp_debugger.h
Enable debugger support
2015-07-09 18:16:58 +00:00
kmp_dispatch.cpp
Add new OpenMP 4.5 doacross loop nest feature
2016-03-02 22:42:06 +00:00
kmp_environment.c
Darwin is the exception when it comes to accessing environ, all other
2015-09-21 19:37:05 +00:00
kmp_environment.h
Comments only: removing the Revision and Date svn variables from the top of all the source files.
2015-01-27 17:13:53 +00:00
kmp_error.c
Remove unused variable warnings by deletion.
2015-06-08 20:01:14 +00:00
kmp_error.h
Added new user-guided lock api, currently disabled. Use KMP_USE_DYNAMIC_LOCK=1 to enable it.
2015-02-20 18:05:17 +00:00
kmp_ftn_cdecl.c
Change macro GUIDEDLL_EXPORTS to KMP_DYNAMIC_LIB
2015-05-26 17:32:53 +00:00
kmp_ftn_entry.h
Add new OpenMP 4.5 affinity API
2016-02-25 18:49:52 +00:00
kmp_ftn_extra.c
Comments only: removing the Revision and Date svn variables from the top of all the source files.
2015-01-27 17:13:53 +00:00
kmp_ftn_os.h
Add new OpenMP 4.5 affinity API
2016-02-25 18:49:52 +00:00
kmp_ftn_stdcall.c
Comments only: removing the Revision and Date svn variables from the top of all the source files.
2015-01-27 17:13:53 +00:00
kmp_global.c
Add initial support for OpenMP 4.5 task priority feature
2016-02-25 18:04:09 +00:00
kmp_gsupport.c
[GCC] GOMP_task: Change argument type of if_cond from int to bool
2016-02-09 07:07:30 +00:00
kmp_i18n.c
Apply name change to src/* files.
2015-06-01 02:37:28 +00:00
kmp_i18n.h
Fix spelling errors
2015-05-22 22:35:51 +00:00
kmp_import.c
Apply name change to src/* files.
2015-06-01 02:37:28 +00:00
kmp_io.c
Replace some unsafe API calls with safe alternatives on Windows, prepare code for similar actions on other platforms - wrap unsafe API calls into macros.
2015-04-02 13:27:08 +00:00
kmp_io.h
Comments only: removing the Revision and Date svn variables from the top of all the source files.
2015-01-27 17:13:53 +00:00
kmp_itt.c
[OpenMP] [CMake] Removing expand-vars.pl in favor of CMake's configure_file()
2015-08-28 18:42:10 +00:00
kmp_itt.h
Added new user-guided lock api, currently disabled. Use KMP_USE_DYNAMIC_LOCK=1 to enable it.
2015-02-20 18:05:17 +00:00
kmp_itt.inl
Replace DYNA_* names with KMP_* names
2015-12-03 19:37:20 +00:00
kmp_lock.cpp
Add missing cleanup code for cached indirect lock pool.
2016-01-22 19:16:14 +00:00
kmp_lock.h
Hinted lock (OpenMP 4.5 feature) Updates/Fixes Part 3
2015-12-11 22:04:05 +00:00
kmp_omp.h
Fix the OpenMP 3.0 build
2015-09-21 17:24:46 +00:00
kmp_os.h
Removed unused __kmp_*_i8 functions.
2016-01-04 23:20:26 +00:00
kmp_platform.h
Removed unused __kmp_*_i8 functions.
2016-01-04 23:20:26 +00:00
kmp_runtime.c
Add new OpenMP 4.5 doacross loop nest feature
2016-03-02 22:42:06 +00:00
kmp_safe_c_api.h
Follow up to safe API patch
2015-07-09 18:20:51 +00:00
kmp_sched.cpp
dd new OpenMP 4.5 schedule clause modifiers (monotonic/non-monotonic) feature
2016-02-25 17:55:50 +00:00
kmp_settings.c
Add initial support for OpenMP 4.5 task priority feature
2016-02-25 18:04:09 +00:00
kmp_settings.h
Comments only: removing the Revision and Date svn variables from the top of all the source files.
2015-01-27 17:13:53 +00:00
kmp_stats_timing.cpp
[STATS] Properly guard the tick_time() function and its uses
2015-12-17 17:27:51 +00:00
kmp_stats_timing.h
[STATS] Have CMake do real check for stats functionality
2015-12-18 16:19:35 +00:00
kmp_stats.cpp
[STATS] Add a total statistics count
2016-03-11 20:20:49 +00:00
kmp_stats.h
[STATS] change TASK_execution name to OMP_task
2016-03-11 20:23:05 +00:00
kmp_str.c
Remove unused variable warnings by deletion.
2015-06-08 20:01:14 +00:00
kmp_str.h
Replace some unsafe API calls with safe alternatives on Windows, prepare code for similar actions on other platforms - wrap unsafe API calls into macros.
2015-04-02 13:27:08 +00:00
kmp_stub.c
Fix spelling errors
2015-05-22 22:35:51 +00:00
kmp_stub.h
Comments only: removing the Revision and Date svn variables from the top of all the source files.
2015-01-27 17:13:53 +00:00
kmp_taskdeps.cpp
Fix task dependency performance problem
2016-01-28 23:10:44 +00:00
kmp_tasking.c
Initialize two variables in kmp_tasking.
2016-03-12 00:55:17 +00:00
kmp_taskq.c
Remove unused variable warnings by deletion.
2015-06-08 20:01:14 +00:00
kmp_threadprivate.c
Replace some unsafe API calls with safe alternatives on Windows, prepare code for similar actions on other platforms - wrap unsafe API calls into macros.
2015-04-02 13:27:08 +00:00
kmp_utility.c
Remove unused variable warnings by deletion.
2015-06-08 20:01:14 +00:00
kmp_version.c
Formatting fixes
2016-01-27 21:02:04 +00:00
kmp_version.h
Apply name change to src/* files.
2015-06-01 02:37:28 +00:00
kmp_wait_release.cpp
Comments only: removing the Revision and Date svn variables from the top of all the source files.
2015-01-27 17:13:53 +00:00
kmp_wait_release.h
Put function names on their own line.
2016-01-11 20:28:55 +00:00
kmp_wrapper_getpid.h
Comments only: removing the Revision and Date svn variables from the top of all the source files.
2015-01-27 17:13:53 +00:00
kmp_wrapper_malloc.h
Add basic NetBSD support.
2015-09-21 20:02:45 +00:00
kmp.h
Add new OpenMP 4.5 taskloop construct feature
2016-03-02 22:47:51 +00:00
libomp.rc.var
[OpenMP] [CMake] Removing expand-vars.pl in favor of CMake's configure_file()
2015-08-28 18:42:10 +00:00
ompt-event-specific.h
[OMPT] Add support for ompt_event_task_dependences and ompt_event_task_dependence_pair
2016-01-28 10:39:52 +00:00
ompt-general.c
[OMPT] Remove unnecessary header in ompt-general.c
2015-11-11 17:30:26 +00:00
ompt-internal.h
[OMPT] Add support for ompt_event_task_dependences and ompt_event_task_dependence_pair
2016-01-28 10:39:52 +00:00
ompt-specific.c
[OMPT] Windows Support for OMPT
2015-10-29 20:56:24 +00:00
ompt-specific.h
Improve OMPT initialization code
2015-11-05 16:54:55 +00:00
test-touch.c
I apologise in advance for the size of this check-in. At Intel we do
2014-10-07 16:25:50 +00:00
z_Linux_asm.s
[OpenMP] [CMake] Removing expand-vars.pl in favor of CMake's configure_file()
2015-08-28 18:42:10 +00:00
z_Linux_util.c
Formatting fixes
2016-01-27 21:02:04 +00:00
z_Windows_NT_util.c
Formatting fixes
2016-01-27 21:02:04 +00:00
z_Windows_NT-586_asm.asm
These are the actual changes in the runtime to issue OMPT-related functions. All of them are surrounded by #if OMPT_SUPPORT and can be disabled (which is the default).
2015-04-29 16:42:24 +00:00
z_Windows_NT-586_util.c
Adding some 8-bit atomic operations for future use
2015-03-10 09:03:42 +00:00