83f4c3af02
Partially reverts 0a2be46cfdb698fefcc860a56b47dde0884d5335 as it turned out to cause redundant module rebuilds in multi-process incremental builds. When a module was getting out of date, all compilation processes started at the same time were marking it as `ToBuild`. So each process was building the same module instead of checking if it was built by someone else and using that result. In addition to the work duplication, contention on the same .pcm file wasn't making builds faster. Note that for a single-process build this change would cause redundant module reads and validations. But reading a module is faster than building it and multi-process builds are more common than single-process. So I'm willing to make such a trade-off. rdar://problem/54395127 Reviewed By: dexonsmith Differential Revision: https://reviews.llvm.org/D72860
68 lines
2.1 KiB
C++
68 lines
2.1 KiB
C++
//===- InMemoryModuleCache.cpp - Cache for loaded memory buffers ----------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "clang/Serialization/InMemoryModuleCache.h"
|
|
#include "llvm/Support/MemoryBuffer.h"
|
|
|
|
using namespace clang;
|
|
|
|
llvm::MemoryBuffer &
|
|
InMemoryModuleCache::addPCM(llvm::StringRef Filename,
|
|
std::unique_ptr<llvm::MemoryBuffer> Buffer) {
|
|
auto Insertion = PCMs.insert(std::make_pair(Filename, std::move(Buffer)));
|
|
assert(Insertion.second && "Already has a PCM");
|
|
return *Insertion.first->second.Buffer;
|
|
}
|
|
|
|
llvm::MemoryBuffer &
|
|
InMemoryModuleCache::addFinalPCM(llvm::StringRef Filename,
|
|
std::unique_ptr<llvm::MemoryBuffer> Buffer) {
|
|
auto &PCM = PCMs[Filename];
|
|
assert(!PCM.IsFinal && "Trying to override finalized PCM?");
|
|
assert(!PCM.Buffer && "Already has a non-final PCM");
|
|
PCM.Buffer = std::move(Buffer);
|
|
PCM.IsFinal = true;
|
|
return *PCM.Buffer;
|
|
}
|
|
|
|
llvm::MemoryBuffer *
|
|
InMemoryModuleCache::lookupPCM(llvm::StringRef Filename) const {
|
|
auto I = PCMs.find(Filename);
|
|
if (I == PCMs.end())
|
|
return nullptr;
|
|
return I->second.Buffer.get();
|
|
}
|
|
|
|
bool InMemoryModuleCache::isPCMFinal(llvm::StringRef Filename) const {
|
|
auto I = PCMs.find(Filename);
|
|
if (I == PCMs.end())
|
|
return false;
|
|
return I->second.IsFinal;
|
|
}
|
|
|
|
bool InMemoryModuleCache::tryToRemovePCM(llvm::StringRef Filename) {
|
|
auto I = PCMs.find(Filename);
|
|
assert(I != PCMs.end() && "PCM to remove is unknown...");
|
|
|
|
auto &PCM = I->second;
|
|
if (PCM.IsFinal)
|
|
return true;
|
|
|
|
PCMs.erase(I);
|
|
return false;
|
|
}
|
|
|
|
void InMemoryModuleCache::finalizePCM(llvm::StringRef Filename) {
|
|
auto I = PCMs.find(Filename);
|
|
assert(I != PCMs.end() && "PCM to finalize is unknown...");
|
|
|
|
auto &PCM = I->second;
|
|
assert(PCM.Buffer && "Trying to finalize a dropped PCM...");
|
|
PCM.IsFinal = true;
|
|
}
|