Arthur O'Dwyer 85167fb7c2 [libc++] Further improve the contiguous-iterator story, and fix some bugs.
- Quality-of-implementation: Avoid calling __unwrap_iter in constexpr contexts.
    The user might conceivably write a contiguous iterator where normal iterator
    arithmetic is constexpr-friendly but `std::to_address(it)` isn't.

- Bugfix: When you pass contiguous iterators to `std::copy`, you should get
    back your contiguous iterator type, not a raw pointer. That means that
    libc++ can't `__unwrap_iter` unless it also does `__rewrap_iter`.
    Fortunately, this is implementable.

- Improve test coverage of the new `contiguous_iterator` test iterator.
    This catches the bug described above.

- Tests: Stop testing that we can `std::copy` //into// an `input_iterator`.
    Our test iterators may currently support that, but it seems nonsensical to me.

Differential Revision: https://reviews.llvm.org/D95983
2021-02-05 15:18:04 -05:00

99 lines
3.6 KiB
C++

//===----------------------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
// UNSUPPORTED: clang-8
// <algorithm>
// template<InputIterator InIter, OutputIterator<auto, InIter::reference> OutIter>
// constexpr OutIter // constexpr after C++17
// copy(InIter first, InIter last, OutIter result);
#include <algorithm>
#include <cassert>
#include "test_macros.h"
#include "test_iterators.h"
template <class InIter, class OutIter>
TEST_CONSTEXPR_CXX20 void
test_copy()
{
const unsigned N = 1000;
int ia[N] = {};
for (unsigned i = 0; i < N; ++i)
ia[i] = i;
int ib[N] = {0};
OutIter r = std::copy(InIter(ia), InIter(ia+N), OutIter(ib));
assert(base(r) == ib+N);
for (unsigned i = 0; i < N; ++i)
assert(ia[i] == ib[i]);
}
TEST_CONSTEXPR_CXX20 bool
test()
{
test_copy<input_iterator<const int*>, output_iterator<int*> >();
test_copy<input_iterator<const int*>, forward_iterator<int*> >();
test_copy<input_iterator<const int*>, bidirectional_iterator<int*> >();
test_copy<input_iterator<const int*>, random_access_iterator<int*> >();
test_copy<input_iterator<const int*>, int*>();
test_copy<forward_iterator<const int*>, output_iterator<int*> >();
test_copy<forward_iterator<const int*>, forward_iterator<int*> >();
test_copy<forward_iterator<const int*>, bidirectional_iterator<int*> >();
test_copy<forward_iterator<const int*>, random_access_iterator<int*> >();
test_copy<forward_iterator<const int*>, int*>();
test_copy<bidirectional_iterator<const int*>, output_iterator<int*> >();
test_copy<bidirectional_iterator<const int*>, forward_iterator<int*> >();
test_copy<bidirectional_iterator<const int*>, bidirectional_iterator<int*> >();
test_copy<bidirectional_iterator<const int*>, random_access_iterator<int*> >();
test_copy<bidirectional_iterator<const int*>, int*>();
test_copy<random_access_iterator<const int*>, output_iterator<int*> >();
test_copy<random_access_iterator<const int*>, forward_iterator<int*> >();
test_copy<random_access_iterator<const int*>, bidirectional_iterator<int*> >();
test_copy<random_access_iterator<const int*>, random_access_iterator<int*> >();
test_copy<random_access_iterator<const int*>, int*>();
test_copy<const int*, output_iterator<int*> >();
test_copy<const int*, forward_iterator<int*> >();
test_copy<const int*, bidirectional_iterator<int*> >();
test_copy<const int*, random_access_iterator<int*> >();
test_copy<const int*, int*>();
#if TEST_STD_VER > 17
test_copy<input_iterator<const int*>, contiguous_iterator<int*>>();
test_copy<forward_iterator<const int*>, contiguous_iterator<int*>>();
test_copy<bidirectional_iterator<const int*>, contiguous_iterator<int*>>();
test_copy<random_access_iterator<const int*>, contiguous_iterator<int*>>();
test_copy<const int*, contiguous_iterator<int*>>();
test_copy<contiguous_iterator<const int*>, output_iterator<int*>>();
test_copy<contiguous_iterator<const int*>, forward_iterator<int*>>();
test_copy<contiguous_iterator<const int*>, bidirectional_iterator<int*>>();
test_copy<contiguous_iterator<const int*>, random_access_iterator<int*>>();
test_copy<contiguous_iterator<const int*>, int*>();
#endif
return true;
}
int main(int, char**)
{
test();
#if TEST_STD_VER > 17
static_assert(test());
#endif
return 0;
}