This patch makes the final major change of the RemoveDIs project, changing the default IR output from debug intrinsics to debug records. This is expected to break a large number of tests: every single one that tests for uses or declarations of debug intrinsics and does not explicitly disable writing records. If this patch has broken your downstream tests (or upstream tests on a configuration I wasn't able to run): 1. If you need to immediately unblock a build, pass `--write-experimental-debuginfo=false` to LLVM's option processing for all failing tests (remember to use `-mllvm` for clang/flang to forward arguments to LLVM). 2. For most test failures, the changes are trivial and mechanical, enough that they can be done by script; see the migration guide for a guide on how to do this: https://llvm.org/docs/RemoveDIsDebugInfo.html#test-updates 3. If any tests fail for reasons other than FileCheck check lines that need updating, such as assertion failures, that is most likely a real bug with this patch and should be reported as such. For more information, see the recent PSA: https://discourse.llvm.org/t/psa-ir-output-changing-from-debug-intrinsics-to-debug-records/79578
141 lines
7.9 KiB
LLVM
141 lines
7.9 KiB
LLVM
; RUN: opt -passes=sroa,verify -S %s -o - \
|
|
; RUN: | FileCheck %s --implicit-check-not="call void @llvm.dbg"
|
|
; RUN: opt --try-experimental-debuginfo-iterators -passes=sroa,verify -S %s -o - \
|
|
; RUN: | FileCheck %s --implicit-check-not="call void @llvm.dbg"
|
|
|
|
; Check that the new slices of an alloca and memset intructions get dbg.assign
|
|
; intrinsics with the correct fragment info. Ensure that only the
|
|
; value-expression gets fragment info; that the address-expression remains
|
|
; untouched.
|
|
|
|
;; $ cat test.cpp
|
|
;; void do_something();
|
|
;; struct LargeStruct {
|
|
;; int A, B, C;
|
|
;; int Var;
|
|
;; int D, E, F;
|
|
;; };
|
|
;; int Glob;
|
|
;; bool Cond;
|
|
;; int use(LargeStruct);
|
|
;; int example() {
|
|
;; LargeStruct S = {0};
|
|
;; S.Var = Glob;
|
|
;; use(S);
|
|
;; return S.Var;
|
|
;; }
|
|
;; $ clang test.cpp -Xclang -disable-llvm-passes -O2 -g -c -S -emit-llvm -o - \
|
|
;; | opt -passes=declare-to-assign -S -o -
|
|
|
|
; CHECK: entry:
|
|
; CHECK-NEXT: %S.sroa.0 = alloca { i32, i32, i32 }, align 8, !DIAssignID ![[ID_1:[0-9]+]]
|
|
; CHECK-NEXT: #dbg_assign(i1 undef, ![[VAR:[0-9]+]], !DIExpression(DW_OP_LLVM_fragment, 0, 96), ![[ID_1]], ptr %S.sroa.0, !DIExpression(),
|
|
|
|
; CHECK-NEXT: %S.sroa.4 = alloca { i32, i32, i32 }, align 8, !DIAssignID ![[ID_3:[0-9]+]]
|
|
; CHECK-NEXT: #dbg_assign(i1 undef, ![[VAR]], !DIExpression(DW_OP_LLVM_fragment, 128, 96), ![[ID_3]], ptr %S.sroa.4, !DIExpression(),
|
|
|
|
;; The memset has been split into [0, 96)[96, 128)[128, 224) bit slices. The
|
|
;; memset for the middle slice has been removed.
|
|
; CHECK: call void @llvm.memset{{.*}}(ptr align 8 %S.sroa.0, i8 0, i64 12, i1 false), !dbg !{{.+}}, !DIAssignID ![[ID_4:[0-9]+]]
|
|
; CHECK-NEXT: call void @llvm.memset{{.*}}(ptr align 8 %S.sroa.4, i8 0, i64 12, i1 false), !dbg !{{.+}}, !DIAssignID ![[ID_5:[0-9]+]]
|
|
|
|
; CHECK-NEXT: #dbg_assign(i8 0, ![[VAR]], !DIExpression(DW_OP_LLVM_fragment, 0, 96), ![[ID_4]], ptr %S.sroa.0, !DIExpression(),
|
|
;; This is the one we care about most in this test: check that a memset->store
|
|
;; gets a correct dbg.assign.
|
|
; CHECK-NEXT: #dbg_value(i32 0, ![[VAR]], !DIExpression(DW_OP_LLVM_fragment, 96, 32),
|
|
; CHECK-NEXT: #dbg_assign(i8 0, ![[VAR]], !DIExpression(DW_OP_LLVM_fragment, 128, 96), ![[ID_5]], ptr %S.sroa.4, !DIExpression(),
|
|
|
|
;; The load from global+store becomes a load.
|
|
;; FIXME: In reality it is actually stored again later on.
|
|
; CHECK-NEXT: %0 = load i32, ptr @Glob, align 4, !dbg !{{.+}}
|
|
; CHECK-NEXT: #dbg_value(i32 %0, ![[VAR]], !DIExpression(DW_OP_LLVM_fragment, 96, 32),
|
|
|
|
|
|
target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
|
|
|
|
%struct.LargeStruct = type { i32, i32, i32, i32, i32, i32, i32 }
|
|
|
|
@Glob = dso_local global i32 0, align 4, !dbg !0
|
|
@Cond = dso_local global i8 0, align 1, !dbg !6
|
|
|
|
; Function Attrs: uwtable mustprogress
|
|
define dso_local i32 @_Z7examplev() #0 !dbg !14 {
|
|
entry:
|
|
%S = alloca %struct.LargeStruct, align 4, !DIAssignID !28
|
|
call void @llvm.dbg.assign(metadata i1 undef, metadata !18, metadata !DIExpression(), metadata !28, metadata ptr %S, metadata !DIExpression()), !dbg !29
|
|
%agg.tmp = alloca %struct.LargeStruct, align 8
|
|
%0 = bitcast ptr %S to ptr, !dbg !30
|
|
%1 = bitcast ptr %S to ptr, !dbg !31
|
|
call void @llvm.memset.p0.i64(ptr align 4 %1, i8 0, i64 28, i1 false), !dbg !31, !DIAssignID !32
|
|
call void @llvm.dbg.assign(metadata i8 0, metadata !18, metadata !DIExpression(), metadata !32, metadata ptr %1, metadata !DIExpression()), !dbg !31
|
|
%2 = load i32, ptr @Glob, align 4, !dbg !33
|
|
%Var = getelementptr inbounds %struct.LargeStruct, ptr %S, i32 0, i32 3, !dbg !38
|
|
store i32 %2, ptr %Var, align 4, !dbg !39, !DIAssignID !42
|
|
call void @llvm.dbg.assign(metadata i32 %2, metadata !18, metadata !DIExpression(DW_OP_LLVM_fragment, 96, 32), metadata !42, metadata ptr %Var, metadata !DIExpression()), !dbg !39
|
|
%3 = bitcast ptr %agg.tmp to ptr, !dbg !43
|
|
%4 = bitcast ptr %S to ptr, !dbg !43
|
|
call void @llvm.memcpy.p0.p0.i64(ptr align 4 %3, ptr align 4 %4, i64 28, i1 false), !dbg !43
|
|
%call = call i32 @_Z3use11LargeStruct(ptr byval(%struct.LargeStruct) align 8 %agg.tmp), !dbg !45
|
|
%Var1 = getelementptr inbounds %struct.LargeStruct, ptr %S, i32 0, i32 3, !dbg !46
|
|
%5 = load i32, ptr %Var1, align 4, !dbg !46
|
|
%6 = bitcast ptr %S to ptr, !dbg !47
|
|
ret i32 %5, !dbg !48
|
|
}
|
|
|
|
|
|
declare void @llvm.memset.p0.i64(ptr nocapture writeonly, i8, i64, i1 immarg) #2
|
|
declare !dbg !49 dso_local i32 @_Z3use11LargeStruct(ptr byval(%struct.LargeStruct) align 8) #3
|
|
declare void @llvm.memcpy.p0.p0.i64(ptr noalias nocapture writeonly, ptr noalias nocapture readonly, i64, i1 immarg) #1
|
|
declare void @llvm.dbg.assign(metadata, metadata, metadata, metadata, metadata, metadata) #4
|
|
|
|
!llvm.dbg.cu = !{!2}
|
|
!llvm.module.flags = !{!10, !11, !12, !1000}
|
|
!llvm.ident = !{!13}
|
|
|
|
!0 = !DIGlobalVariableExpression(var: !1, expr: !DIExpression())
|
|
!1 = distinct !DIGlobalVariable(name: "Glob", scope: !2, file: !3, line: 7, type: !9, isLocal: false, isDefinition: true)
|
|
!2 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus_14, file: !3, producer: "clang version 12.0.0", isOptimized: true, runtimeVersion: 0, emissionKind: FullDebug, enums: !4, globals: !5, splitDebugInlining: false, nameTableKind: None)
|
|
!3 = !DIFile(filename: "test.cpp", directory: "/")
|
|
!4 = !{}
|
|
!5 = !{!0, !6}
|
|
!6 = !DIGlobalVariableExpression(var: !7, expr: !DIExpression())
|
|
!7 = distinct !DIGlobalVariable(name: "Cond", scope: !2, file: !3, line: 8, type: !8, isLocal: false, isDefinition: true)
|
|
!8 = !DIBasicType(name: "bool", size: 8, encoding: DW_ATE_boolean)
|
|
!9 = !DIBasicType(name: "int", size: 32, encoding: DW_ATE_signed)
|
|
!10 = !{i32 7, !"Dwarf Version", i32 4}
|
|
!11 = !{i32 2, !"Debug Info Version", i32 3}
|
|
!12 = !{i32 1, !"wchar_size", i32 4}
|
|
!13 = !{!"clang version 12.0.0"}
|
|
!14 = distinct !DISubprogram(name: "example", linkageName: "_Z7examplev", scope: !3, file: !3, line: 10, type: !15, scopeLine: 10, flags: DIFlagPrototyped | DIFlagAllCallsDescribed, spFlags: DISPFlagDefinition | DISPFlagOptimized, unit: !2, retainedNodes: !17)
|
|
!15 = !DISubroutineType(types: !16)
|
|
!16 = !{!9}
|
|
!17 = !{!18}
|
|
!18 = !DILocalVariable(name: "S", scope: !14, file: !3, line: 11, type: !19)
|
|
!19 = distinct !DICompositeType(tag: DW_TAG_structure_type, name: "LargeStruct", file: !3, line: 2, size: 224, flags: DIFlagTypePassByValue, elements: !20, identifier: "_ZTS11LargeStruct")
|
|
!20 = !{!21, !22, !23, !24, !25, !26, !27}
|
|
!21 = !DIDerivedType(tag: DW_TAG_member, name: "A", scope: !19, file: !3, line: 3, baseType: !9, size: 32)
|
|
!22 = !DIDerivedType(tag: DW_TAG_member, name: "B", scope: !19, file: !3, line: 3, baseType: !9, size: 32, offset: 32)
|
|
!23 = !DIDerivedType(tag: DW_TAG_member, name: "C", scope: !19, file: !3, line: 3, baseType: !9, size: 32, offset: 64)
|
|
!24 = !DIDerivedType(tag: DW_TAG_member, name: "Var", scope: !19, file: !3, line: 4, baseType: !9, size: 32, offset: 96)
|
|
!25 = !DIDerivedType(tag: DW_TAG_member, name: "D", scope: !19, file: !3, line: 5, baseType: !9, size: 32, offset: 128)
|
|
!26 = !DIDerivedType(tag: DW_TAG_member, name: "E", scope: !19, file: !3, line: 5, baseType: !9, size: 32, offset: 160)
|
|
!27 = !DIDerivedType(tag: DW_TAG_member, name: "F", scope: !19, file: !3, line: 5, baseType: !9, size: 32, offset: 192)
|
|
!28 = distinct !DIAssignID()
|
|
!29 = !DILocation(line: 0, scope: !14)
|
|
!30 = !DILocation(line: 11, column: 3, scope: !14)
|
|
!31 = !DILocation(line: 11, column: 15, scope: !14)
|
|
!32 = distinct !DIAssignID()
|
|
!33 = !DILocation(line: 12, column: 11, scope: !14)
|
|
!38 = !DILocation(line: 12, column: 5, scope: !14)
|
|
!39 = !DILocation(line: 12, column: 9, scope: !14)
|
|
!42 = distinct !DIAssignID()
|
|
!43 = !DILocation(line: 13, column: 7, scope: !14)
|
|
!45 = !DILocation(line: 13, column: 3, scope: !14)
|
|
!46 = !DILocation(line: 14, column: 12, scope: !14)
|
|
!47 = !DILocation(line: 15, column: 1, scope: !14)
|
|
!48 = !DILocation(line: 14, column: 3, scope: !14)
|
|
!49 = !DISubprogram(name: "use", linkageName: "_Z3use11LargeStruct", scope: !3, file: !3, line: 9, type: !50, flags: DIFlagPrototyped, spFlags: DISPFlagOptimized, retainedNodes: !4)
|
|
!50 = !DISubroutineType(types: !51)
|
|
!51 = !{!9, !19}
|
|
!1000 = !{i32 7, !"debug-info-assignment-tracking", i1 true}
|