ab2d3ce47d
Applied fixes enabled by the LLVM's .clang-tidy configs. Reverted files where
fixes introduced compile errors:
clang-tools-extra/clang-tidy/hicpp/NoAssemblerCheck.cpp
clang-tools-extra/clang-tidy/misc/ThrowByValueCatchByReferenceCheck.cpp
$ clang-tools-extra/clang-tidy/tool/run-clang-tidy.py -fix clang-tools-extra/clang-tidy/
Enabled checks:
llvm-else-after-return
llvm-header-guard
llvm-include-order
llvm-namespace-comment
llvm-prefer-isa-or-dyn-cast-in-conditionals
llvm-prefer-register-over-unsigned
llvm-qualified-auto
llvm-twine-local
misc-definitions-in-headers
misc-misplaced-const
misc-new-delete-overloads
misc-no-recursion
misc-non-copyable-objects
misc-redundant-expression
misc-static-assert
misc-throw-by-value-catch-by-reference
misc-unconventional-assign-operator
misc-uniqueptr-reset-release
misc-unused-alias-decls
misc-unused-using-decls
readability-identifier-naming
Reviewed By: aaron.ballman
Differential Revision: https://reviews.llvm.org/D95614
75 lines
2.5 KiB
C++
75 lines
2.5 KiB
C++
//===--- BadSignalToKillThreadCheck.cpp - clang-tidy ---------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "BadSignalToKillThreadCheck.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
#include "clang/Lex/Preprocessor.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang {
|
|
namespace tidy {
|
|
namespace bugprone {
|
|
|
|
void BadSignalToKillThreadCheck::registerMatchers(MatchFinder *Finder) {
|
|
Finder->addMatcher(
|
|
callExpr(allOf(callee(functionDecl(hasName("::pthread_kill"))),
|
|
argumentCountIs(2)),
|
|
hasArgument(1, integerLiteral().bind("integer-literal")))
|
|
.bind("thread-kill"),
|
|
this);
|
|
}
|
|
|
|
static Preprocessor *PP;
|
|
|
|
void BadSignalToKillThreadCheck::check(const MatchFinder::MatchResult &Result) {
|
|
const auto IsSigterm = [](const auto &KeyValue) -> bool {
|
|
return KeyValue.first->getName() == "SIGTERM" &&
|
|
KeyValue.first->hasMacroDefinition();
|
|
};
|
|
const auto TryExpandAsInteger =
|
|
[](Preprocessor::macro_iterator It) -> Optional<unsigned> {
|
|
if (It == PP->macro_end())
|
|
return llvm::None;
|
|
const MacroInfo *MI = PP->getMacroInfo(It->first);
|
|
const Token &T = MI->tokens().back();
|
|
if (!T.isLiteral() || !T.getLiteralData())
|
|
return llvm::None;
|
|
StringRef ValueStr = StringRef(T.getLiteralData(), T.getLength());
|
|
|
|
llvm::APInt IntValue;
|
|
constexpr unsigned AutoSenseRadix = 0;
|
|
if (ValueStr.getAsInteger(AutoSenseRadix, IntValue))
|
|
return llvm::None;
|
|
return IntValue.getZExtValue();
|
|
};
|
|
|
|
const auto SigtermMacro = llvm::find_if(PP->macros(), IsSigterm);
|
|
|
|
if (!SigtermValue && !(SigtermValue = TryExpandAsInteger(SigtermMacro)))
|
|
return;
|
|
|
|
const auto *MatchedExpr = Result.Nodes.getNodeAs<Expr>("thread-kill");
|
|
const auto *MatchedIntLiteral =
|
|
Result.Nodes.getNodeAs<IntegerLiteral>("integer-literal");
|
|
if (MatchedIntLiteral->getValue() == *SigtermValue) {
|
|
diag(MatchedExpr->getBeginLoc(),
|
|
"thread should not be terminated by raising the 'SIGTERM' signal");
|
|
}
|
|
}
|
|
|
|
void BadSignalToKillThreadCheck::registerPPCallbacks(
|
|
const SourceManager &SM, Preprocessor *Pp, Preprocessor *ModuleExpanderPP) {
|
|
PP = Pp;
|
|
}
|
|
|
|
} // namespace bugprone
|
|
} // namespace tidy
|
|
} // namespace clang
|