e40a742a50
Summary: Modifies all checks that are language version dependent to use `isLanguageVersionSupported` Reviewers: jdoerfert, lebedev.ri, aaron.ballman, gribozavr2, Eugene.Zelenko Reviewed By: gribozavr2 Subscribers: wuzish, nemanjai, xazax.hun, hiraditya, kbarton, steven_wu, dexonsmith, arphaman, lebedev.ri, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D75340
52 lines
2.1 KiB
C++
52 lines
2.1 KiB
C++
//===--- MoveForwardingReferenceCheck.h - clang-tidy ----------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_BUGPRONE_MOVEFORWARDINGREFERENCECHECK_H
|
|
#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_BUGPRONE_MOVEFORWARDINGREFERENCECHECK_H
|
|
|
|
#include "../ClangTidyCheck.h"
|
|
|
|
namespace clang {
|
|
namespace tidy {
|
|
namespace bugprone {
|
|
|
|
/// The check warns if std::move is applied to a forwarding reference (i.e. an
|
|
/// rvalue reference of a function template argument type).
|
|
///
|
|
/// If a developer is unaware of the special rules for template argument
|
|
/// deduction on forwarding references, it will seem reasonable to apply
|
|
/// std::move to the forwarding reference, in the same way that this would be
|
|
/// done for a "normal" rvalue reference.
|
|
///
|
|
/// This has a consequence that is usually unwanted and possibly surprising: if
|
|
/// the function that takes the forwarding reference as its parameter is called
|
|
/// with an lvalue, that lvalue will be moved from (and hence placed into an
|
|
/// indeterminate state) even though no std::move was applied to the lvalue at
|
|
/// the call site.
|
|
//
|
|
/// The check suggests replacing the std::move with a std::forward.
|
|
///
|
|
/// For the user-facing documentation see:
|
|
/// http://clang.llvm.org/extra/clang-tidy/checks/bugprone-move-forwarding-reference.html
|
|
class MoveForwardingReferenceCheck : public ClangTidyCheck {
|
|
public:
|
|
MoveForwardingReferenceCheck(StringRef Name, ClangTidyContext *Context)
|
|
: ClangTidyCheck(Name, Context) {}
|
|
bool isLanguageVersionSupported(const LangOptions &LangOpts) const override {
|
|
return LangOpts.CPlusPlus11;
|
|
}
|
|
void registerMatchers(ast_matchers::MatchFinder *Finder) override;
|
|
void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
|
|
};
|
|
|
|
} // namespace bugprone
|
|
} // namespace tidy
|
|
} // namespace clang
|
|
|
|
#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_BUGPRONE_MOVEFORWARDINGREFERENCECHECK_H
|