JF Bastien 2df59c5068 Support tests in freestanding
Summary:
Freestanding is *weird*. The standard allows it to differ in a bunch of odd
manners from regular C++, and the committee would like to improve that
situation. I'd like to make libc++ behave better with what freestanding should
be, so that it can be a tool we use in improving the standard. To do that we
need to try stuff out, both with "freestanding the language mode" and
"freestanding the library subset".

Let's start with the super basic: run the libc++ tests in freestanding, using
clang as the compiler, and see what works. The easiest hack to do this:

In utils/libcxx/test/config.py add:

  self.cxx.compile_flags += ['-ffreestanding']

Run the tests and they all fail.

Why? Because in freestanding `main` isn't special. This "not special" property
has two effects: main doesn't get mangled, and main isn't allowed to omit its
`return` statement. The first means main gets mangled and the linker can't
create a valid executable for us to test. The second means we spew out warnings
(ew) and the compiler doesn't insert the `return` we omitted, and main just
falls of the end and does whatever undefined behavior (if you're luck, ud2
leading to non-zero return code).

Let's start my work with the basics. This patch changes all libc++ tests to
declare `main` as `int main(int, char**` so it mangles consistently (enabling us
to declare another `extern "C"` main for freestanding which calls the mangled
one), and adds `return 0;` to all places where it was missing. This touches 6124
files, and I apologize.

The former was done with The Magic Of Sed.

The later was done with a (not quite correct but decent) clang tool:

  https://gist.github.com/jfbastien/793819ff360baa845483dde81170feed

This works for most tests, though I did have to adjust a few places when e.g.
the test runs with `-x c`, macros are used for main (such as for the filesystem
tests), etc.

Once this is in we can create a freestanding bot which will prevent further
regressions. After that, we can start the real work of supporting C++
freestanding fairly well in libc++.

<rdar://problem/47754795>

Reviewers: ldionne, mclow.lists, EricWF

Subscribers: christof, jkorous, dexonsmith, arphaman, miyuki, libcxx-commits

Differential Revision: https://reviews.llvm.org/D57624

llvm-svn: 353086
2019-02-04 20:31:13 +00:00

123 lines
3.4 KiB
C++

//===----------------------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
// <string_view>
// constexpr basic_string_view substr(size_type pos = 0, size_type n = npos) const;
// Throws: out_of_range if pos > size().
// Effects: Determines the effective length rlen of the string to reference as the smaller of n and size() - pos.
// Returns: basic_string_view(data()+pos, rlen).
#include <string_view>
#include <algorithm>
#include <stdexcept>
#include <cassert>
#include "test_macros.h"
template<typename CharT>
void test1(std::basic_string_view<CharT> sv, size_t n, size_t pos) {
std::basic_string_view<CharT> sv1;
#ifdef TEST_HAS_NO_EXCEPTIONS
if (pos > sv.size())
return ; // would throw if exceptions were enabled
sv1 = sv.substr(pos, n);
#else
try {
sv1 = sv.substr(pos, n);
assert(pos <= sv.size());
}
catch (const std::out_of_range&) {
assert(pos > sv.size());
return ;
}
#endif
const size_t rlen = std::min(n, sv.size() - pos);
assert (sv1.size() == rlen);
for (size_t i = 0; i < rlen; ++i)
assert(sv[pos+i] == sv1[i]);
}
template<typename CharT>
void test ( const CharT *s ) {
typedef std::basic_string_view<CharT> string_view_t;
string_view_t sv1 ( s );
test1(sv1, 0, 0);
test1(sv1, 1, 0);
test1(sv1, 20, 0);
test1(sv1, sv1.size(), 0);
test1(sv1, 0, 3);
test1(sv1, 2, 3);
test1(sv1, 100, 3);
test1(sv1, 0, string_view_t::npos);
test1(sv1, 2, string_view_t::npos);
test1(sv1, sv1.size(), string_view_t::npos);
test1(sv1, sv1.size() + 1, 0);
test1(sv1, sv1.size() + 1, 1);
test1(sv1, sv1.size() + 1, string_view_t::npos);
}
int main(int, char**) {
test ( "ABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDE" );
test ( "ABCDE");
test ( "a" );
test ( "" );
test ( L"ABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDE" );
test ( L"ABCDE" );
test ( L"a" );
test ( L"" );
#if TEST_STD_VER >= 11
test ( u"ABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDE" );
test ( u"ABCDE" );
test ( u"a" );
test ( u"" );
test ( U"ABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDEABCDE" );
test ( U"ABCDE" );
test ( U"a" );
test ( U"" );
#endif
#if TEST_STD_VER > 11
{
constexpr std::string_view sv1 { "ABCDE", 5 };
{
constexpr std::string_view sv2 = sv1.substr ( 0, 3 );
static_assert ( sv2.size() == 3, "" );
static_assert ( sv2[0] == 'A', "" );
static_assert ( sv2[1] == 'B', "" );
static_assert ( sv2[2] == 'C', "" );
}
{
constexpr std::string_view sv2 = sv1.substr ( 3, 0 );
static_assert ( sv2.size() == 0, "" );
}
{
constexpr std::string_view sv2 = sv1.substr ( 3, 3 );
static_assert ( sv2.size() == 2, "" );
static_assert ( sv2[0] == 'D', "" );
static_assert ( sv2[1] == 'E', "" );
}
}
#endif
return 0;
}