41d0b20cc9
Change `ThreadPlanStack::PopPlan` and `::DiscardPlan` to not do the following: 1. Move the last plan, leaving a moved `ThreadPlanSP` in the plans vector 2. Operate on the last plan 3. Pop the last plan off the plans vector This leaves a period of time where the last element in the plans vector has been moved. I am not sure what, if any, guarantees there are when doing this, but it seems like it would/could leave a null `ThreadPlanSP` in the container. There are asserts in place to prevent empty/null `ThreadPlanSP` instances from being pushed on to the stack, and so this could break that invariant during multithreaded access to the thread plan stack. An open question is whether this use of `std::move` was the result of a measure performance problem. Differential Revision: https://reviews.llvm.org/D106171
118 lines
3.8 KiB
C++
118 lines
3.8 KiB
C++
//===-- ThreadPlanCallUserExpression.cpp ----------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "lldb/Target/ThreadPlanCallUserExpression.h"
|
|
|
|
|
|
#include "lldb/Breakpoint/Breakpoint.h"
|
|
#include "lldb/Breakpoint/BreakpointLocation.h"
|
|
#include "lldb/Core/Address.h"
|
|
#include "lldb/Expression/DiagnosticManager.h"
|
|
#include "lldb/Expression/DynamicCheckerFunctions.h"
|
|
#include "lldb/Expression/UserExpression.h"
|
|
#include "lldb/Host/HostInfo.h"
|
|
#include "lldb/Target/LanguageRuntime.h"
|
|
#include "lldb/Target/Process.h"
|
|
#include "lldb/Target/RegisterContext.h"
|
|
#include "lldb/Target/StopInfo.h"
|
|
#include "lldb/Target/Target.h"
|
|
#include "lldb/Target/Thread.h"
|
|
#include "lldb/Target/ThreadPlanRunToAddress.h"
|
|
#include "lldb/Utility/Log.h"
|
|
#include "lldb/Utility/Stream.h"
|
|
|
|
using namespace lldb;
|
|
using namespace lldb_private;
|
|
|
|
// ThreadPlanCallUserExpression: Plan to call a single function
|
|
|
|
ThreadPlanCallUserExpression::ThreadPlanCallUserExpression(
|
|
Thread &thread, Address &function, llvm::ArrayRef<lldb::addr_t> args,
|
|
const EvaluateExpressionOptions &options,
|
|
lldb::UserExpressionSP &user_expression_sp)
|
|
: ThreadPlanCallFunction(thread, function, CompilerType(), args, options),
|
|
m_user_expression_sp(user_expression_sp) {
|
|
// User expressions are generally "User generated" so we should set them up
|
|
// to stop when done.
|
|
SetIsMasterPlan(true);
|
|
SetOkayToDiscard(false);
|
|
}
|
|
|
|
ThreadPlanCallUserExpression::~ThreadPlanCallUserExpression() = default;
|
|
|
|
void ThreadPlanCallUserExpression::GetDescription(
|
|
Stream *s, lldb::DescriptionLevel level) {
|
|
if (level == eDescriptionLevelBrief)
|
|
s->Printf("User Expression thread plan");
|
|
else
|
|
ThreadPlanCallFunction::GetDescription(s, level);
|
|
}
|
|
|
|
void ThreadPlanCallUserExpression::DidPush() {
|
|
ThreadPlanCallFunction::DidPush();
|
|
if (m_user_expression_sp)
|
|
m_user_expression_sp->WillStartExecuting();
|
|
}
|
|
|
|
void ThreadPlanCallUserExpression::DidPop() {
|
|
ThreadPlanCallFunction::DidPop();
|
|
if (m_user_expression_sp)
|
|
m_user_expression_sp.reset();
|
|
}
|
|
|
|
bool ThreadPlanCallUserExpression::MischiefManaged() {
|
|
Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_STEP));
|
|
|
|
if (IsPlanComplete()) {
|
|
LLDB_LOGF(log, "ThreadPlanCallFunction(%p): Completed call function plan.",
|
|
static_cast<void *>(this));
|
|
|
|
if (m_manage_materialization && PlanSucceeded() && m_user_expression_sp) {
|
|
lldb::addr_t function_stack_top;
|
|
lldb::addr_t function_stack_bottom;
|
|
lldb::addr_t function_stack_pointer = GetFunctionStackPointer();
|
|
|
|
function_stack_bottom = function_stack_pointer - HostInfo::GetPageSize();
|
|
function_stack_top = function_stack_pointer;
|
|
|
|
DiagnosticManager diagnostics;
|
|
|
|
ExecutionContext exe_ctx(GetThread());
|
|
|
|
m_user_expression_sp->FinalizeJITExecution(
|
|
diagnostics, exe_ctx, m_result_var_sp, function_stack_bottom,
|
|
function_stack_top);
|
|
}
|
|
|
|
ThreadPlan::MischiefManaged();
|
|
return true;
|
|
} else {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
StopInfoSP ThreadPlanCallUserExpression::GetRealStopInfo() {
|
|
StopInfoSP stop_info_sp = ThreadPlanCallFunction::GetRealStopInfo();
|
|
|
|
if (stop_info_sp) {
|
|
lldb::addr_t addr = GetStopAddress();
|
|
DynamicCheckerFunctions *checkers = m_process.GetDynamicCheckers();
|
|
StreamString s;
|
|
|
|
if (checkers && checkers->DoCheckersExplainStop(addr, s))
|
|
stop_info_sp->SetDescription(s.GetData());
|
|
}
|
|
|
|
return stop_info_sp;
|
|
}
|
|
|
|
void ThreadPlanCallUserExpression::DoTakedown(bool success) {
|
|
ThreadPlanCallFunction::DoTakedown(success);
|
|
m_user_expression_sp->DidFinishExecuting();
|
|
}
|