8340fbb9c7
Summary: Since commit 7b3ef05a37fef2f805d31f498d30198ddeeb1a0c the Objective-C++ plugin is dead code. That commit added Objective-C++ to the list of languages for which `Language::LanguageIsCPlusPlus` returns true. As the C++ language plugin also uses that method to figure out if it is responsible for a given language, the C++ plugin since then also became the plugin that we found when looking for a language plugin for Objective-C++. The only real fallout from that is that the source highlighting for Objective-C++ files never worked as we always found the C++ plugin which refuses to highlight files with Objective-C++ extensions. This patch just adds a special exception for Objective-C++ to the list of languages that are governed by the C++ plugin. Also adds a test that makes sure that we find the right plugin for all C language types and that the highlighting for `.mm` (Objective-C++) and `.m` (Objective-C) files works. I didn't revert 7b3ef05a37fef2f805d31f498d30198ddeeb1a0c as it does make sense to return true for Objective-C++ from `Language::LanguageIsCPlusPlus` (e.g., we currently check if we care about ODR violations by doing `if (Language::LanguageIsCPlusPlus(...))` and this should also work for Objective-C++). Fixes rdar://64420183 Reviewers: aprantl Reviewed By: aprantl Subscribers: mgorny, abidh, JDevlieghere Differential Revision: https://reviews.llvm.org/D82109
47 lines
1.9 KiB
C++
47 lines
1.9 KiB
C++
//===-- CLanguagesTest.cpp ------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "Plugins/Language/CPlusPlus/CPlusPlusLanguage.h"
|
|
#include "Plugins/Language/ObjC/ObjCLanguage.h"
|
|
#include "Plugins/Language/ObjCPlusPlus/ObjCPlusPlusLanguage.h"
|
|
#include "TestingSupport/SubsystemRAII.h"
|
|
#include "lldb/lldb-enumerations.h"
|
|
|
|
#include "gmock/gmock.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
using namespace lldb_private;
|
|
|
|
/// Returns the name of the LLDB plugin for the given language or a null
|
|
/// ConstString if there is no fitting plugin.
|
|
static ConstString GetPluginName(lldb::LanguageType language) {
|
|
Language *language_plugin = Language::FindPlugin(language);
|
|
if (language_plugin)
|
|
return language_plugin->GetPluginName();
|
|
return ConstString();
|
|
}
|
|
|
|
TEST(CLanguages, LookupCLanguagesByLanguageType) {
|
|
SubsystemRAII<CPlusPlusLanguage, ObjCPlusPlusLanguage, ObjCLanguage> langs;
|
|
|
|
// There is no plugin to find for C.
|
|
EXPECT_EQ(Language::FindPlugin(lldb::eLanguageTypeC), nullptr);
|
|
EXPECT_EQ(Language::FindPlugin(lldb::eLanguageTypeC89), nullptr);
|
|
EXPECT_EQ(Language::FindPlugin(lldb::eLanguageTypeC99), nullptr);
|
|
EXPECT_EQ(Language::FindPlugin(lldb::eLanguageTypeC11), nullptr);
|
|
|
|
EXPECT_EQ(GetPluginName(lldb::eLanguageTypeC_plus_plus), "cplusplus");
|
|
EXPECT_EQ(GetPluginName(lldb::eLanguageTypeC_plus_plus_03), "cplusplus");
|
|
EXPECT_EQ(GetPluginName(lldb::eLanguageTypeC_plus_plus_11), "cplusplus");
|
|
EXPECT_EQ(GetPluginName(lldb::eLanguageTypeC_plus_plus_14), "cplusplus");
|
|
|
|
EXPECT_EQ(GetPluginName(lldb::eLanguageTypeObjC), "objc");
|
|
|
|
EXPECT_EQ(GetPluginName(lldb::eLanguageTypeObjC_plus_plus), "objcplusplus");
|
|
}
|