1b7c9eae6d
Summary: Currently the frame recognizers are stored in a global list (the list in the StackFrameRecognizersManagerImpl singleton to be precise). All commands and plugins that modify the list are just modifying that global list of recognizers which is shared by all Target and Debugger instances. This is clearly against the idea of LLDB being usable as a library and it also leads to some very obscure errors as now multiple tests are sharing the used frame recognizers. For example D83400 is currently failing as it reorders some test_ functions which permanently changes the frame recognizers of all debuggers/targets. As all frame recognizers are also initialized in a 'once' guard, it's also impossible to every restore back the original frame recognizers once they are deleted in a process. This patch just moves the frame recognizers into the current target. This seems the way everyone assumes the system works as for example the assert frame recognizers is using the current target to find the function/so-name to look for (which only works if the recognizers are stored in the target). Reviewers: jingham, mib Reviewed By: jingham, mib Subscribers: MrHate, JDevlieghere Differential Revision: https://reviews.llvm.org/D83757
82 lines
2.6 KiB
C++
82 lines
2.6 KiB
C++
//===-- StackFrameRecognizerTest.cpp --------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "lldb/Target/StackFrameRecognizer.h"
|
|
#include "Plugins/Platform/Linux/PlatformLinux.h"
|
|
#include "lldb/Core/Debugger.h"
|
|
#include "lldb/Host/FileSystem.h"
|
|
#include "lldb/Host/HostInfo.h"
|
|
#include "lldb/Utility/Reproducer.h"
|
|
#include "lldb/lldb-enumerations.h"
|
|
#include "lldb/lldb-forward.h"
|
|
#include "lldb/lldb-private-enumerations.h"
|
|
#include "lldb/lldb-private.h"
|
|
#include "llvm/Support/FormatVariadic.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
using namespace lldb_private;
|
|
using namespace lldb_private::repro;
|
|
using namespace lldb;
|
|
|
|
namespace {
|
|
class StackFrameRecognizerTest : public ::testing::Test {
|
|
public:
|
|
void SetUp() override {
|
|
llvm::cantFail(Reproducer::Initialize(ReproducerMode::Off, llvm::None));
|
|
FileSystem::Initialize();
|
|
HostInfo::Initialize();
|
|
|
|
// Pretend Linux is the host platform.
|
|
platform_linux::PlatformLinux::Initialize();
|
|
ArchSpec arch("powerpc64-pc-linux");
|
|
Platform::SetHostPlatform(
|
|
platform_linux::PlatformLinux::CreateInstance(true, &arch));
|
|
}
|
|
|
|
void TearDown() override {
|
|
platform_linux::PlatformLinux::Terminate();
|
|
HostInfo::Terminate();
|
|
FileSystem::Terminate();
|
|
Reproducer::Terminate();
|
|
}
|
|
};
|
|
|
|
class DummyStackFrameRecognizer : public StackFrameRecognizer {
|
|
public:
|
|
std::string GetName() override { return "Dummy StackFrame Recognizer"; }
|
|
};
|
|
|
|
void RegisterDummyStackFrameRecognizer(StackFrameRecognizerManager &manager) {
|
|
RegularExpressionSP module_regex_sp = nullptr;
|
|
RegularExpressionSP symbol_regex_sp(new RegularExpression("boom"));
|
|
|
|
StackFrameRecognizerSP dummy_recognizer_sp(new DummyStackFrameRecognizer());
|
|
|
|
manager.AddRecognizer(dummy_recognizer_sp, module_regex_sp, symbol_regex_sp,
|
|
false);
|
|
}
|
|
|
|
} // namespace
|
|
|
|
TEST_F(StackFrameRecognizerTest, NullModuleRegex) {
|
|
DebuggerSP debugger_sp = Debugger::CreateInstance();
|
|
ASSERT_TRUE(debugger_sp);
|
|
|
|
StackFrameRecognizerManager manager;
|
|
|
|
RegisterDummyStackFrameRecognizer(manager);
|
|
|
|
bool any_printed = false;
|
|
manager.ForEach([&any_printed](uint32_t recognizer_id, std::string name,
|
|
std::string function,
|
|
llvm::ArrayRef<ConstString> symbols,
|
|
bool regexp) { any_printed = true; });
|
|
|
|
EXPECT_TRUE(any_printed);
|
|
}
|