The exit code for -### is inconsistent. Unrecognized options lead to exit code 1, as expected. However, most others errors (including invalid option value) lead to exit code 0, differing from GCC and most utilities. This is a longstanding quirk of -###, and we didn't fix it because many driver tests need adjustment. Change -### to be similar to -fdriver-only -v and exit with code 1. This requires fixing many driver tests, but the end result gives us stronger tests. * Existing `RUN: %clang -### ...` tests usually don't use `CHECK-NOT: error:` or `--implicit-check-not=error:`. If a change introduces an error, such a change usually cannot be detected. * Many folks contributing new tests don't know `-fdriver-only -v`. To test no driver error/warning for new tests, they can use the familiar `-### -Werror` instead of `-fdriver-only -v -Werror`. An incomplete list of prerequisite test improvement: * 2f79bb10461d114783a1548201928549ace09755: add -nogpulib to some AMDGPU tests * 9155e517e6e1cda474d0d0fa82f71696c325bc10: add --cuda-path= (test w/ and w/o /usr/local/cuda) * 80765ede5bbcca1364c2d4ae06127011eaba6389: -mcpu=native may return either 0 or 1, depending on whether `--target=` specifies a native target * abae53f43f0d1da8d8e421f4a628d7ec64d6e365: fix -fuse-ld=lld misuses (test w/o and w/o /usr/local/bin/ld.lld) * ab68df505e5bb8808ee44f53044b50ca7575098e: add -resource-dir= and -fvisibility=hidden to some -fsanitize=cfi tests * d5ca1602f64114f612ad5630f04e4aa90591c78d: --rtlib=platform without --unwindlib= may fail if CLANG_DEFAULT_UNWINDLIB=unwindlib Reviewed By: jhuber6, yaxunl, dblaikie Differential Revision: https://reviews.llvm.org/D156363
86 lines
3.2 KiB
Plaintext
86 lines
3.2 KiB
Plaintext
// REQUIRES: amdgpu-registered-target
|
|
|
|
// Check bundle ID for code object v2.
|
|
|
|
// RUN: not %clang -### --target=x86_64-linux-gnu \
|
|
// RUN: -mcode-object-version=2 \
|
|
// RUN: --offload-arch=gfx906 --rocm-path=%S/Inputs/rocm \
|
|
// RUN: %s 2>&1 | FileCheck -check-prefix=V2 %s
|
|
|
|
// V2: "-mllvm" "--amdhsa-code-object-version=2"
|
|
// V2: "-targets=host-x86_64-unknown-linux,hip-amdgcn-amd-amdhsa--gfx906"
|
|
|
|
// Check bundle ID for code object v3.
|
|
|
|
// RUN: not %clang -### --target=x86_64-linux-gnu \
|
|
// RUN: -mcode-object-version=3 \
|
|
// RUN: --offload-arch=gfx906 --rocm-path=%S/Inputs/rocm \
|
|
// RUN: %s 2>&1 | FileCheck -check-prefix=V3 %s
|
|
|
|
// RUN: not %clang -### --target=x86_64-linux-gnu \
|
|
// RUN: -mcode-object-version=4 -mcode-object-version=3 \
|
|
// RUN: --offload-arch=gfx906 --rocm-path=%S/Inputs/rocm \
|
|
// RUN: %s 2>&1 | FileCheck -check-prefix=V3 %s
|
|
|
|
// V3: "-mcode-object-version=3"
|
|
// V3: "-mllvm" "--amdhsa-code-object-version=3"
|
|
// V3: "-targets=host-x86_64-unknown-linux,hip-amdgcn-amd-amdhsa--gfx906"
|
|
|
|
// Check bundle ID for code object version 4.
|
|
|
|
// RUN: not %clang -### --target=x86_64-linux-gnu \
|
|
// RUN: -mcode-object-version=4 \
|
|
// RUN: --offload-arch=gfx906 --rocm-path=%S/Inputs/rocm \
|
|
// RUN: %s 2>&1 | FileCheck -check-prefix=V4 %s
|
|
|
|
// V4: "-mcode-object-version=4"
|
|
// V4: "-mllvm" "--amdhsa-code-object-version=4"
|
|
// V4: "-targets=host-x86_64-unknown-linux,hipv4-amdgcn-amd-amdhsa--gfx906"
|
|
|
|
// Check bundle ID for code object version 5.
|
|
|
|
// RUN: not %clang -### --target=x86_64-linux-gnu \
|
|
// RUN: -mcode-object-version=5 \
|
|
// RUN: --offload-arch=gfx906 --rocm-path=%S/Inputs/rocm \
|
|
// RUN: %s 2>&1 | FileCheck -check-prefix=V5 %s
|
|
|
|
// V5: "-mcode-object-version=5"
|
|
// V5: "-mllvm" "--amdhsa-code-object-version=5"
|
|
// V5: "-targets=host-x86_64-unknown-linux,hipv4-amdgcn-amd-amdhsa--gfx906"
|
|
|
|
// Check bundle ID for code object version default
|
|
|
|
// RUN: %clang -### --target=x86_64-linux-gnu \
|
|
// RUN: --offload-arch=gfx906 -nogpuinc -nogpulib \
|
|
// RUN: %s 2>&1 | FileCheck -check-prefix=VD %s
|
|
|
|
// VD: "-targets=host-x86_64-unknown-linux,hipv4-amdgcn-amd-amdhsa--gfx906"
|
|
|
|
// Check invalid code object version option.
|
|
|
|
// RUN: not %clang -### --target=x86_64-linux-gnu \
|
|
// RUN: -mcode-object-version=1 \
|
|
// RUN: --offload-arch=gfx906 --rocm-path=%S/Inputs/rocm \
|
|
// RUN: %s 2>&1 | FileCheck -check-prefix=INVALID %s
|
|
// INVALID: error: invalid integral value '1' in '-mcode-object-version=1'
|
|
// INVALID-NOT: error: invalid integral value
|
|
|
|
// Check LLVM code object version option --amdhsa-code-object-version
|
|
// is passed to -cc1 and -cc1as, and -mcode-object-version is passed
|
|
// to -cc1 but not -cc1as.
|
|
|
|
// RUN: not %clang -### --target=x86_64-linux-gnu \
|
|
// RUN: -mcode-object-version=5 \
|
|
// RUN: --offload-arch=gfx906 --rocm-path=%S/Inputs/rocm -save-temps \
|
|
// RUN: %s 2>&1 | FileCheck -check-prefix=CC1 %s
|
|
|
|
// CC1: "-cc1" {{.*}}"-mcode-object-version=5" {{.*}}"-mllvm" "--amdhsa-code-object-version=5"
|
|
// CC1: "-cc1as" {{.*}}"-mllvm" "--amdhsa-code-object-version=5"
|
|
|
|
// RUN: not %clang -### --target=x86_64-linux-gnu \
|
|
// RUN: -mcode-object-version=5 \
|
|
// RUN: --offload-arch=gfx906 --rocm-path=%S/Inputs/rocm -save-temps \
|
|
// RUN: %s 2>&1 | FileCheck -check-prefix=CC1NEG %s
|
|
|
|
// CC1NEG-NOT: "-cc1as" {{.*}}"-mcode-object-version=5"
|