9eef4d1c5f
This removes the delayed typo correction functionality from Clang (regular typo correction still remains) due to fragility of the solution. An RFC was posted here: https://discourse.llvm.org/t/rfc-removing-support-for-delayed-typo-correction/86631 and while that RFC was asking for folks to consider stepping up to be maintainers, and we did have a few new contributors show some interest, experiments show that it's likely worth it to remove this functionality entirely and focus efforts on improving regular typo correction. This removal fixes ~20 open issues (quite possibly more), improves compile time performance by roughly .3-.4% (https://llvm-compile-time-tracker.com/?config=Overview&stat=instructions%3Au&remote=AaronBallman&sortBy=date), and does not appear to regress diagnostic behavior in a way we wouldn't find acceptable. Fixes #142457 Fixes #139913 Fixes #138850 Fixes #137867 Fixes #137860 Fixes #107840 Fixes #93308 Fixes #69470 Fixes #59391 Fixes #58172 Fixes #46215 Fixes #45915 Fixes #45891 Fixes #44490 Fixes #36703 Fixes #32903 Fixes #23312 Fixes #69874
72 lines
2.3 KiB
C++
72 lines
2.3 KiB
C++
// RUN: rm -rf %t
|
|
// RUN: mkdir %t
|
|
// RUN: split-file %s %t
|
|
|
|
// RUN: %clang_cc1 -std=c++20 %t/M.cppm -verify
|
|
// RUN: %clang_cc1 -std=c++20 %t/M.cppm -emit-module-interface -o %t/M.pcm
|
|
// RUN: %clang_cc1 -std=c++20 -fmodule-file=M=%t/M.pcm %t/M.cpp -verify
|
|
//
|
|
// RUN: %clang_cc1 -std=c++20 -fmodule-file=M=%t/M.pcm %t/user.cpp -verify
|
|
|
|
//--- M.cppm
|
|
// expected-no-diagnostics
|
|
export module M;
|
|
|
|
export int external_linkage_var;
|
|
int module_linkage_var;
|
|
static int internal_linkage_var;
|
|
|
|
export void external_linkage_fn() {}
|
|
void module_linkage_fn() {}
|
|
static void internal_linkage_fn() {}
|
|
|
|
export struct external_linkage_class {};
|
|
struct module_linkage_class {};
|
|
namespace {
|
|
struct internal_linkage_class {};
|
|
} // namespace
|
|
|
|
void use() {
|
|
external_linkage_fn();
|
|
module_linkage_fn();
|
|
internal_linkage_fn();
|
|
(void)external_linkage_class{};
|
|
(void)module_linkage_class{};
|
|
(void)internal_linkage_class{};
|
|
(void)external_linkage_var;
|
|
(void)module_linkage_var;
|
|
(void)internal_linkage_var;
|
|
}
|
|
|
|
//--- M.cpp
|
|
|
|
module M;
|
|
|
|
void use_from_module_impl() {
|
|
external_linkage_fn();
|
|
module_linkage_fn();
|
|
internal_linkage_fn(); // expected-error {{use of undeclared identifier 'internal_linkage_fn'}} // expected-note@* {{}}
|
|
(void)external_linkage_class{};
|
|
(void)module_linkage_class{};
|
|
(void)external_linkage_var;
|
|
(void)module_linkage_var;
|
|
|
|
(void)internal_linkage_class{}; // expected-error {{use of undeclared identifier 'internal_linkage_class'}} // expected-note@* {{}}
|
|
(void)internal_linkage_var; // expected-error {{use of undeclared identifier 'internal_linkage_var'}}
|
|
}
|
|
|
|
//--- user.cpp
|
|
import M;
|
|
|
|
void use_from_module_impl() {
|
|
external_linkage_fn();
|
|
module_linkage_fn(); // expected-error {{use of undeclared identifier 'module_linkage_fn'}}
|
|
internal_linkage_fn(); // expected-error {{use of undeclared identifier 'internal_linkage_fn'}}
|
|
(void)external_linkage_class{};
|
|
(void)module_linkage_class{}; // expected-error {{undeclared identifier}} expected-error 0+{{}} // expected-note@* {{}}
|
|
(void)internal_linkage_class{}; // expected-error {{undeclared identifier}} expected-error 0+{{}} // expected-note@* {{}}
|
|
(void)external_linkage_var;
|
|
(void)module_linkage_var; // expected-error {{undeclared identifier}}
|
|
(void)internal_linkage_var; // expected-error {{undeclared identifier}}
|
|
}
|