9eef4d1c5f
This removes the delayed typo correction functionality from Clang (regular typo correction still remains) due to fragility of the solution. An RFC was posted here: https://discourse.llvm.org/t/rfc-removing-support-for-delayed-typo-correction/86631 and while that RFC was asking for folks to consider stepping up to be maintainers, and we did have a few new contributors show some interest, experiments show that it's likely worth it to remove this functionality entirely and focus efforts on improving regular typo correction. This removal fixes ~20 open issues (quite possibly more), improves compile time performance by roughly .3-.4% (https://llvm-compile-time-tracker.com/?config=Overview&stat=instructions%3Au&remote=AaronBallman&sortBy=date), and does not appear to regress diagnostic behavior in a way we wouldn't find acceptable. Fixes #142457 Fixes #139913 Fixes #138850 Fixes #137867 Fixes #137860 Fixes #107840 Fixes #93308 Fixes #69470 Fixes #59391 Fixes #58172 Fixes #46215 Fixes #45915 Fixes #45891 Fixes #44490 Fixes #36703 Fixes #32903 Fixes #23312 Fixes #69874
100 lines
2.8 KiB
C++
100 lines
2.8 KiB
C++
// RUN: %clang_cc1 %s -verify -fopenacc
|
|
|
|
namespace NS {
|
|
static char* NSArray; // expected-note {{'NS::NSArray' declared here}}
|
|
static int NSInt; // expected-note 2 {{'NS::NSInt' declared here}}
|
|
}
|
|
char *getArrayPtr();
|
|
template<typename T, int I>
|
|
void func() {
|
|
char *ArrayPtr = getArrayPtr();
|
|
for (int i = 0; i < 10; ++i) {
|
|
// expected-warning@+1{{left operand of comma operator has no effect}}
|
|
#pragma acc cache(ArrayPtr[T::value + I:I + 3], T::array[(i + T::value, 2): 4])
|
|
}
|
|
for (int i = 0; i < 10; ++i) {
|
|
#pragma acc cache(NS::NSArray[NS::NSInt])
|
|
}
|
|
|
|
for (int i = 0; i < 10; ++i) {
|
|
#pragma acc cache(NS::NSArray[NS::NSInt : NS::NSInt])
|
|
}
|
|
|
|
for (int i = 0; i < 10; ++i) {
|
|
// expected-error@+1{{use of undeclared identifier 'NSArray'}}
|
|
#pragma acc cache(NSArray[NS::NSInt : NS::NSInt])
|
|
}
|
|
|
|
for (int i = 0; i < 10; ++i) {
|
|
// expected-error@+1{{use of undeclared identifier 'NSInt'}}
|
|
#pragma acc cache(NS::NSArray[NSInt : NS::NSInt])
|
|
}
|
|
|
|
for (int i = 0; i < 10; ++i) {
|
|
// expected-error@+1{{use of undeclared identifier 'NSInt'}}
|
|
#pragma acc cache(NS::NSArray[NS::NSInt : NSInt])
|
|
}
|
|
}
|
|
|
|
struct S {
|
|
static constexpr int value = 5;
|
|
static constexpr char array[] ={1,2,3,4,5};
|
|
};
|
|
|
|
struct Members {
|
|
int value = 5;
|
|
char array[5] ={1,2,3,4,5};
|
|
};
|
|
struct HasMembersArray {
|
|
Members MemArr[4];
|
|
};
|
|
|
|
|
|
void use() {
|
|
|
|
Members s;
|
|
for (int i = 0; i < 10; ++i) {
|
|
#pragma acc cache(s.array[s.value])
|
|
}
|
|
HasMembersArray Arrs;
|
|
for (int i = 0; i < 10; ++i) {
|
|
#pragma acc cache(Arrs.MemArr[3].array[4])
|
|
}
|
|
for (int i = 0; i < 10; ++i) {
|
|
#pragma acc cache(Arrs.MemArr[3].array[1:4])
|
|
}
|
|
for (int i = 0; i < 10; ++i) {
|
|
// expected-error@+1{{OpenACC sub-array is not allowed here}}
|
|
#pragma acc cache(Arrs.MemArr[2:1].array[1:4])
|
|
}
|
|
for (int i = 0; i < 10; ++i) {
|
|
// expected-error@+1{{OpenACC sub-array is not allowed here}}
|
|
#pragma acc cache(Arrs.MemArr[2:1].array[4])
|
|
}
|
|
for (int i = 0; i < 10; ++i) {
|
|
// expected-error@+2{{expected ']'}}
|
|
// expected-note@+1{{to match this '['}}
|
|
#pragma acc cache(Arrs.MemArr[3:4:].array[4])
|
|
}
|
|
for (int i = 0; i < 10; ++i) {
|
|
// expected-error@+1{{OpenACC sub-array is not allowed here}}
|
|
#pragma acc cache(Arrs.MemArr[:].array[4])
|
|
}
|
|
for (int i = 0; i < 10; ++i) {
|
|
// expected-error@+1{{expected unqualified-id}}
|
|
#pragma acc cache(Arrs.MemArr[::].array[4])
|
|
}
|
|
for (int i = 0; i < 10; ++i) {
|
|
// expected-error@+3{{expected expression}}
|
|
// expected-error@+2{{expected ']'}}
|
|
// expected-note@+1{{to match this '['}}
|
|
#pragma acc cache(Arrs.MemArr[: :].array[4])
|
|
}
|
|
for (int i = 0; i < 10; ++i) {
|
|
// expected-error@+1{{OpenACC sub-array is not allowed here}}
|
|
#pragma acc cache(Arrs.MemArr[3:].array[4])
|
|
}
|
|
func<S, 5>(); // expected-note{{in instantiation of function template specialization}}
|
|
}
|
|
|