8acdcf4016
All data structures and values associated with handling virtual functions / inheritance, as well as RTTI, are globals and thus can only reside in the global address space. This was not taken fully taken into account because for most targets, global & generic appear to coincide. However, on targets where global & generic ASes differ (e.g. AMDGPU), this was problematic, since it led to the generation of invalid bitcasts (which would trigger asserts in Debug) and less than optimal code. This patch does two things: ensures that vtables, vptrs, vtts, typeinfo are generated in the right AS, and populated accordingly; removes a bunch of bitcasts which look like left-overs from the typed ptr era. Reviewed By: yxsamliu Differential Revision: https://reviews.llvm.org/D153092
218 lines
7.2 KiB
C++
218 lines
7.2 KiB
C++
// RUN: %clang_cc1 %s -triple=amdgcn-amd-amdhsa -emit-llvm -o %t
|
|
// RUN: %clang_cc1 %s -triple=amdgcn-amd-amdhsa -emit-llvm -std=c++03 -o %t.03
|
|
// RUN: %clang_cc1 %s -triple=amdgcn-amd-amdhsa -emit-llvm -std=c++11 -o %t.11
|
|
// RUN: %clang_cc1 %s -triple=amdgcn-amd-amdhsa -disable-llvm-passes -O3 -emit-llvm -o %t.opt
|
|
// RUN: FileCheck %s < %t
|
|
// RUN: FileCheck %s < %t.03
|
|
// RUN: FileCheck %s < %t.11
|
|
// RUN: FileCheck --check-prefix=CHECK-OPT %s < %t.opt
|
|
|
|
namespace {
|
|
struct A {
|
|
virtual void f() { }
|
|
};
|
|
}
|
|
|
|
void f() { A b; }
|
|
|
|
struct B {
|
|
B();
|
|
virtual void f();
|
|
};
|
|
|
|
B::B() { }
|
|
|
|
struct C : virtual B {
|
|
C();
|
|
virtual void f() { }
|
|
};
|
|
|
|
C::C() { }
|
|
|
|
struct D {
|
|
virtual void f();
|
|
};
|
|
|
|
void D::f() { }
|
|
|
|
static struct : D { } e;
|
|
|
|
// Force 'e' to be constructed and therefore have a vtable defined.
|
|
void use_e() {
|
|
e.f();
|
|
}
|
|
|
|
// The destructor is the key function.
|
|
template<typename T>
|
|
struct E {
|
|
virtual ~E();
|
|
};
|
|
|
|
template<typename T> E<T>::~E() { }
|
|
|
|
// Anchor is the key function
|
|
template<>
|
|
struct E<char> {
|
|
virtual void anchor();
|
|
};
|
|
|
|
void E<char>::anchor() { }
|
|
|
|
template struct E<short>;
|
|
extern template struct E<int>;
|
|
|
|
void use_E() {
|
|
E<int> ei;
|
|
(void)ei;
|
|
E<long> el;
|
|
(void)el;
|
|
}
|
|
|
|
// No key function
|
|
template<typename T>
|
|
struct F {
|
|
virtual void foo() { }
|
|
};
|
|
|
|
// No key function
|
|
template<>
|
|
struct F<char> {
|
|
virtual void foo() { }
|
|
};
|
|
|
|
template struct F<short>;
|
|
extern template struct F<int>;
|
|
|
|
void use_F() {
|
|
F<char> fc;
|
|
fc.foo();
|
|
F<int> fi;
|
|
fi.foo();
|
|
F<long> fl;
|
|
(void)fl;
|
|
}
|
|
|
|
// B has a key function that is not defined in this translation unit so its vtable
|
|
// has external linkage.
|
|
// CHECK-DAG: @_ZTV1B = external unnamed_addr addrspace(1) constant
|
|
|
|
// C has no key function, so its vtable should have weak_odr linkage
|
|
// and hidden visibility (rdar://problem/7523229).
|
|
// CHECK-DAG: @_ZTV1C = linkonce_odr unnamed_addr addrspace(1) constant {{.*}}, comdat, align 8{{$}}
|
|
// CHECK-DAG: @_ZTS1C = linkonce_odr addrspace(1) constant {{.*}}, comdat, align 1{{$}}
|
|
// CHECK-DAG: @_ZTI1C = linkonce_odr addrspace(1) constant {{.*}}, comdat, align 8{{$}}
|
|
// CHECK-DAG: @_ZTT1C = linkonce_odr unnamed_addr addrspace(1) constant {{.*}}, comdat, align 8{{$}}
|
|
|
|
// D has a key function that is defined in this translation unit so its vtable is
|
|
// defined in the translation unit.
|
|
// CHECK-DAG: @_ZTV1D ={{.*}} unnamed_addr addrspace(1) constant
|
|
// CHECK-DAG: @_ZTS1D ={{.*}} addrspace(1) constant
|
|
// CHECK-DAG: @_ZTI1D ={{.*}} addrspace(1) constant
|
|
|
|
// E<char> is an explicit specialization with a key function defined
|
|
// in this translation unit, so its vtable should have external
|
|
// linkage.
|
|
// CHECK-DAG: @_ZTV1EIcE ={{.*}} unnamed_addr addrspace(1) constant
|
|
// CHECK-DAG: @_ZTS1EIcE ={{.*}} addrspace(1) constant
|
|
// CHECK-DAG: @_ZTI1EIcE ={{.*}} addrspace(1) constant
|
|
|
|
// E<short> is an explicit template instantiation with a key function
|
|
// defined in this translation unit, so its vtable should have
|
|
// weak_odr linkage.
|
|
// CHECK-DAG: @_ZTV1EIsE = weak_odr unnamed_addr addrspace(1) constant {{.*}}, comdat,
|
|
// CHECK-DAG: @_ZTS1EIsE = weak_odr addrspace(1) constant {{.*}}, comdat, align 1{{$}}
|
|
// CHECK-DAG: @_ZTI1EIsE = weak_odr addrspace(1) constant {{.*}}, comdat, align 8{{$}}
|
|
|
|
// F<short> is an explicit template instantiation without a key
|
|
// function, so its vtable should have weak_odr linkage
|
|
// CHECK-DAG: @_ZTV1FIsE = weak_odr unnamed_addr addrspace(1) constant {{.*}}, comdat,
|
|
// CHECK-DAG: @_ZTS1FIsE = weak_odr addrspace(1) constant {{.*}}, comdat, align 1{{$}}
|
|
// CHECK-DAG: @_ZTI1FIsE = weak_odr addrspace(1) constant {{.*}}, comdat, align 8{{$}}
|
|
|
|
// E<long> is an implicit template instantiation with a key function
|
|
// defined in this translation unit, so its vtable should have
|
|
// linkonce_odr linkage.
|
|
// CHECK-DAG: @_ZTV1EIlE = linkonce_odr unnamed_addr addrspace(1) constant {{.*}}, comdat,
|
|
// CHECK-DAG: @_ZTS1EIlE = linkonce_odr addrspace(1) constant {{.*}}, comdat, align 1{{$}}
|
|
// CHECK-DAG: @_ZTI1EIlE = linkonce_odr addrspace(1) constant {{.*}}, comdat, align 8{{$}}
|
|
|
|
// F<long> is an implicit template instantiation with no key function,
|
|
// so its vtable should have linkonce_odr linkage.
|
|
// CHECK-DAG: @_ZTV1FIlE = linkonce_odr unnamed_addr addrspace(1) constant {{.*}}, comdat,
|
|
// CHECK-DAG: @_ZTS1FIlE = linkonce_odr addrspace(1) constant {{.*}}, comdat, align 1{{$}}
|
|
// CHECK-DAG: @_ZTI1FIlE = linkonce_odr addrspace(1) constant {{.*}}, comdat, align 8{{$}}
|
|
|
|
// F<int> is an explicit template instantiation declaration without a
|
|
// key function, so its vtable should have external linkage.
|
|
// CHECK-DAG: @_ZTV1FIiE = external unnamed_addr addrspace(1) constant
|
|
// CHECK-OPT-DAG: @_ZTV1FIiE = available_externally unnamed_addr addrspace(1) constant
|
|
|
|
// E<int> is an explicit template instantiation declaration. It has a
|
|
// key function is not instantiated, so we know that vtable definition
|
|
// will be generated in TU where key function will be defined
|
|
// so we can mark it as external (without optimizations) and
|
|
// available_externally (with optimizations) because all of the inline
|
|
// virtual functions have been emitted.
|
|
// CHECK-DAG: @_ZTV1EIiE = external unnamed_addr addrspace(1) constant
|
|
// CHECK-OPT-DAG: @_ZTV1EIiE = available_externally unnamed_addr addrspace(1) constant
|
|
|
|
// The anonymous struct for e has no linkage, so the vtable should have
|
|
// internal linkage.
|
|
// CHECK-DAG: @"_ZTV3$_0" = internal unnamed_addr addrspace(1) constant
|
|
// CHECK-DAG: @"_ZTS3$_0" = internal addrspace(1) constant
|
|
// CHECK-DAG: @"_ZTI3$_0" = internal addrspace(1) constant
|
|
|
|
// The A vtable should have internal linkage since it is inside an anonymous
|
|
// namespace.
|
|
// CHECK-DAG: @_ZTVN12_GLOBAL__N_11AE = internal unnamed_addr addrspace(1) constant
|
|
// CHECK-DAG: @_ZTSN12_GLOBAL__N_11AE = internal addrspace(1) constant
|
|
// CHECK-DAG: @_ZTIN12_GLOBAL__N_11AE = internal addrspace(1) constant
|
|
|
|
// F<char> is an explicit specialization without a key function, so
|
|
// its vtable should have linkonce_odr linkage.
|
|
// CHECK-DAG: @_ZTV1FIcE = linkonce_odr unnamed_addr addrspace(1) constant {{.*}}, comdat,
|
|
// CHECK-DAG: @_ZTS1FIcE = linkonce_odr addrspace(1) constant {{.*}}, comdat, align 1{{$}}
|
|
// CHECK-DAG: @_ZTI1FIcE = linkonce_odr addrspace(1) constant {{.*}}, comdat, align 8{{$}}
|
|
|
|
// CHECK-DAG: @_ZTV1GIiE = linkonce_odr unnamed_addr addrspace(1) constant {{.*}}, comdat,
|
|
template <typename T>
|
|
class G {
|
|
public:
|
|
G() {}
|
|
virtual void f0();
|
|
virtual void f1();
|
|
};
|
|
template <>
|
|
void G<int>::f1() {}
|
|
template <typename T>
|
|
void G<T>::f0() {}
|
|
void G_f0() { new G<int>(); }
|
|
|
|
// H<int> has a key function without a body but it's a template instantiation
|
|
// so its VTable must be emitted.
|
|
// CHECK-DAG: @_ZTV1HIiE = linkonce_odr unnamed_addr addrspace(1) constant {{.*}}, comdat,
|
|
template <typename T>
|
|
class H {
|
|
public:
|
|
virtual ~H();
|
|
};
|
|
|
|
void use_H() {
|
|
H<int> h;
|
|
}
|
|
|
|
// I<int> has an explicit instantiation declaration and needs a VTT and
|
|
// construction vtables.
|
|
|
|
// CHECK-DAG: @_ZTV1IIiE = external unnamed_addr addrspace(1) constant
|
|
// CHECK-DAG: @_ZTT1IIiE = external unnamed_addr addrspace(1) constant
|
|
// CHECK-NOT: @_ZTC1IIiE
|
|
//
|
|
// CHECK-OPT-DAG: @_ZTV1IIiE = available_externally unnamed_addr addrspace(1) constant
|
|
// CHECK-OPT-DAG: @_ZTT1IIiE = available_externally unnamed_addr addrspace(1) constant
|
|
struct VBase1 { virtual void f(); }; struct VBase2 : virtual VBase1 {};
|
|
template<typename T>
|
|
struct I : VBase2 {};
|
|
extern template struct I<int>;
|
|
I<int> i;
|