516803dc86
Summary: This patch addresses https://bugs.llvm.org/show_bug.cgi?id=46256 The spec of coroutine requires that the expression co_await promise.final_suspend() shall not be potentially-throwing. To check this, we recursively look at every call (including Call, MemberCall, OperatorCall and Constructor) in all code generated by the final suspend, and ensure that the callees are declared with noexcept. We also look at any returned data type that requires explicit destruction, and check their destructors for noexcept. This patch does not check declarations with dependent types yet, which will be done in future patches. Updated all tests to add noexcept to the required functions, and added a dedicated test for this patch. This patch might start to cause existing codebase fail to compile because most people may not have been strict in tagging all the related functions noexcept. Reviewers: lewissbaker, modocache, junparser Reviewed By: modocache Subscribers: arphaman, junparser, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D82029
48 lines
1.3 KiB
C++
48 lines
1.3 KiB
C++
// RUN: %clang_cc1 -std=c++14 -fcoroutines-ts -triple=x86_64-pc-windows-msvc18.0.0 -emit-llvm -o - %s -fexceptions -fcxx-exceptions -disable-llvm-passes | FileCheck %s
|
|
// -triple=x86_64-unknown-linux-gnu
|
|
|
|
#include "Inputs/coroutine.h"
|
|
|
|
namespace coro = std::experimental::coroutines_v1;
|
|
|
|
struct coro_t {
|
|
void* p;
|
|
~coro_t();
|
|
struct promise_type {
|
|
coro_t get_return_object();
|
|
coro::suspend_never initial_suspend();
|
|
coro::suspend_never final_suspend() noexcept;
|
|
void return_void();
|
|
promise_type();
|
|
~promise_type();
|
|
void unhandled_exception();
|
|
};
|
|
};
|
|
|
|
struct Cleanup { ~Cleanup(); };
|
|
void may_throw();
|
|
|
|
coro_t f() {
|
|
Cleanup cleanup;
|
|
may_throw();
|
|
co_return;
|
|
}
|
|
|
|
// CHECK-LABEL: define dso_local void @"?f@@YA?AUcoro_t@@XZ"(
|
|
// CHECK: %gro.active = alloca i1
|
|
// CHECK: store i1 false, i1* %gro.active
|
|
|
|
// CHECK: invoke %"struct.coro_t::promise_type"* @"??0promise_type@coro_t@@QEAA@XZ"(
|
|
// CHECK: invoke void @"?get_return_object@promise_type@coro_t@@QEAA?AU2@XZ"(
|
|
// CHECK: store i1 true, i1* %gro.active
|
|
|
|
// CHECK: %[[IS_ACTIVE:.+]] = load i1, i1* %gro.active
|
|
// CHECK: br i1 %[[IS_ACTIVE]], label %[[CLEANUP1:.+]], label
|
|
|
|
// CHECK: [[CLEANUP1]]:
|
|
// CHECK: %[[NRVO:.+]] = load i1, i1* %nrvo
|
|
// CHECK: br i1 %[[NRVO]], label %{{.+}}, label %[[DTOR:.+]]
|
|
|
|
// CHECK: [[DTOR]]:
|
|
// CHECK: call void @"??1coro_t@@QEAA@XZ"(
|