6b3351792c
For a definition (of most linkage types), dso_local is set for ELF -fno-pic/-fpie
and COFF, but not for Mach-O. This nuance causes unneeded binary format differences.
This patch replaces (function) `define ` with `define{{.*}} `,
(variable/constant/alias) `= ` with `={{.*}} `, or inserts appropriate `{{.*}} `
if there is an explicit linkage.
* Clang will set dso_local for Mach-O, which is currently implied by TargetMachine.cpp. This will make COFF/Mach-O and executable ELF similar.
* Eventually I hope we can make dso_local the textual LLVM IR default (write explicit "dso_preemptable" when applicable) and -fpic ELF will be similar to everything else. This patch helps move toward that goal.
49 lines
1.7 KiB
Objective-C
49 lines
1.7 KiB
Objective-C
// RUN: %clang_cc1 -x objective-c -emit-llvm -triple x86_64-apple-macosx10.10.0 -fsanitize=nonnull-attribute %s -o - -w | FileCheck %s
|
|
|
|
@interface A
|
|
|
|
-(void) one_arg: (__attribute__((nonnull)) int *) arg1;
|
|
|
|
-(void) varargs: (__attribute__((nonnull)) int *) arg1, ...;
|
|
|
|
+(void) clsmethod: (__attribute__((nonnull)) int *) arg1;
|
|
|
|
@end
|
|
|
|
@implementation A
|
|
|
|
// CHECK-LABEL: define internal void @"\01-[A one_arg:]"
|
|
// CHECK-SAME: i32* nonnull
|
|
-(void) one_arg: (__attribute__((nonnull)) int *) arg1 {}
|
|
|
|
// CHECK-LABEL: define internal void @"\01-[A varargs:]"
|
|
// CHECK-SAME: i32* nonnull
|
|
-(void) varargs: (__attribute__((nonnull)) int *) arg1, ... {}
|
|
|
|
// CHECK-LABEL: define internal void @"\01+[A clsmethod:]"
|
|
// CHECK-SAME: i32* nonnull
|
|
+(void) clsmethod: (__attribute__((nonnull)) int *) arg1 {}
|
|
|
|
@end
|
|
|
|
// CHECK-LABEL: define{{.*}} void @call_A
|
|
void call_A(A *a, int *p) {
|
|
// CHECK: [[ICMP:%.*]] = icmp ne i32* [[P1:%.*]], null, !nosanitize
|
|
// CHECK: br i1 [[ICMP]], {{.*}}, !nosanitize
|
|
// CHECK: call void @__ubsan_handle_nonnull_arg{{.*}} !nosanitize
|
|
// CHECK: call void {{.*}} @objc_msgSend {{.*}} ({{.*}}, i32* [[P1]])
|
|
[a one_arg: p];
|
|
|
|
// CHECK: [[ICMP:%.*]] = icmp ne i32* [[P2:%.*]], null, !nosanitize
|
|
// CHECK: br i1 [[ICMP]], {{.*}}, !nosanitize
|
|
// CHECK: call void @__ubsan_handle_nonnull_arg{{.*}} !nosanitize
|
|
// CHECK: call void {{.*}} @objc_msgSend {{.*}} ({{.*}}, i32* [[P2]], {{.*}})
|
|
[a varargs: p, p];
|
|
|
|
// CHECK: [[ICMP:%.*]] = icmp ne i32* [[P3:%.*]], null, !nosanitize
|
|
// CHECK: br i1 [[ICMP]], {{.*}}, !nosanitize
|
|
// CHECK: call void @__ubsan_handle_nonnull_arg{{.*}} !nosanitize
|
|
// CHECK: call void {{.*}} @objc_msgSend {{.*}} ({{.*}}, i32* [[P3]])
|
|
[A clsmethod: p];
|
|
}
|