9ea5d17cc9
Summary: As @rsmith notes in https://reviews.llvm.org/D73020#inline-672219 while that is certainly UB land, it may not be actually reachable at runtime, e.g.: ``` template<int N> void *make() { if ((N & (N-1)) == 0) return operator new(N, std::align_val_t(N)); else return operator new(N); } void *p = make<7>(); ``` and we shouldn't really error-out there. That being said, i'm not really following the logic here. Which ones of these cases should remain being an error? Reviewers: rsmith, erichkeane Reviewed By: erichkeane Subscribers: cfe-commits, rsmith Tags: #clang Differential Revision: https://reviews.llvm.org/D73996
47 lines
2.2 KiB
C++
47 lines
2.2 KiB
C++
// RUN: %clang_cc1 -fsyntax-only -verify %s
|
|
|
|
struct param_num {
|
|
void* Foo(int a) __attribute__((alloc_align(1))); // expected-error {{'alloc_align' attribute is invalid for the implicit this argument}}
|
|
};
|
|
|
|
|
|
template <typename T>
|
|
struct dependent_ret {
|
|
T* Foo(int a) __attribute__((alloc_align(2)));// no-warning, ends up being int**.
|
|
T Foo2(int a) __attribute__((alloc_align(2)));// expected-warning {{'alloc_align' attribute only applies to return values that are pointers or references}}
|
|
};
|
|
|
|
// Following 2 errors associated only with the 'float' versions below.
|
|
template <typename T>
|
|
struct dependent_param_struct {
|
|
void* Foo(T param) __attribute__((alloc_align(2))); // expected-error {{'alloc_align' attribute argument may only refer to a function parameter of integer type}}
|
|
};
|
|
|
|
template <typename T>
|
|
void* dependent_param_func(T param) __attribute__((alloc_align(1)));// expected-error {{'alloc_align' attribute argument may only refer to a function parameter of integer type}}
|
|
|
|
template <int T>
|
|
void* illegal_align_param(int p) __attribute__((alloc_align(T))); // expected-error {{'alloc_align' attribute requires parameter 1 to be an integer constant}}
|
|
|
|
void dependent_impl(int align) {
|
|
dependent_ret<int> a; // expected-note {{in instantiation of template class 'dependent_ret<int>' requested here}}
|
|
a.Foo(1);
|
|
a.Foo2(1);
|
|
dependent_ret<int *> b;
|
|
b.Foo(1);
|
|
b.Foo2(1);
|
|
b.Foo(3); // expected-warning {{requested alignment is not a power of 2}}
|
|
b.Foo2(3); // expected-warning {{requested alignment is not a power of 2}}
|
|
b.Foo(1073741824); // expected-warning {{requested alignment must be 536870912 bytes or smaller; maximum alignment assumed}}
|
|
b.Foo2(1073741824); // expected-warning {{requested alignment must be 536870912 bytes or smaller; maximum alignment assumed}}
|
|
b.Foo(align);
|
|
b.Foo2(align);
|
|
|
|
dependent_param_struct<int> c;
|
|
c.Foo(1);
|
|
dependent_param_struct<float> d; // expected-note {{in instantiation of template class 'dependent_param_struct<float>' requested here}}
|
|
d.Foo(1.0);
|
|
dependent_param_func<int>(1);
|
|
dependent_param_func<float>(1); // expected-note {{in instantiation of function template specialization 'dependent_param_func<float>' requested here}}
|
|
}
|