0a088ead85
Fix a few bugs where we would fail to properly determine header to module correspondence when determining whether to suggest a #include or import, and suggest a #include more often in language modes where there is no import syntax. Generally, if the target is in a header with include guards or #pragma once, we should suggest either #including or importing that header, and not importing a module that happens to textually include it. In passing, improve the notes we attach to the corresponding diagnostics: calling an entity that we couldn't see "previous" is confusing.
55 lines
1.5 KiB
C++
55 lines
1.5 KiB
C++
// RUN: %clang_cc1 -triple x86_64-apple-darwin -fcxx-exceptions -verify -std=c++2a -fmodules -I%S/Inputs %s -fno-modules-error-recovery
|
|
|
|
#pragma clang module build compare
|
|
module compare {
|
|
explicit module cmp {}
|
|
explicit module other {}
|
|
}
|
|
#pragma clang module contents
|
|
#pragma clang module begin compare.cmp
|
|
#include "std-compare.h"
|
|
#pragma clang module end
|
|
#pragma clang module endbuild
|
|
|
|
struct CC { CC(...); };
|
|
|
|
void a() { void(0 <=> 0); } // expected-error {{include <compare>}}
|
|
|
|
struct A {
|
|
CC operator<=>(const A&) const = default; // expected-error {{include <compare>}}
|
|
};
|
|
auto va = A() <=> A(); // expected-note {{required here}}
|
|
|
|
#pragma clang module import compare.other
|
|
|
|
// expected-note@std-compare.h:* 2+{{not reachable}}
|
|
|
|
void b() { void(0 <=> 0); } // expected-error 1+{{missing '#include "std-compare.h"'; 'strong_ordering' must be defined}}
|
|
|
|
struct B {
|
|
CC operator<=>(const B&) const = default; // expected-error 1+{{missing '#include "std-compare.h"'; 'strong_ordering' must be defined}}
|
|
};
|
|
auto vb = B() <=> B(); // expected-note {{required here}}
|
|
|
|
#pragma clang module import compare.cmp
|
|
|
|
void c() { void(0 <=> 0); }
|
|
|
|
struct C {
|
|
CC operator<=>(const C&) const = default;
|
|
};
|
|
auto vc = C() <=> C();
|
|
|
|
|
|
#pragma clang module build compare2
|
|
module compare2 {}
|
|
#pragma clang module contents
|
|
#pragma clang module begin compare2
|
|
#include "std-compare.h"
|
|
#pragma clang module end
|
|
#pragma clang module endbuild
|
|
|
|
#pragma clang module import compare2
|
|
|
|
void g() { void(0.0 <=> 0.0); }
|