516803dc86
Summary: This patch addresses https://bugs.llvm.org/show_bug.cgi?id=46256 The spec of coroutine requires that the expression co_await promise.final_suspend() shall not be potentially-throwing. To check this, we recursively look at every call (including Call, MemberCall, OperatorCall and Constructor) in all code generated by the final suspend, and ensure that the callees are declared with noexcept. We also look at any returned data type that requires explicit destruction, and check their destructors for noexcept. This patch does not check declarations with dependent types yet, which will be done in future patches. Updated all tests to add noexcept to the required functions, and added a dedicated test for this patch. This patch might start to cause existing codebase fail to compile because most people may not have been strict in tagging all the related functions noexcept. Reviewers: lewissbaker, modocache, junparser Reviewed By: modocache Subscribers: arphaman, junparser, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D82029
42 lines
1.3 KiB
C++
42 lines
1.3 KiB
C++
// RUN: %clang_cc1 -triple x86_64-apple-darwin9 %s -std=c++14 -fcoroutines-ts \
|
|
// RUN: -fsyntax-only -Wignored-qualifiers -Wno-error=return-type -verify \
|
|
// RUN: -fblocks -Wno-unreachable-code -Wno-unused-value
|
|
|
|
// RUN: %clang_cc1 -triple x86_64-apple-darwin9 %s -std=c++14 -fcoroutines-ts \
|
|
// RUN: -fsyntax-only -Wignored-qualifiers -Wno-error=return-type -verify \
|
|
// RUN: -fblocks -Wno-unreachable-code -Wno-unused-value \
|
|
// RUN: -DDISABLE_WARNING -Wno-coroutine-missing-unhandled-exception
|
|
|
|
#if __has_feature(cxx_exceptions)
|
|
#error This test requires exceptions be disabled
|
|
#endif
|
|
|
|
#include "Inputs/std-coroutine.h"
|
|
|
|
using std::experimental::suspend_always;
|
|
using std::experimental::suspend_never;
|
|
|
|
#ifndef DISABLE_WARNING
|
|
struct promise_void { // expected-note {{defined here}}
|
|
#else
|
|
struct promise_void {
|
|
#endif
|
|
void get_return_object();
|
|
suspend_always initial_suspend();
|
|
suspend_always final_suspend() noexcept;
|
|
void return_void();
|
|
};
|
|
|
|
template <typename... T>
|
|
struct std::experimental::coroutine_traits<void, T...> { using promise_type = promise_void; };
|
|
|
|
#ifndef DISABLE_WARNING
|
|
void test0() { // expected-warning {{'promise_void' is required to declare the member 'unhandled_exception()' when exceptions are enabled}}
|
|
co_return;
|
|
}
|
|
#else
|
|
void test0() { // expected-no-diagnostics
|
|
co_return;
|
|
}
|
|
#endif
|