e33105e8c2
Summary:
We run the tests for -Wthread-safety-{negative,verbose} with the new
attributes as well as the old ones. Also put the macros in a header so
that we don't have to copy them all around.
The warn-thread-safety-parsing.cpp test checks for warnings depending on
the actual attribute name, so it can't undergo the same treatment.
Together with D49275 this should fix PR33754.
Reviewers: aaron.ballman, delesley, grooverdan
Reviewed By: aaron.ballman
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D52141
llvm-svn: 342418
65 lines
2.4 KiB
C++
65 lines
2.4 KiB
C++
// RUN: %clang_cc1 -fsyntax-only -verify -std=c++11 -Wthread-safety -Wthread-safety-beta -Wthread-safety-verbose -Wno-thread-safety-negative -fcxx-exceptions -DUSE_CAPABILITY=0 %s
|
|
// RUN: %clang_cc1 -fsyntax-only -verify -std=c++11 -Wthread-safety -Wthread-safety-beta -Wthread-safety-verbose -Wno-thread-safety-negative -fcxx-exceptions -DUSE_CAPABILITY=1 %s
|
|
|
|
#include "thread-safety-annotations.h"
|
|
|
|
class LOCKABLE Mutex {
|
|
public:
|
|
void Lock() EXCLUSIVE_LOCK_FUNCTION();
|
|
void ReaderLock() SHARED_LOCK_FUNCTION();
|
|
void Unlock() UNLOCK_FUNCTION();
|
|
bool TryLock() EXCLUSIVE_TRYLOCK_FUNCTION(true);
|
|
bool ReaderTryLock() SHARED_TRYLOCK_FUNCTION(true);
|
|
|
|
// for negative capabilities
|
|
const Mutex& operator!() const { return *this; }
|
|
|
|
void AssertHeld() ASSERT_EXCLUSIVE_LOCK();
|
|
void AssertReaderHeld() ASSERT_SHARED_LOCK();
|
|
};
|
|
|
|
|
|
class Test {
|
|
Mutex mu;
|
|
int a GUARDED_BY(mu); // expected-note3 {{Guarded_by declared here.}}
|
|
|
|
void foo1() EXCLUSIVE_LOCKS_REQUIRED(mu);
|
|
void foo2() SHARED_LOCKS_REQUIRED(mu);
|
|
void foo3() LOCKS_EXCLUDED(mu);
|
|
|
|
void test1() { // expected-note {{Thread warning in function 'test1'}}
|
|
a = 0; // expected-warning {{writing variable 'a' requires holding mutex 'mu' exclusively}}
|
|
}
|
|
|
|
void test2() { // expected-note {{Thread warning in function 'test2'}}
|
|
int b = a; // expected-warning {{reading variable 'a' requires holding mutex 'mu'}}
|
|
}
|
|
|
|
void test3() { // expected-note {{Thread warning in function 'test3'}}
|
|
foo1(); // expected-warning {{calling function 'foo1' requires holding mutex 'mu' exclusively}}
|
|
}
|
|
|
|
void test4() { // expected-note {{Thread warning in function 'test4'}}
|
|
foo2(); // expected-warning {{calling function 'foo2' requires holding mutex 'mu'}}
|
|
}
|
|
|
|
void test5() { // expected-note {{Thread warning in function 'test5'}}
|
|
mu.ReaderLock();
|
|
foo1(); // expected-warning {{calling function 'foo1' requires holding mutex 'mu' exclusively}}
|
|
mu.Unlock();
|
|
}
|
|
|
|
void test6() { // expected-note {{Thread warning in function 'test6'}}
|
|
mu.ReaderLock();
|
|
a = 0; // expected-warning {{writing variable 'a' requires holding mutex 'mu' exclusively}}
|
|
mu.Unlock();
|
|
}
|
|
|
|
void test7() { // expected-note {{Thread warning in function 'test7'}}
|
|
mu.Lock();
|
|
foo3(); // expected-warning {{cannot call function 'foo3' while mutex 'mu' is held}}
|
|
mu.Unlock();
|
|
}
|
|
};
|
|
|