c49f83b6e9
removeEmptyPTLoad() removes empty (p_memsz=0) PT_LOAD segments. In assignFileOffsets(), setFileOffset() unnecessarily advances file offsets for containing empty sections. This is exposed by arm Linux kernel's multi_v5_defconfig (see https://bugs.llvm.org/show_bug.cgi?id=45632) ``` ld.lld (max-page-size=65536): [34] .init.data PROGBITS c0c24000 c34000 0128ac 00 WA 0 0 4096 [35] .text_itcm PROGBITS fffe0000 c50000 000000 00 WA 0 0 1 [36] .data_dtcm PROGBITS fffe8000 c58000 000000 00 WA 0 0 1 [37] .data PROGBITS c0c38000 c58000 0647a0 00 WA 0 0 32 arm-linux-gnueabi-ld (max-page-size=65536): [23] .init.data PROGBITS c0c12000 c22000 0128ac 00 WA 0 0 4096 [24] .text_itcm PROGBITS fffe0000 ca2558 000000 00 W 0 0 1 [25] .data_dtcm PROGBITS fffe8000 ca2558 000000 00 W 0 0 1 [26] .data PROGBITS c0c26000 c36000 0647a0 00 WA 0 0 32 ``` This patch clears OutputSection::ptLoad if ptLoad is removed by removeEmptyPTLoad(). Conceptually this removes "dangling" references. Reviewed By: psmith Differential Revision: https://reviews.llvm.org/D79254
32 lines
1.1 KiB
Plaintext
32 lines
1.1 KiB
Plaintext
# REQUIRES: x86
|
|
# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %p/Inputs/at8.s -o %t.o
|
|
# RUN: ld.lld %t.o --script %s -o %t
|
|
# RUN: llvm-readelf -sections -program-headers %t | FileCheck %s
|
|
|
|
MEMORY {
|
|
FLASH : ORIGIN = 0x08000000, LENGTH = 0x100
|
|
RAM : ORIGIN = 0x20000000, LENGTH = 0x200
|
|
}
|
|
|
|
SECTIONS {
|
|
.text : { *(.text) } > FLASH
|
|
.sec1 : { *(.sec1) } > RAM AT > FLASH
|
|
.sec2 : { *(.sec2) } > RAM AT > FLASH
|
|
.sec3 : { *(.sec3) } > RAM AT > FLASH
|
|
}
|
|
|
|
# Make sure we do not issue a load-address overlap error
|
|
# Previously, .sec3 would overwrite the LMAOffset in the
|
|
# PT_LOAD header.
|
|
|
|
# CHECK: Name Type Address Off
|
|
# CHECK: .text PROGBITS 0000000008000000 000158
|
|
# CHECK: .sec1 PROGBITS 0000000020000000 001000
|
|
# CHECK: .sec2 PROGBITS 0000000020000008 001008
|
|
# CHECK: .sec3 PROGBITS 0000000020000010 001010
|
|
|
|
# CHECK: Program Headers:
|
|
# CHECK: Type Offset VirtAddr PhysAddr
|
|
# CHECK-NEXT: LOAD 0x001000 0x0000000020000000 0x0000000008000000
|
|
# CHECK-NOT: LOAD
|