4b80647367
This is a (last big?) part of the patch series to make SimplifyCFG
preserve DomTree. Currently, it still does not actually preserve it,
even thought it is pretty much fully updated to preserve it.
Once the default is flipped, a valid DomTree must be passed into
simplifyCFG, which means that whatever pass calls simplifyCFG,
should also be smart about DomTree's.
As far as i can see from `check-llvm` with default flipped,
this is the last LLVM test batch (other than bugpoint tests)
that needed fixes to not break with default flipped.
The changes here are boringly identical to the ones i did
over 42+ times/commits recently already,
so while AMDGPU is outside of my normal ecosystem,
i'm going to go for post-commit review here,
like in all the other 42+ changes.
Note that while the pass is taught to preserve {,Post}DomTree,
it still doesn't do that by default, because simplifycfg
still doesn't do that by default, and flipping default
in this pass will implicitly flip the default for simplifycfg.
That will happen, but not right now.
41 lines
1.4 KiB
LLVM
41 lines
1.4 KiB
LLVM
; RUN: llc -march=amdgcn -verify-machineinstrs -simplifycfg-require-and-preserve-domtree=1 < %s | FileCheck -check-prefix=GCN %s
|
|
; RUN: llc -march=amdgcn -mcpu=tonga -mattr=-flat-for-global -verify-machineinstrs -simplifycfg-require-and-preserve-domtree=1 < %s | FileCheck -check-prefix=GCN %s
|
|
|
|
; This used to crash because during intermediate control flow lowering, there
|
|
; was a sequence
|
|
; s_mov_b64 s[0:1], exec
|
|
; s_and_b64 s[2:3], s[0:1], s[2:3] ; def & use of the same register pair
|
|
; ...
|
|
; s_mov_b64_term exec, s[2:3]
|
|
; that was not treated correctly.
|
|
;
|
|
; GCN-LABEL: {{^}}ham:
|
|
; GCN-DAG: v_cmp_lt_f32_e64 [[OTHERCC:s\[[0-9]+:[0-9]+\]]],
|
|
; GCN-DAG: v_cmp_lt_f32_e32 vcc,
|
|
; GCN: s_and_b64 [[AND:s\[[0-9]+:[0-9]+\]]], vcc, [[OTHERCC]]
|
|
; GCN: s_and_saveexec_b64 [[SAVED:s\[[0-9]+:[0-9]+\]]], [[AND]]
|
|
|
|
; GCN-NEXT: ; %bb.{{[0-9]+}}: ; %bb4
|
|
; GCN: ds_write_b32
|
|
|
|
; GCN: ; %bb.{{[0-9]+}}:
|
|
; GCN-NEXT: s_endpgm
|
|
; GCN-NEXT: .Lfunc_end
|
|
define amdgpu_ps void @ham(float %arg, float %arg1) #0 {
|
|
bb:
|
|
%tmp = fcmp ogt float %arg, 0.000000e+00
|
|
%tmp2 = fcmp ogt float %arg1, 0.000000e+00
|
|
%tmp3 = and i1 %tmp, %tmp2
|
|
br i1 %tmp3, label %bb4, label %bb5
|
|
|
|
bb4: ; preds = %bb
|
|
store volatile i32 4, i32 addrspace(3)* undef
|
|
unreachable
|
|
|
|
bb5: ; preds = %bb
|
|
ret void
|
|
}
|
|
|
|
attributes #0 = { nounwind readonly "InitialPSInputAddr"="36983" }
|
|
attributes #1 = { nounwind readnone }
|