5fe10263ab
Enable performing mandatory inlinings upfront, by reusing the same logic as the full inliner, instead of the AlwaysInliner. This has the following benefits: - reduce code duplication - one inliner codebase - open the opportunity to help the full inliner by performing additional function passes after the mandatory inlinings, but before th full inliner. Performing the mandatory inlinings first simplifies the problem the full inliner needs to solve: less call sites, more contextualization, and, depending on the additional function optimization passes run between the 2 inliners, higher accuracy of cost models / decision policies. Note that this patch does not yet enable much in terms of post-always inline function optimization. Differential Revision: https://reviews.llvm.org/D91567
41 lines
1.4 KiB
LLVM
41 lines
1.4 KiB
LLVM
; Test behavior when inlining policy grows size out of control.
|
|
; In all cases, the end result is the same: mandatory inlinings must happen.
|
|
; However, when we discover we 'trip' over the artificially-low size increase
|
|
; factor, we don't inline anymore.
|
|
; REQUIRES: have_tf_aot
|
|
; RUN: opt -passes=scc-oz-module-inliner -enable-ml-inliner=release -ml-advisor-size-increase-threshold=10.0 -S < %s 2>&1 | FileCheck %s --check-prefix=CHECK --check-prefix=NOBOUNDS
|
|
; RUN: opt -passes=scc-oz-module-inliner -enable-ml-inliner=release -ml-advisor-size-increase-threshold=1.0 -S < %s 2>&1 | FileCheck %s --check-prefix=CHECK --check-prefix=BOUNDS
|
|
|
|
target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
|
|
target triple = "x86_64-grtev4-linux-gnu"
|
|
|
|
declare i64 @f1()
|
|
|
|
define i64 @f2() #0 {
|
|
%r = call i64 @f1()
|
|
%r2 = add i64 13, %r
|
|
ret i64 %r2
|
|
}
|
|
|
|
define i64 @some_function() {
|
|
%r = call i64 @f1()
|
|
%r2 = add i64 13, %r
|
|
ret i64 %r2
|
|
}
|
|
|
|
define i64 @top() {
|
|
%r = call i64 @f2()
|
|
%r2 = call i64 @some_function()
|
|
%r3 = add i64 %r, %r2
|
|
ret i64 %r3
|
|
}
|
|
|
|
attributes #0 = { alwaysinline }
|
|
|
|
; CHECK-LABEL: @top
|
|
; f2 must always be inlined, so we won't find a call to it in @top()
|
|
; CHECK-NOT: call i64 @f2
|
|
; @some-function isn't mandatory, and when we set the increase threshold too low,
|
|
; it won't be inlined.
|
|
; NOBOUNDS-NOT: @some_function
|
|
; BOUNDS: call i64 @some_function |