b37543750c
This patch updates ValueLattice to distinguish between ranges that are
guaranteed to not include undef and ranges that may include undef.
A constant range guaranteed to not contain undef can be used to simplify
instructions to arbitrary values. A constant range that may contain
undef can only be used to simplify to a constant. If the value can be
undef, it might take a value outside the range. For example, consider
the snipped below
define i32 @f(i32 %a, i1 %c) {
br i1 %c, label %true, label %false
true:
%a.255 = and i32 %a, 255
br label %exit
false:
br label %exit
exit:
%p = phi i32 [ %a.255, %true ], [ undef, %false ]
%f.1 = icmp eq i32 %p, 300
call void @use(i1 %f.1)
%res = and i32 %p, 255
ret i32 %res
}
In the exit block, %p would be a constant range [0, 256) including undef as
%p could be undef. We can use the range information to replace %f.1 with
false because we remove the compare, effectively forcing the use of the
constant to be != 300. We cannot replace %res with %p however, because
if %a would be undef %cond may be true but the second use might not be
< 256.
Currently LazyValueInfo uses the new behavior just when simplifying AND
instructions and does not distinguish between constant ranges with and
without undef otherwise. I think we should address the remaining issues
in LVI incrementally.
Reviewers: efriedma, reames, aqjune, jdoerfert, sstefan1
Reviewed By: efriedma
Differential Revision: https://reviews.llvm.org/D76931
45 lines
1.2 KiB
LLVM
45 lines
1.2 KiB
LLVM
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
|
|
; RUN: opt -S -ipsccp %s | FileCheck %s
|
|
|
|
; Make sure IPSCCP does not assume %r < 256 for @f1. Undef is passed at a call
|
|
; site, which won't be eliminated.
|
|
|
|
define i1 @constant_and_undef(i64 %a) {
|
|
; CHECK-LABEL: @constant_and_undef(
|
|
; CHECK-NEXT: [[C_1:%.*]] = call i1 @f1(i64 undef)
|
|
; CHECK-NEXT: br label [[BB1:%.*]]
|
|
; CHECK: bb1:
|
|
; CHECK-NEXT: [[C_2:%.*]] = call i1 @f1(i64 10)
|
|
; CHECK-NEXT: br label [[BB2:%.*]]
|
|
; CHECK: bb2:
|
|
; CHECK-NEXT: [[RANGE:%.*]] = and i64 [[A:%.*]], 255
|
|
; CHECK-NEXT: [[C_3:%.*]] = call i1 @f1(i64 [[RANGE]])
|
|
; CHECK-NEXT: ret i1 true
|
|
;
|
|
%c.1 = call i1 @f1(i64 undef)
|
|
br label %bb1
|
|
|
|
bb1:
|
|
%c.2 = call i1 @f1(i64 10)
|
|
br label %bb2
|
|
|
|
bb2:
|
|
%range = and i64 %a, 255
|
|
%c.3 = call i1 @f1(i64 %range)
|
|
%r.1 = and i1 %c.1, %c.2
|
|
%r.2 = and i1 %r.1, %c.3
|
|
ret i1 %r.2
|
|
}
|
|
|
|
declare void @sideeffect(i1, i64 %a)
|
|
|
|
define internal i1 @f1(i64 %r) {
|
|
; CHECK-LABEL: define {{.*}} @f1(
|
|
; CHECK-NEXT: call void @sideeffect(i1 true, i64 [[R:%.*]])
|
|
; CHECK-NEXT: ret i1 undef
|
|
;
|
|
%c = icmp ult i64 %r, 256
|
|
call void @sideeffect(i1 %c, i64 %r)
|
|
ret i1 %c
|
|
}
|