60df7c08b1
We have the following issues related to group sections: 1) yaml2obj is unable to set the custom `sh_entsize` value, because the `EntSize` key is currently ignored. 2) obj2yaml is unable to dump the group section which `sh_entsize != 4`. 3) obj2yaml always dumps the "EntSize" for group sections, though usually we are trying to omit dumping default values when dumping keys. I.e. we should not print the "EntSize" key when `sh_entsize` == 4. This patch fixes (1),(3) and adds the test case to document the behavior of (2). Differential revision: https://reviews.llvm.org/D93854
60 lines
1.8 KiB
YAML
60 lines
1.8 KiB
YAML
## Checks that the tool is able to read section groups from ELF.
|
|
|
|
## Check how groups sections are dumped.
|
|
## Check we don't dump the "EntSize" key when sh_entsize == 4.
|
|
|
|
# RUN: yaml2obj %s -o %t1.o
|
|
# RUN: obj2yaml %t1.o | FileCheck %s -DSEC=.rodata
|
|
|
|
# CHECK: - Name: .group
|
|
# CHECK-NEXT: Type: SHT_GROUP
|
|
# CHECK-NEXT: Link: .symtab
|
|
# CHECK-NEXT: Info: signature
|
|
# CHECK-NEXT: Members:
|
|
# CHECK-NEXT: - SectionOrType: GRP_COMDAT
|
|
# CHECK-NEXT: - SectionOrType: [[SEC]]
|
|
# CHECK-NEXT: - Name:
|
|
|
|
--- !ELF
|
|
FileHeader:
|
|
Class: ELFCLASS64
|
|
Data: ELFDATA2LSB
|
|
Type: ET_REL
|
|
Sections:
|
|
- Name: .group
|
|
Type: SHT_GROUP
|
|
Link: .symtab
|
|
Info: [[INFO=signature]]
|
|
EntSize: [[ENTSIZE=<none>]]
|
|
Members:
|
|
- SectionOrType: GRP_COMDAT
|
|
- SectionOrType: [[SEC=.rodata]]
|
|
- Name: .rodata
|
|
Type: SHT_PROGBITS
|
|
Symbols:
|
|
- Name: signature
|
|
Type: STT_OBJECT
|
|
Section: .rodata
|
|
|
|
## Document that yaml2obj can't dump the SHT_GROUP section when its sh_entsize != 4.
|
|
|
|
# RUN: yaml2obj %s -DENTSIZE=0xfe -o %t1.entsize.o
|
|
# RUN: not obj2yaml %t1.entsize.o 2>&1 | \
|
|
# RUN: FileCheck %s -DFILE=%t1.entsize.o --check-prefix=ENTSIZE
|
|
|
|
# ENTSIZE: Error reading file: [[FILE]]: section [index 1] has invalid sh_entsize: expected 4, but got 254
|
|
|
|
## Check we are able to dump members of the SHT_GROUP section even when
|
|
## one of them has section index 0.
|
|
|
|
# RUN: yaml2obj -DSEC=0 %s -o %tnull.o
|
|
# RUN: obj2yaml %tnull.o | FileCheck %s -DSEC="''"
|
|
|
|
## Check obj2yaml report an error when sh_info field of
|
|
## group section contains invalid (too large) signature symbol index.
|
|
|
|
# RUN: yaml2obj -DINFO=0xFF %s -o %t2.o
|
|
# RUN: not obj2yaml %t2.o 2>&1 | FileCheck %s -DFILE=%t2.o --check-prefix=ERR
|
|
|
|
# ERR: Error reading file: [[FILE]]: unable to get symbol from section [index 3]: invalid symbol index (255)
|